firewire: core: fix type of transaction data in config ROM parser test

[PATCH] firewire: core: fix type of transaction data in config ROM parser test

Posted by Takashi Sakamoto 2 weeks, 3 days ago

The type of transaction data should be __be32 in the stub function for the
asynchronous transactions.

Fixes: 23e0d2e849eb ("firewire: core: add test to detect irm-is-1394-1995-only quirk in config ROM parser")
Fixes: f8e5070bf292 ("firewire: core: add test to avoid excessive configuration ROM length")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609060257.8wQo9w9N-lkp@intel.com/
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 drivers/firewire/config-rom-parser-test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/config-rom-parser-test.c b/drivers/firewire/config-rom-parser-test.c
index e5c173353057..45f1ead326c5 100644
--- a/drivers/firewire/config-rom-parser-test.c
+++ b/drivers/firewire/config-rom-parser-test.c
@@ -206,7 +206,7 @@ static int stub_run_transaction_regular(struct fw_card *card, int tcode, int des
 	KUNIT_ASSERT_EQ(test, length, 4);
 
 	unsigned int index = (offset - (CSR_REGISTER_BASE | CSR_CONFIG_ROM)) / sizeof(u32);
-	u32 *quadlet = payload;
+	__be32 *quadlet = payload;
 
 	KUNIT_EXPECT_LE(test, speed, param->expected_speed);
 	KUNIT_EXPECT_LT(test, index, param->quadlet_length);
@@ -264,7 +264,7 @@ static int stub_run_transaction_malformed(struct fw_card *card, int tcode, int d
 	KUNIT_ASSERT_EQ(test, length, 4);
 
 	unsigned int index = (offset - (CSR_REGISTER_BASE | CSR_CONFIG_ROM)) / sizeof(u32);
-	u32 *quadlet = payload;
+	__be32 *quadlet = payload;
 
 	if (index < ARRAY_SIZE(config_rom_first_part))
 		*quadlet = cpu_to_be32(config_rom_first_part[index]);
-- 
2.53.0

Re: [PATCH] firewire: core: fix type of transaction data in config ROM parser test

Posted by Takashi Sakamoto 2 weeks, 1 day ago

Hi,

On Tue, Sep 08, 2026 at 09:29:29PM +0900, Takashi Sakamoto wrote:
> The type of transaction data should be __be32 in the stub function for the
> asynchronous transactions.
> 
> Fixes: 23e0d2e849eb ("firewire: core: add test to detect irm-is-1394-1995-only quirk in config ROM parser")
> Fixes: f8e5070bf292 ("firewire: core: add test to avoid excessive configuration ROM length")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202609060257.8wQo9w9N-lkp@intel.com/
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
>  drivers/firewire/config-rom-parser-test.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto