firewire: core: fix type of hard-coded image in config ROM generator test

[PATCH] firewire: core: fix type of hard-coded image in config ROM generator test

Posted by Takashi Sakamoto 2 weeks, 3 days ago

The type of the hard-coded configuration ROM image should be __be32
instead of u32.

Fixes: ee9a8c9afb57 ("firewire: core: add test for root directory generation in config ROM generator")
Fixes: 996096154e7b ("firewire: core: add test to generate with AV/C unit in config ROM generator")
Fixes: 7bd19bbed9ea ("firewire: core: add test to generate with IIDC unit in config ROM generator")
Fixes: c3b64c7d752c ("firewire: core: add test to generate with both AV/C and IIDC units in config ROM generator")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609060630.rC0Zz88P-lkp@intel.com/
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609061023.GbWS6Skb-lkp@intel.com/
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
 drivers/firewire/config-rom-generator-test.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/firewire/config-rom-generator-test.c b/drivers/firewire/config-rom-generator-test.c
index 212dbdcd43ba..dd2e71213209 100644
--- a/drivers/firewire/config-rom-generator-test.c
+++ b/drivers/firewire/config-rom-generator-test.c
@@ -9,7 +9,7 @@
 #include <kunit/test.h>
 #include <kunit/device.h>
 
-static const u32 config_rom_bare[] = {
+static const __be32 config_rom_bare[] = {
 	cpu_to_be32(0x0404921b), // bus info
 	cpu_to_be32(0x31333934), // |
 	cpu_to_be32(0xf000b223), // |
@@ -52,7 +52,7 @@ static const u32 avc_unit_directory_and_leaf[] = {
 	0x50756900,	// Pui is the name of a cat that the author takes care of.
 };
 
-static const u32 config_rom_with_avc_unit[] = {
+static const __be32 config_rom_with_avc_unit[] = {
 	cpu_to_be32(0x0404c1e5), // bus info
 	cpu_to_be32(0x31333934), // |
 	cpu_to_be32(0xf000b233), // |
@@ -116,7 +116,7 @@ static const u32 iidc_unit_directories_and_leafs[] = {
 	0x20436174,
 };
 
-static const u32 config_rom_with_iidc_unit[] = {
+static const __be32 config_rom_with_iidc_unit[] = {
 	cpu_to_be32(0x04046a3e), // bus info
 	cpu_to_be32(0x31333934), // |
 	cpu_to_be32(0xf000b243), // |
@@ -162,7 +162,7 @@ static const u32 config_rom_with_iidc_unit[] = {
 	cpu_to_be32(0x20436174), // v
 };
 
-static const u32 config_rom_with_avc_and_iidc_units[] = {
+static const __be32 config_rom_with_avc_and_iidc_units[] = {
 	cpu_to_be32(0x040439c0), // bus info
 	cpu_to_be32(0x31333934), // |
 	cpu_to_be32(0xf000b253), // |
-- 
2.53.0

Re: [PATCH] firewire: core: fix type of hard-coded image in config ROM generator test

Posted by Takashi Sakamoto 2 weeks, 1 day ago

Hi,

On Tue, Sep 08, 2026 at 09:29:00PM +0900, Takashi Sakamoto wrote:
> The type of the hard-coded configuration ROM image should be __be32
> instead of u32.
> 
> Fixes: ee9a8c9afb57 ("firewire: core: add test for root directory generation in config ROM generator")
> Fixes: 996096154e7b ("firewire: core: add test to generate with AV/C unit in config ROM generator")
> Fixes: 7bd19bbed9ea ("firewire: core: add test to generate with IIDC unit in config ROM generator")
> Fixes: c3b64c7d752c ("firewire: core: add test to generate with both AV/C and IIDC units in config ROM generator")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202609060630.rC0Zz88P-lkp@intel.com/
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202609061023.GbWS6Skb-lkp@intel.com/
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
>  drivers/firewire/config-rom-generator-test.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to for-next branch.


Regards

Takashi Sakamoto