[PATCH v2] hwmon: (yogafan) Update reference database and contributors for new models

Sergio Melas posted 1 patch 2 weeks, 3 days ago
Documentation/hwmon/yogafan.rst | 4 ++++
1 file changed, 4 insertions(+)
[PATCH v2] hwmon: (yogafan) Update reference database and contributors for new models
Posted by Sergio Melas 2 weeks, 3 days ago
Add documentation entries for the newly supported laptop models
(Yoga 14cACN 2021, Yoga 740-15IML, and IdeaPad 3 15ALC6 Ub) in the
master reference database table, and include the new contributor.

Signed-off-by: Sergio Melas <sergiomelas@gmail.com>
---
v2: Split changes and addressed reviewer comments.
---
 Documentation/hwmon/yogafan.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst
index 9ff5db5dc..5c21c50b7 100644
--- a/Documentation/hwmon/yogafan.rst
+++ b/Documentation/hwmon/yogafan.rst
@@ -87,6 +87,9 @@ immediately to ensure the user knows the fan has stopped.
 
  MODEL (DMI PN) | FAMILY / SERIES  | EC OFFSET | FULL ACPI OBJECT PATH          | WIDTH  | MULTiplier
  ----------------------------------------------------------------------------------------------------
+ 82N7           | Yoga 14cACN 2021   | 0x06      | \_SB.PCI0.LPC0.EC0.FANS        |  8-bit | 100
+ 81TD           | Yoga 740-15IML     | 0x06      | \_SB.PCI0.LPCB.EC0.FANS        |  8-bit | 100
+ 82KU           | IdeaPad 3 15ALC6 Ub| 0x06      | \_SB.PCI0.LPC0.EC0.FANS/FA2S   |  8-bit | 100
  82N7           | Yoga 14cACN      | 0x06      | \_SB.PCI0.LPC0.EC0.FANS        |  8-bit | 100
  80V2 / 81C3    | Yoga 710/720     | 0x06      | \_SB.PCI0.LPC0.EC0.FAN0        |  8-bit | 100
  83E2           | Yoga Pro 7       | 0xFE      | \_SB.PCI0.LPC0.EC0.FANS        |  8-bit | 100
@@ -159,6 +162,7 @@ Contributors & DSDT Providers:
 - **Sarbajit Sarkar** (Lenovo LOQ 15IAX9)
 - **HinataKato** (XiaoXin Pro 13ARE 2020 - 83KF)
 - **PenPenIsGod** (IdeaPad 3 15ALC6 - 82KU & Legion Pro 7 16AFR10H - 83RU)
+- **wizard-28** (IdeaPad 3 15ALC6 Ub - 82KU)
 - **unlockxiaom** (Legion Pro 7 16AFR10H - 83RU, Yoga Pro 7 14IAH10 - 83KF, ThinkCentre M80q)
 - **Phani Pavan K** (Yoga Pro 7 14IAH10 - 83KF)
 - **Splarkszter** (Yoga 7 16ARP8 - 83BS)
-- 
2.55.0
Re: [PATCH v2] hwmon: (yogafan) Update reference database and contributors for new models
Posted by Guenter Roeck 2 weeks, 3 days ago
On Tue, Sep 08, 2026 at 11:50:09AM +0200, Sergio Melas wrote:
> Add documentation entries for the newly supported laptop models
> (Yoga 14cACN 2021, Yoga 740-15IML, and IdeaPad 3 15ALC6 Ub) in the
> master reference database table, and include the new contributor.
> 
> Signed-off-by: Sergio Melas <sergiomelas@gmail.com>
> ---
> v2: Split changes and addressed reviewer comments.

This wasn't just a split. v1 changed the code and the table contents.
This is no longer the case. This version just adds support for the new
models. With the lack of content changes, it would have been appropriate
to submit this as single patch.

What am I missing ?

Guenter

> ---
>  Documentation/hwmon/yogafan.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/hwmon/yogafan.rst b/Documentation/hwmon/yogafan.rst
> index 9ff5db5dc..5c21c50b7 100644
> --- a/Documentation/hwmon/yogafan.rst
> +++ b/Documentation/hwmon/yogafan.rst
> @@ -87,6 +87,9 @@ immediately to ensure the user knows the fan has stopped.
>  
>   MODEL (DMI PN) | FAMILY / SERIES  | EC OFFSET | FULL ACPI OBJECT PATH          | WIDTH  | MULTiplier
>   ----------------------------------------------------------------------------------------------------
> + 82N7           | Yoga 14cACN 2021   | 0x06      | \_SB.PCI0.LPC0.EC0.FANS        |  8-bit | 100
> + 81TD           | Yoga 740-15IML     | 0x06      | \_SB.PCI0.LPCB.EC0.FANS        |  8-bit | 100
> + 82KU           | IdeaPad 3 15ALC6 Ub| 0x06      | \_SB.PCI0.LPC0.EC0.FANS/FA2S   |  8-bit | 100
>   82N7           | Yoga 14cACN      | 0x06      | \_SB.PCI0.LPC0.EC0.FANS        |  8-bit | 100
>   80V2 / 81C3    | Yoga 710/720     | 0x06      | \_SB.PCI0.LPC0.EC0.FAN0        |  8-bit | 100
>   83E2           | Yoga Pro 7       | 0xFE      | \_SB.PCI0.LPC0.EC0.FANS        |  8-bit | 100
> @@ -159,6 +162,7 @@ Contributors & DSDT Providers:
>  - **Sarbajit Sarkar** (Lenovo LOQ 15IAX9)
>  - **HinataKato** (XiaoXin Pro 13ARE 2020 - 83KF)
>  - **PenPenIsGod** (IdeaPad 3 15ALC6 - 82KU & Legion Pro 7 16AFR10H - 83RU)
> +- **wizard-28** (IdeaPad 3 15ALC6 Ub - 82KU)
>  - **unlockxiaom** (Legion Pro 7 16AFR10H - 83RU, Yoga Pro 7 14IAH10 - 83KF, ThinkCentre M80q)
>  - **Phani Pavan K** (Yoga Pro 7 14IAH10 - 83KF)
>  - **Splarkszter** (Yoga 7 16ARP8 - 83BS)
Re: [PATCH v2] hwmon: (yogafan) Update reference database and contributors for new models
Posted by Sergio Melas 2 weeks, 3 days ago
Hi Guenter,

Understood. My apologies, I misinterpreted your feedback and split the
documentation thinking you wanted it strictly isolated from the driver changes.

Since the driver patch is already in, please either apply this documentation
update as-is to keep things in sync, or let me know if I should drop it
and bundle it with the next patch set.

Thanks,
Sergio

Signed-off-by: Sergio Melas <sergiomelas@gmail.com>
Re: [PATCH v2] hwmon: (yogafan) Update reference database and contributors for new models
Posted by Guenter Roeck 2 weeks, 3 days ago
On 9/8/26 11:48, Sergio Melas wrote:
> Hi Guenter,
> 
> Understood. My apologies, I misinterpreted your feedback and split the
> documentation thinking you wanted it strictly isolated from the driver changes.
> 
No, separation is per logical change, and the documentation should be updated
together with the code. In the original patch you also implemented functional
changes. I wanted those separated.

> Since the driver patch is already in, please either apply this documentation
> update as-is to keep things in sync, or let me know if I should drop it
> and bundle it with the next patch set.
> 

It looks like it has some formatting issues. Please fix and resubmit
just this patch, and I can squash it with the driver change. Alternatively,
submit both the driver and documentation update as single patch but, again,
_only_ add the new models with that patch. In that case I'll just replace
the applied patch with the new one.

Thanks,
Guenter