1. Patchew
  2. linux
  3. View series

[PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats

Navya Malempati posted 1 patch 2 weeks, 3 days ago 
drivers/soc/qcom/qcom_stats.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
[PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats
Posted by Navya Malempati 2 weeks, 3 days ago 
Add SMEM items for four NSP subsystems stats which are present in Nord
SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
id. Add new entries for NSP1/2/3.

Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
---
 drivers/soc/qcom/qcom_stats.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
index 06923408bfce..91f2d1293124 100644
--- a/drivers/soc/qcom/qcom_stats.c
+++ b/drivers/soc/qcom/qcom_stats.c
@@ -43,8 +43,11 @@ static const struct subsystem_data subsystems[] = {
 	{ "modem", 605, 1 },
 	{ "wpss", 605, 13 },
 	{ "adsp", 606, 2 },
-	{ "cdsp", 607, 5 },
+	{ "cdsp_nsp", 607, 5 },
 	{ "cdsp1", 607, 12 },
+	{ "cdsp_nsp_1", 607, 69 },
+	{ "cdsp_nsp_2", 607, 133 },
+	{ "cdsp_nsp_3", 607, 197 },
 	{ "gpdsp0", 607, 17 },
 	{ "gpdsp1", 607, 18 },
 	{ "soccp", 607, 19 },

---
base-commit: af5f12805e5cefa4fe68d6127c7e1fb78cd5535c
change-id: 20260907-nord_stats-ea163d025d43

Best regards,
--  
Navya Malempati <navya.malempati@oss.qualcomm.com>
Re: [PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats
Posted by Abel Vesa 1 week, 3 days ago 
On 26-09-08 13:43:08, Navya Malempati wrote:
> Add SMEM items for four NSP subsystems stats which are present in Nord
> SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
> id. Add new entries for NSP1/2/3.
> 
> Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Re: [PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats
Posted by Maulik Shah 1 week, 3 days ago 

On 08-09-2026 13:43, Navya Malempati wrote:
> Add SMEM items for four NSP subsystems stats which are present in Nord
> SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
> id. Add new entries for NSP1/2/3.

Reviewed-by: Maulik Shah <maulik.shah@oss.qualcomm.com>

Thanks,
Maulik

>
> Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
> ---
>  drivers/soc/qcom/qcom_stats.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
> index 06923408bfce..91f2d1293124 100644
> --- a/drivers/soc/qcom/qcom_stats.c
> +++ b/drivers/soc/qcom/qcom_stats.c
> @@ -43,8 +43,11 @@ static const struct subsystem_data subsystems[] = {
>  	{ "modem", 605, 1 },
>  	{ "wpss", 605, 13 },
>  	{ "adsp", 606, 2 },
> -	{ "cdsp", 607, 5 },
> +	{ "cdsp_nsp", 607, 5 },
>  	{ "cdsp1", 607, 12 },
> +	{ "cdsp_nsp_1", 607, 69 },
> +	{ "cdsp_nsp_2", 607, 133 },
> +	{ "cdsp_nsp_3", 607, 197 },
>  	{ "gpdsp0", 607, 17 },
>  	{ "gpdsp1", 607, 18 },
>  	{ "soccp", 607, 19 },
>
> ---
> base-commit: af5f12805e5cefa4fe68d6127c7e1fb78cd5535c
> change-id: 20260907-nord_stats-ea163d025d43
>
> Best regards,
> --  
> Navya Malempati <navya.malempati@oss.qualcomm.com>
Re: [PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats
Posted by Pankaj Patil 2 weeks, 3 days ago 
On 9/8/2026 1:43 PM, Navya Malempati wrote:
> Add SMEM items for four NSP subsystems stats which are present in Nord
> SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
> id. Add new entries for NSP1/2/3.

For other targets as well is the same applicable? NSP and CDSP are interchangeable?

> 
> Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
> ---
>  drivers/soc/qcom/qcom_stats.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
> index 06923408bfce..91f2d1293124 100644
> --- a/drivers/soc/qcom/qcom_stats.c
> +++ b/drivers/soc/qcom/qcom_stats.c
> @@ -43,8 +43,11 @@ static const struct subsystem_data subsystems[] = {
>  	{ "modem", 605, 1 },
>  	{ "wpss", 605, 13 },
>  	{ "adsp", 606, 2 },
> -	{ "cdsp", 607, 5 },
> +	{ "cdsp_nsp", 607, 5 },
>  	{ "cdsp1", 607, 12 },

Is cdsp1 not the same as nsp1?
Adding cdsp_nsp_1 is very SOC specific

> +	{ "cdsp_nsp_1", 607, 69 },
> +	{ "cdsp_nsp_2", 607, 133 },
> +	{ "cdsp_nsp_3", 607, 197 },
>  	{ "gpdsp0", 607, 17 },
>  	{ "gpdsp1", 607, 18 },
>  	{ "soccp", 607, 19 },
> 
> ---
> base-commit: af5f12805e5cefa4fe68d6127c7e1fb78cd5535c
> change-id: 20260907-nord_stats-ea163d025d43
> 
> Best regards,
> --  
> Navya Malempati <navya.malempati@oss.qualcomm.com>
> 
>
Re: [PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats
Posted by Navya Malempati 1 week, 3 days ago 

On 9/8/2026 3:33 PM, Pankaj Patil wrote:
> On 9/8/2026 1:43 PM, Navya Malempati wrote:
>> Add SMEM items for four NSP subsystems stats which are present in Nord
>> SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
>> id. Add new entries for NSP1/2/3.
> 
> For other targets as well is the same applicable? NSP and CDSP are interchangeable?
> 
 From the stats point of view, they are the same, we used the name NSP 
in downstream, it looks like Nord SoC remoteproc is using the name CDSP [1]

[1] 
https://lore.kernel.org/linux-arm-msm/20260904081619.593602-2-shengchao.guo@oss.qualcomm.com/

>>
>> Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
>> ---
>>   drivers/soc/qcom/qcom_stats.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
>> index 06923408bfce..91f2d1293124 100644
>> --- a/drivers/soc/qcom/qcom_stats.c
>> +++ b/drivers/soc/qcom/qcom_stats.c
>> @@ -43,8 +43,11 @@ static const struct subsystem_data subsystems[] = {
>>   	{ "modem", 605, 1 },
>>   	{ "wpss", 605, 13 },
>>   	{ "adsp", 606, 2 },
>> -	{ "cdsp", 607, 5 },
>> +	{ "cdsp_nsp", 607, 5 },
>>   	{ "cdsp1", 607, 12 },
> 
> Is cdsp1 not the same as nsp1?

No, cdsp1 is not the same as nsp1.

> Adding cdsp_nsp_1 is very SOC specific
> 
No, this is not a SoC specific setting.

Thanks,
Navya
Re: [PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats
Posted by Konrad Dybcio 1 week ago 
On 9/15/26 6:09 AM, Navya Malempati wrote:
> 
> 
> On 9/8/2026 3:33 PM, Pankaj Patil wrote:
>> On 9/8/2026 1:43 PM, Navya Malempati wrote:
>>> Add SMEM items for four NSP subsystems stats which are present in Nord
>>> SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
>>> id. Add new entries for NSP1/2/3.
>>
>> For other targets as well is the same applicable? NSP and CDSP are interchangeable?
>>
> From the stats point of view, they are the same, we used the name NSP in downstream, it looks like Nord SoC remoteproc is using the name CDSP [1]
> 
> [1] https://lore.kernel.org/linux-arm-msm/20260904081619.593602-2-shengchao.guo@oss.qualcomm.com/
> 
>>>
>>> Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
>>> ---
>>>   drivers/soc/qcom/qcom_stats.c | 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
>>> index 06923408bfce..91f2d1293124 100644
>>> --- a/drivers/soc/qcom/qcom_stats.c
>>> +++ b/drivers/soc/qcom/qcom_stats.c
>>> @@ -43,8 +43,11 @@ static const struct subsystem_data subsystems[] = {
>>>       { "modem", 605, 1 },
>>>       { "wpss", 605, 13 },
>>>       { "adsp", 606, 2 },
>>> -    { "cdsp", 607, 5 },
>>> +    { "cdsp_nsp", 607, 5 },
>>>       { "cdsp1", 607, 12 },
>>
>> Is cdsp1 not the same as nsp1?
> 
> No, cdsp1 is not the same as nsp1.

It would make sense to explain the difference here!

Konrad
Re: [PATCH] soc: qcom: qcom_stats: Add support for NSP subsystem stats
Posted by Pankaj Patil 4 days, 5 hours ago 
On 9/18/2026 2:04 PM, Konrad Dybcio wrote:
> On 9/15/26 6:09 AM, Navya Malempati wrote:
>>
>>
>> On 9/8/2026 3:33 PM, Pankaj Patil wrote:
>>> On 9/8/2026 1:43 PM, Navya Malempati wrote:
>>>> Add SMEM items for four NSP subsystems stats which are present in Nord
>>>> SoC. Rename CDSP stats as CDSP_NSP as both use same PID and SMEM item
>>>> id. Add new entries for NSP1/2/3.
>>>
>>> For other targets as well is the same applicable? NSP and CDSP are interchangeable?
>>>
>> From the stats point of view, they are the same, we used the name NSP in downstream, it looks like Nord SoC remoteproc is using the name CDSP [1]
>>
>> [1] https://lore.kernel.org/linux-arm-msm/20260904081619.593602-2-shengchao.guo@oss.qualcomm.com/
>>

Downstream conventions can't be added upstream, if upstream dt entries
are not named the same way. Please revert this

>>>>
>>>> Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
>>>> ---
>>>>   drivers/soc/qcom/qcom_stats.c | 5 ++++-
>>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
>>>> index 06923408bfce..91f2d1293124 100644
>>>> --- a/drivers/soc/qcom/qcom_stats.c
>>>> +++ b/drivers/soc/qcom/qcom_stats.c
>>>> @@ -43,8 +43,11 @@ static const struct subsystem_data subsystems[] = {
>>>>       { "modem", 605, 1 },
>>>>       { "wpss", 605, 13 },
>>>>       { "adsp", 606, 2 },
>>>> -    { "cdsp", 607, 5 },
>>>> +    { "cdsp_nsp", 607, 5 },
>>>>       { "cdsp1", 607, 12 },
>>>
>>> Is cdsp1 not the same as nsp1?
>>
>> No, cdsp1 is not the same as nsp1.

Please explain if the dt entries are named as remoteproc_cdspx then what
does cdsp_nspx correspond to? Subsystems are common across all soc's

> 
> It would make sense to explain the difference here!
> 
> Konrad

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.