[PATCH 0/7] ASoC: mediatek: mt8188: Improve error handling

phucduc.bui@gmail.com posted 7 patches 2 weeks, 4 days ago
sound/soc/mediatek/mt8188/mt8188-afe-clk.c    | 115 +++++++++++++-----
sound/soc/mediatek/mt8188/mt8188-afe-pcm.c    |  34 ++++--
sound/soc/mediatek/mt8188/mt8188-audsys-clk.c |  12 +-
3 files changed, 113 insertions(+), 48 deletions(-)
[PATCH 0/7] ASoC: mediatek: mt8188: Improve error handling
Posted by phucduc.bui@gmail.com 2 weeks, 4 days ago
From: bui duc phuc <phucduc.bui@gmail.com>

Hi all,

This series improves error handling in several parts of the MT8188 AFE
driver.
Propagate errors from clock, regmap, and runtime resume operations,
remove redundant probe error messages, and fix clock cleanup on
registration failure.

Compile-tested only.

Best regards,
Phuc

bui duc phuc (7):
  ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate clock initialization
    errors
  ASoC: mediatek: mt8188: mt8188-afe-clk: Handle tuner clock enable
    errors
  ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate regmap update errors
  ASoC: mediatek: mt8188: mt8188-afe-clk: Handle clock enable errors
  ASoC: mediatek: mt8188: mt8188-afe-pcm: Handle runtime resume errors
  ASoC: mediatek: mt8188: mt8188-afe-pcm: Drop redundant probe error
    messages
  ASoC: mediatek: mt8188: fix clk leak on error in audsys_clk_register

 sound/soc/mediatek/mt8188/mt8188-afe-clk.c    | 115 +++++++++++++-----
 sound/soc/mediatek/mt8188/mt8188-afe-pcm.c    |  34 ++++--
 sound/soc/mediatek/mt8188/mt8188-audsys-clk.c |  12 +-
 3 files changed, 113 insertions(+), 48 deletions(-)

-- 
2.43.0
Re: [PATCH 0/7] ASoC: mediatek: mt8188: Improve error handling
Posted by Mark Brown 1 day ago
On Mon, 07 Sep 2026 19:03:03 +0700, phucduc.bui@gmail.com wrote:
> ASoC: mediatek: mt8188: Improve error handling
> 
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Hi all,
> 
> This series improves error handling in several parts of the MT8188 AFE
> driver.
> Propagate errors from clock, regmap, and runtime resume operations,
> remove redundant probe error messages, and fix clock cleanup on
> registration failure.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/7] ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate clock initialization errors
      https://git.kernel.org/broonie/sound/c/691c4aac5ae5
[2/7] ASoC: mediatek: mt8188: mt8188-afe-clk: Handle tuner clock enable errors
      https://git.kernel.org/broonie/sound/c/a2c3ee3349a7
[3/7] ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate regmap update errors
      https://git.kernel.org/broonie/sound/c/60a8112a088a
[4/7] ASoC: mediatek: mt8188: mt8188-afe-clk: Handle clock enable errors
      https://git.kernel.org/broonie/sound/c/1b65c13d1af9
[5/7] ASoC: mediatek: mt8188: mt8188-afe-pcm: Handle runtime resume errors
      https://git.kernel.org/broonie/sound/c/f5f6941d9297
[6/7] ASoC: mediatek: mt8188: mt8188-afe-pcm: Drop redundant probe error messages
      https://git.kernel.org/broonie/sound/c/a79f2432ee89
[7/7] ASoC: mediatek: mt8188: fix clk leak on error in audsys_clk_register
      https://git.kernel.org/broonie/sound/c/6cddf6e56d25

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: [PATCH 0/7] ASoC: mediatek: mt8188: Improve error handling
Posted by AngeloGioacchino Del Regno 2 weeks, 2 days ago
On 9/7/26 14:03, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Hi all,
> 
> This series improves error handling in several parts of the MT8188 AFE
> driver.
> Propagate errors from clock, regmap, and runtime resume operations,
> remove redundant probe error messages, and fix clock cleanup on
> registration failure.
> 
> Compile-tested only.
> 
> Best regards,
> Phuc

Series is

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com
Re: [PATCH 0/7] ASoC: mediatek: mt8188: Improve error handling
Posted by Bui Duc Phuc 2 weeks, 1 day ago
Hi Cezary, AngeloGioacchino

Thanks to both of you for reviewing the series.

Best regards,
Phuc
Re: [PATCH 0/7] ASoC: mediatek: mt8188: Improve error handling
Posted by Cezary Rojewski 2 weeks, 3 days ago
On 9/7/2026 2:03 PM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Hi all,
> 
> This series improves error handling in several parts of the MT8188 AFE
> driver.
> Propagate errors from clock, regmap, and runtime resume operations,
> remove redundant probe error messages, and fix clock cleanup on
> registration failure.
> 
> Compile-tested only.
> 
> Best regards,
> Phuc
> 
> bui duc phuc (7):
>   ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate clock initialization
>     errors
>   ASoC: mediatek: mt8188: mt8188-afe-clk: Handle tuner clock enable
>     errors
>   ASoC: mediatek: mt8188: mt8188-afe-clk: Propagate regmap update errors
>   ASoC: mediatek: mt8188: mt8188-afe-clk: Handle clock enable errors
>   ASoC: mediatek: mt8188: mt8188-afe-pcm: Handle runtime resume errors
>   ASoC: mediatek: mt8188: mt8188-afe-pcm: Drop redundant probe error
>     messages
>   ASoC: mediatek: mt8188: fix clk leak on error in audsys_clk_register
> 
>  sound/soc/mediatek/mt8188/mt8188-afe-clk.c    | 115 +++++++++++++-----
>  sound/soc/mediatek/mt8188/mt8188-afe-pcm.c    |  34 ++++--
>  sound/soc/mediatek/mt8188/mt8188-audsys-clk.c |  12 +-
>  3 files changed, 113 insertions(+), 48 deletions(-)
> 

Yet another bunch of welcomed changes though at this point I'd expect
someone from Mediatek to participate and start testing the error paths.
Some permissiveness might have been intentional but we won't know until
someone from their dev team ACKs or NAKs.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>