iio: accel: adxl367: resolve interrupt mapping before device setup

[PATCH] iio: accel: adxl367: resolve interrupt mapping before device setup

Posted by Antoniu Miclaus 2 weeks, 4 days ago

adxl367_set_int_map_reg() uses fwnode_irq_get_byname(), which can return
-EPROBE_DEFER. Running it after adxl367_setup() made every deferred probe
repeat the reset and power the device up needlessly.

Move it ahead of the regulator enable and reset; the lookup only reads
firmware properties, so a deferral now returns before any hardware access.

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
 drivers/iio/accel/adxl367.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c
index 9b47e66c49ea..026db73057c5 100644
--- a/drivers/iio/accel/adxl367.c
+++ b/drivers/iio/accel/adxl367.c
@@ -1493,6 +1493,11 @@ int adxl367_probe(struct device *dev, const struct adxl367_ops *ops,
 	indio_dev->info = &adxl367_info;
 	indio_dev->modes = INDIO_DIRECT_MODE;
 
+	ret = adxl367_set_int_map_reg(st, irq);
+	if (ret < 0)
+		return dev_err_probe(st->dev, ret, "Failed to get interrupt\n");
+	irq = ret;
+
 	ret = devm_regulator_bulk_get_enable(st->dev,
 					     ARRAY_SIZE(regulator_names),
 					     regulator_names);
@@ -1520,11 +1525,6 @@ int adxl367_probe(struct device *dev, const struct adxl367_ops *ops,
 	if (ret)
 		return ret;
 
-	ret = adxl367_set_int_map_reg(st, irq);
-	if (ret < 0)
-		return dev_err_probe(st->dev, ret, "Failed to get interrupt\n");
-	irq = ret;
-
 	ret = devm_request_threaded_irq(st->dev, irq, NULL,
 					adxl367_irq_handler, IRQF_ONESHOT,
 					indio_dev->name, indio_dev);
-- 
2.43.0

Re: [PATCH] iio: accel: adxl367: resolve interrupt mapping before device setup

Posted by Joshua Crofts 2 weeks, 4 days ago

On Mon, 7 Sep 2026 11:23:13 +0300
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:

> adxl367_set_int_map_reg() uses fwnode_irq_get_byname(), which can return
> -EPROBE_DEFER. Running it after adxl367_setup() made every deferred probe
> repeat the reset and power the device up needlessly.
> 
> Move it ahead of the regulator enable and reset; the lookup only reads
> firmware properties, so a deferral now returns before any hardware access.
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards,
Joshua Crofts

Re: [PATCH] iio: accel: adxl367: resolve interrupt mapping before device setup

Posted by Jonathan Cameron 1 week, 5 days ago

On Mon, 7 Sep 2026 16:56:37 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Mon, 7 Sep 2026 11:23:13 +0300
> Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> 
> > adxl367_set_int_map_reg() uses fwnode_irq_get_byname(), which can return
> > -EPROBE_DEFER. Running it after adxl367_setup() made every deferred probe
> > repeat the reset and power the device up needlessly.
> > 
> > Move it ahead of the regulator enable and reset; the lookup only reads
> > firmware properties, so a deferral now returns before any hardware access.
> > 
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---  
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
> 

Sensible little optimization.
Applied,

J