1. Patchew
  2. linux
  3. View series

[PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings

Ratheesh Kannoth posted 1 patch 2 weeks, 4 days ago
There is a newer version of this series
drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Posted by Ratheesh Kannoth 2 weeks, 4 days ago 
From: Hariprasad Kelam <hkelam@marvell.com>

otx2_get_link_ksettings() already fills speed, duplex, autoneg, link
modes and FEC from CGX firmware data, but leaves cmd->base.port unset.
As a result, ethtool does not show the physical connector type even
though the firmware provides it in fwdata.port.

Populate cmd->base.port from rsp->fwdata.port so users can see values
such as PORT_TP or PORT_AUI via ethtool.

Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>

---
v1 -> v2: Addressed sashiko comments.
	https://lore.kernel.org/netdev/20260904154833.3b32ea6a@kernel.org/
---
 drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
index 9bee1b91eeaa..9b4c151b4d7d 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
@@ -1231,6 +1231,8 @@ static int otx2_get_link_ksettings(struct net_device *netdev,
 				OTX2_MODE_SUPPORTED, cmd);
 	otx2_get_fec_info(rsp->fwdata.supported_fec,
 			  OTX2_MODE_SUPPORTED, cmd);
+
+	cmd->base.port = (u8)rsp->fwdata.port;
 	return 0;
 }
 
-- 
2.43.0
Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Posted by Jakub Kicinski 2 weeks, 4 days ago 
On Mon, 7 Sep 2026 09:58:27 +0530 Ratheesh Kannoth wrote:
> otx2_get_link_ksettings() already fills speed, duplex, autoneg, link
> modes and FEC from CGX firmware data, but leaves cmd->base.port unset.
> As a result, ethtool does not show the physical connector type even
> though the firmware provides it in fwdata.port.
> 
> Populate cmd->base.port from rsp->fwdata.port so users can see values
> such as PORT_TP or PORT_AUI via ethtool.

I said:

  drivers should not blindly pass values between uAPI and the FW.

That means you have to add some explicit validation/translation
for each value even if they are numerically identical.
Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Posted by Ratheesh Kannoth 2 weeks, 3 days ago 
On 2026-09-08 at 03:10:38, Jakub Kicinski (kuba@kernel.org) wrote:
> On Mon, 7 Sep 2026 09:58:27 +0530 Ratheesh Kannoth wrote:
> > otx2_get_link_ksettings() already fills speed, duplex, autoneg, link
> > modes and FEC from CGX firmware data, but leaves cmd->base.port unset.
> > As a result, ethtool does not show the physical connector type even
> > though the firmware provides it in fwdata.port.
> >
> > Populate cmd->base.port from rsp->fwdata.port so users can see values
> > such as PORT_TP or PORT_AUI via ethtool.
>
> I said:
>
>   drivers should not blindly pass values between uAPI and the FW.
>
> That means you have to add some explicit validation/translation
> for each value even if they are numerically identical.

A field_get() would be OK to satisfy this translation ?

cmd->base.port = FIELD_GET(GENMASK(7, 0), rsp->fwdata.port);
Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Posted by Jakub Kicinski 2 weeks, 3 days ago 
On Tue, 8 Sep 2026 08:01:55 +0530 Ratheesh Kannoth wrote:
> > I said:
> >
> >   drivers should not blindly pass values between uAPI and the FW.
> >
> > That means you have to add some explicit validation/translation
> > for each value even if they are numerically identical.  
> 
> A field_get() would be OK to satisfy this translation ?
> 
> cmd->base.port = FIELD_GET(GENMASK(7, 0), rsp->fwdata.port);

switch (fw_value) {
	case X:
	case Y:
		return fw_value;
	default:
		return -EINVAL;
}
Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Posted by Leon Romanovsky 2 weeks, 4 days ago 
On Mon, Sep 07, 2026 at 09:58:27AM +0530, Ratheesh Kannoth wrote:
> From: Hariprasad Kelam <hkelam@marvell.com>
> 
> otx2_get_link_ksettings() already fills speed, duplex, autoneg, link
> modes and FEC from CGX firmware data, but leaves cmd->base.port unset.
> As a result, ethtool does not show the physical connector type even
> though the firmware provides it in fwdata.port.
> 
> Populate cmd->base.port from rsp->fwdata.port so users can see values
> such as PORT_TP or PORT_AUI via ethtool.
> 
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> 
> ---
> v1 -> v2: Addressed sashiko comments.
> 	https://lore.kernel.org/netdev/20260904154833.3b32ea6a@kernel.org/
> ---
>  drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> index 9bee1b91eeaa..9b4c151b4d7d 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> @@ -1231,6 +1231,8 @@ static int otx2_get_link_ksettings(struct net_device *netdev,
>  				OTX2_MODE_SUPPORTED, cmd);
>  	otx2_get_fec_info(rsp->fwdata.supported_fec,
>  			  OTX2_MODE_SUPPORTED, cmd);
> +
> +	cmd->base.port = (u8)rsp->fwdata.port;

You should declare identical fields with the same type and avoid silently
casting variables.

Thanks

>  	return 0;
>  }
>  
> -- 
> 2.43.0
> 
>
Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Posted by Ratheesh Kannoth 2 weeks, 4 days ago 
On 2026-09-07 at 12:53:15, Leon Romanovsky (leon@kernel.org) wrote:
> On Mon, Sep 07, 2026 at 09:58:27AM +0530, Ratheesh Kannoth wrote:
> > From: Hariprasad Kelam <hkelam@marvell.com>
> >
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> > @@ -1231,6 +1231,8 @@ static int otx2_get_link_ksettings(struct net_device *netdev,
> >  				OTX2_MODE_SUPPORTED, cmd);
> >  	otx2_get_fec_info(rsp->fwdata.supported_fec,
> >  			  OTX2_MODE_SUPPORTED, cmd);
> > +
> > +	cmd->base.port = (u8)rsp->fwdata.port;
>
> You should declare identical fields with the same type and avoid silently
> casting variables.
>
> Thanks
You are suggesting to split rsp->fwdata.port to  u8 port + 7-byte pad ?
Currently FW is writing as 64bit.

>
> >  	return 0;
> >  }
> >
> > --
> > 2.43.0
> >
> >
Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Posted by Leon Romanovsky 2 weeks, 4 days ago 
On Mon, Sep 07, 2026 at 04:31:45PM +0530, Ratheesh Kannoth wrote:
> On 2026-09-07 at 12:53:15, Leon Romanovsky (leon@kernel.org) wrote:
> > On Mon, Sep 07, 2026 at 09:58:27AM +0530, Ratheesh Kannoth wrote:
> > > From: Hariprasad Kelam <hkelam@marvell.com>
> > >
> > > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c
> > > @@ -1231,6 +1231,8 @@ static int otx2_get_link_ksettings(struct net_device *netdev,
> > >  				OTX2_MODE_SUPPORTED, cmd);
> > >  	otx2_get_fec_info(rsp->fwdata.supported_fec,
> > >  			  OTX2_MODE_SUPPORTED, cmd);
> > > +
> > > +	cmd->base.port = (u8)rsp->fwdata.port;
> >
> > You should declare identical fields with the same type and avoid silently
> > casting variables.
> >
> > Thanks
> You are suggesting to split rsp->fwdata.port to  u8 port + 7-byte pad ?

pad or reserved, something like that.

Thanks

> Currently FW is writing as 64bit.
> 
> >
> > >  	return 0;
> > >  }
> > >
> > > --
> > > 2.43.0
> > >
> > >

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.