[PATCH v9 0/2] Add initial dual front camera and rear flash support for Pixel 3 / 3 XL

David Heidelberg via B4 Relay posted 2 patches 2 weeks, 4 days ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 199 ++++++++++++++++++++-
1 file changed, 198 insertions(+), 1 deletion(-)
[PATCH v9 0/2] Add initial dual front camera and rear flash support for Pixel 3 / 3 XL
Posted by David Heidelberg via B4 Relay 2 weeks, 4 days ago
Describe the dual front-facing IMX355 sensors (standard and wide)
and enable the PMI8998 flash LED with hardware-accurate limits.

This brings up the basic camera topology and flash support in DT.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v9:
- Dependency merged, no longer depends on anything.
- Link to v8: https://patch.msgid.link/20260901-pixel3-camera-v8-0-99f159883348@ixit.cz

Changes in v8:
- Fix ordering of includes. (Konrad)
- Link to v7: https://lore.kernel.org/r/20260721-pixel3-camera-v7-0-82d323c6c5d2@ixit.cz

Changes in v7:
- Depend on the
  https://lore.kernel.org/all/20260628-kbingham-orientation-v3-0-4ed92968aff8@ideasonboard.com/
  (Konrad)
- Sort the renamed regulators. Why Mr. Anderson, why. (Konrad)
- Link to v6: https://lore.kernel.org/r/20260720-pixel3-camera-v6-0-afe419bef476@ixit.cz

Changes in v6:
- Remove forgotten bias-pull-down property from cci0_sleep node.
  (dtbs_check)
- ..-regulator -> regulator-.. (Konrad)
- Rename camera -pin to -state and remove _pin from the labes. (Konrad,
  dtbs_check)
- Link to v5: https://lore.kernel.org/r/20260719-pixel3-camera-v5-0-99593f1bd8ec@ixit.cz

Changes in v5:
- Added function-enumarator to flash LEDs. (Sashiko)
- Dropped l22a regulator needed only for NFOV actuator. (Sashiko)
- Dropped vdda-csi[0-2]-supply, as it was unused. (Sashiko).
- Added previously omited cam_mclk2_sleep sleep state.
- Link to v4: https://lore.kernel.org/r/20260719-pixel3-camera-v4-0-48cab1236852@ixit.cz

Changes in v4:
- Use 24 MHz ext clock for the cameras, as the downstream does, since
  the upstream driver can now support it.
- Added additional LED, as the phone contains two separately controlled
  white LEDs flash (upper and bottom, in one module).
- Increase flash-max-microamp, as I took wrong "flash" from the
  downstream sources and dropped Dmitry R-b.
- Address formatting issues. (Konrad)
- Link to v3: https://lore.kernel.org/r/20260412-pixel3-camera-v3-0-e26b090a6110@ixit.cz

Changes in v3:
- Dropped cam_vio label. (Dmitry)
- Move the MCLK2 pinctrl from cameras to common camss. (Dmitry)
- Link to v2: https://lore.kernel.org/r/20260411-pixel3-camera-v2-0-41b889abb14c@ixit.cz

Changes in v2:
- leds.h include escaped the initial submission. Fixed.
- Link to v1: https://lore.kernel.org/r/20260411-pixel3-camera-v1-0-2757606515b6@ixit.cz

---
David Heidelberg (2):
      arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras
      arm64: dts: qcom: sdm845-google: Enable PMI8998 camera flash LEDs

 arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 199 ++++++++++++++++++++-
 1 file changed, 198 insertions(+), 1 deletion(-)
---
base-commit: 944a035ecca915ae947905dcfb03f2b9dc6d032c
change-id: 20260315-pixel3-camera-a9989bf589ee

Best regards,
--  
David Heidelberg <david@ixit.cz>
Re: [PATCH v9 0/2] Add initial dual front camera and rear flash support for Pixel 3 / 3 XL
Posted by Bjorn Andersson 1 week, 1 day ago
On Mon, Sep 07, 2026 at 05:58:08PM +0200, David Heidelberg via B4 Relay wrote:
> Describe the dual front-facing IMX355 sensors (standard and wide)
> and enable the PMI8998 flash LED with hardware-accurate limits.
> 
> This brings up the basic camera topology and flash support in DT.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Changes in v9:
> - Dependency merged, no longer depends on anything.

Do you know if there's a immutable branch containing
dt-bindings/media/video-interface-devices.h somewhere, because this is
still an unmet dependency in my tree.

Regards,
Bjorn

> - Link to v8: https://patch.msgid.link/20260901-pixel3-camera-v8-0-99f159883348@ixit.cz
> 
> Changes in v8:
> - Fix ordering of includes. (Konrad)
> - Link to v7: https://lore.kernel.org/r/20260721-pixel3-camera-v7-0-82d323c6c5d2@ixit.cz
> 
> Changes in v7:
> - Depend on the
>   https://lore.kernel.org/all/20260628-kbingham-orientation-v3-0-4ed92968aff8@ideasonboard.com/
>   (Konrad)
> - Sort the renamed regulators. Why Mr. Anderson, why. (Konrad)
> - Link to v6: https://lore.kernel.org/r/20260720-pixel3-camera-v6-0-afe419bef476@ixit.cz
> 
> Changes in v6:
> - Remove forgotten bias-pull-down property from cci0_sleep node.
>   (dtbs_check)
> - ..-regulator -> regulator-.. (Konrad)
> - Rename camera -pin to -state and remove _pin from the labes. (Konrad,
>   dtbs_check)
> - Link to v5: https://lore.kernel.org/r/20260719-pixel3-camera-v5-0-99593f1bd8ec@ixit.cz
> 
> Changes in v5:
> - Added function-enumarator to flash LEDs. (Sashiko)
> - Dropped l22a regulator needed only for NFOV actuator. (Sashiko)
> - Dropped vdda-csi[0-2]-supply, as it was unused. (Sashiko).
> - Added previously omited cam_mclk2_sleep sleep state.
> - Link to v4: https://lore.kernel.org/r/20260719-pixel3-camera-v4-0-48cab1236852@ixit.cz
> 
> Changes in v4:
> - Use 24 MHz ext clock for the cameras, as the downstream does, since
>   the upstream driver can now support it.
> - Added additional LED, as the phone contains two separately controlled
>   white LEDs flash (upper and bottom, in one module).
> - Increase flash-max-microamp, as I took wrong "flash" from the
>   downstream sources and dropped Dmitry R-b.
> - Address formatting issues. (Konrad)
> - Link to v3: https://lore.kernel.org/r/20260412-pixel3-camera-v3-0-e26b090a6110@ixit.cz
> 
> Changes in v3:
> - Dropped cam_vio label. (Dmitry)
> - Move the MCLK2 pinctrl from cameras to common camss. (Dmitry)
> - Link to v2: https://lore.kernel.org/r/20260411-pixel3-camera-v2-0-41b889abb14c@ixit.cz
> 
> Changes in v2:
> - leds.h include escaped the initial submission. Fixed.
> - Link to v1: https://lore.kernel.org/r/20260411-pixel3-camera-v1-0-2757606515b6@ixit.cz
> 
> ---
> David Heidelberg (2):
>       arm64: dts: qcom: sdm845-google: Add dual front IMX355 cameras
>       arm64: dts: qcom: sdm845-google: Enable PMI8998 camera flash LEDs
> 
>  arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 199 ++++++++++++++++++++-
>  1 file changed, 198 insertions(+), 1 deletion(-)
> ---
> base-commit: 944a035ecca915ae947905dcfb03f2b9dc6d032c
> change-id: 20260315-pixel3-camera-a9989bf589ee
> 
> Best regards,
> --  
> David Heidelberg <david@ixit.cz>
> 
>