[v1] staging: media: atomisp: Use C99 initializers for ACPI IDs

[PATCH] staging: media: atomisp: Use C99 initializers for ACPI IDs

Posted by Lalit Shankar Chowdhury 2 weeks, 6 days ago

Use designated initializers for the ACPI ID tables.

Signed-off-by: Lalit Shankar Chowdhury <lalitshankarch@gmail.com>
---
 drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 ++--
 drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
index f9cc5f45fe00..588f2f90a884 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-gc2235.c
@@ -857,8 +857,8 @@ static int gc2235_probe(struct i2c_client *client)
 }
 
 static const struct acpi_device_id gc2235_acpi_match[] = {
-	{ "INT33F8" },
-	{},
+	{ .id = "INT33F8" },
+	{ },
 };
 MODULE_DEVICE_TABLE(acpi, gc2235_acpi_match);
 
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
index 2c41c496daa6..b02fe0c915ab 100644
--- a/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
+++ b/drivers/staging/media/atomisp/i2c/atomisp-ov2722.c
@@ -995,8 +995,8 @@ static int ov2722_probe(struct i2c_client *client)
 }
 
 static const struct acpi_device_id ov2722_acpi_match[] = {
-	{ "INT33FB" },
-	{},
+	{ .id = "INT33FB" },
+	{ },
 };
 MODULE_DEVICE_TABLE(acpi, ov2722_acpi_match);
 
-- 
2.53.0

Re: [PATCH] staging: media: atomisp: Use C99 initializers for ACPI IDs

Posted by Andy Shevchenko 2 weeks, 5 days ago

On Sun, Sep 6, 2026 at 3:53 AM Lalit Shankar Chowdhury
<lalitshankarch@gmail.com> wrote:
>
> Use designated initializers for the ACPI ID tables.

...

>  static const struct acpi_device_id gc2235_acpi_match[] = {
> -       { "INT33F8" },
> -       {},
> +       { .id = "INT33F8" },
> +       { },

Follow the agreed style for the terminator entry. See Uwe's patches as
an example.

>  };

...

>  static const struct acpi_device_id ov2722_acpi_match[] = {
> -       { "INT33FB" },
> -       {},
> +       { .id = "INT33FB" },
> +       { },

Ditto.

>  };

-- 
With Best Regards,
Andy Shevchenko