[v1] staging: rtl8723bs: replace msleep with usleep_range in rtw_pwrctrl.c

[PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_pwrctrl.c

Posted by Muhammad Israr 2 weeks, 6 days ago

The checkpatch tool flags msleep() calls for durations less than 20ms
because they can sleep for much longer due to timer granularity. Use
usleep_range() for the 1ms delay to provide a flexible sleep window
and avoid inaccurate task scheduling.

Signed-off-by: Muhammad Israr <7israr.work@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index 448611ad8..5ef44a3ae 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -410,7 +410,7 @@ int LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
 		if (jiffies_to_msecs(jiffies - start_time) > delay_ms)
 			return -ETIMEDOUT;
 
-		msleep(1);
+		usleep_range(1000, 2000);
 	}
 }
 
@@ -561,7 +561,7 @@ void LPS_Leave_check(struct adapter *padapter)
 		if (jiffies_to_msecs(jiffies - start_time) > 100)
 			break;
 
-		msleep(1);
+		usleep_range(1000, 2000);
 	}
 }
 
-- 
2.43.0

Re: [PATCH] staging: rtl8723bs: replace msleep with usleep_range in rtw_pwrctrl.c

Posted by Greg KH 2 weeks, 4 days ago

On Sat, Sep 05, 2026 at 10:26:13AM +0500, Muhammad Israr wrote:
> The checkpatch tool flags msleep() calls for durations less than 20ms
> because they can sleep for much longer due to timer granularity. Use
> usleep_range() for the 1ms delay to provide a flexible sleep window
> and avoid inaccurate task scheduling.
> 
> Signed-off-by: Muhammad Israr <7israr.work@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Please see the mailing list archives for why this patch keeps getting
rejected.

thanks,

greg k-h