[PATCH v2] staging: rtl8723bs: remove dead code in sta_info.h

Tomasz Unger posted 1 patch 2 weeks, 6 days ago
drivers/staging/rtl8723bs/include/sta_info.h | 1 -
1 file changed, 1 deletion(-)
[PATCH v2] staging: rtl8723bs: remove dead code in sta_info.h
Posted by Tomasz Unger 2 weeks, 6 days ago
Remove a commented-out unsigned char ampdu_txen_bitmap declaration
left over as dead code in struct sta_info.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Dan Carpenter reviewed the previous "space before tab" comment fix
for sta_info.h and suggested going further: deleting the dead
commented-out ampdu_txen_bitmap declaration outright instead of just
reformatting it.

This v2 addresses that directly.
---
Changes in v2 (per Dan Carpenter's review):
- Instead of just fixing the stray space before a tab in the comment,
  remove the commented-out ampdu_txen_bitmap declaration entirely,
  since it is dead code ("Delete dead code").
- Add an Assisted-by: trailer disclosing AI assistance, per
  Documentation/process/coding-assistants.rst (the original v1 had no
  such disclosure).

Verified with checkpatch.pl - no new warnings introduced by this change
(and removes a pre-existing "space before tabs" warning on the deleted line).

Assisted-by: Claude:claude-sonnet-5
---
 drivers/staging/rtl8723bs/include/sta_info.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/include/sta_info.h b/drivers/staging/rtl8723bs/include/sta_info.h
index 0f53e77c110c..fd831abdd172 100644
--- a/drivers/staging/rtl8723bs/include/sta_info.h
+++ b/drivers/staging/rtl8723bs/include/sta_info.h
@@ -122,7 +122,6 @@ struct sta_info {
 	struct recv_reorder_ctrl recvreorder_ctrl[16];
 
 	/* for A-MPDU Tx */
-	/* unsigned char 	ampdu_txen_bitmap; */
 	u16 BA_starting_seqctrl[16];
 
 

---
base-commit: c6eb4dc5964fdf4086b73b7f0f5dc0d595fb5cf3
change-id: 20260905-rtl8723bs-sta-info-dead-code-v2-3c623b7ac3e0

Best regards,
--  
Tomasz Unger <tomasz.unger@yahoo.pl>