1. Patchew
  2. linux
  3. View series

[PATCH] rust: num: seal Integer

Younes Akhouayri via B4 Relay posted 1 patch 2 weeks, 6 days ago
There is a newer version of this series
rust/kernel/num.rs | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
[PATCH] rust: num: seal Integer
Posted by Younes Akhouayri via B4 Relay 2 weeks, 6 days ago 
From: Younes Akhouayri <git@younes.io>

Bounded relies on Integer implementations to describe primitive integer
semantics correctly. In particular, it uses Integer::BITS and Signedness
to justify unchecked operations.

Integer is currently safe and externally implementable, so an
implementation can violate those assumptions and make safe Bounded
operations reach undefined behavior.

Seal Integer so only the primitive implementations provided by the
kernel crate can satisfy it.

Fixes: 01e345e82ec3 ("rust: num: add Bounded integer wrapping type")
Closes: https://lore.kernel.org/rust-for-linux/CANiq72mOfR33s4y+Ueivd5NrC5yre+Pcp57ZOBz0msw9A4AP1Q@mail.gmail.com/
Cc: stable@vger.kernel.org
Suggested-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Younes Akhouayri <git@younes.io>
---
 rust/kernel/num.rs | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/rust/kernel/num.rs b/rust/kernel/num.rs
index dbe848e30efe..de589792a77a 100644
--- a/rust/kernel/num.rs
+++ b/rust/kernel/num.rs
@@ -15,9 +15,14 @@ pub enum Unsigned {}
 /// Designates signed primitive types.
 pub enum Signed {}
 
+mod private {
+    pub trait Sealed {}
+}
+
 /// Describes core properties of integer types.
 pub trait Integer:
-    Sized
+    private::Sealed
+    + Sized
     + Copy
     + Clone
     + PartialEq
@@ -56,6 +61,8 @@ pub trait Integer:
 macro_rules! impl_integer {
     ($($type:ty: $signedness:ty), *) => {
         $(
+        impl private::Sealed for $type {}
+
         impl Integer for $type {
             type Signedness = $signedness;
 

---
base-commit: e510334fbaeaa016ac76d80b4c5f47611c5f7860
change-id: 20260903-feature-rust-num-seal-integer-a4262df429c6

Best regards,
--  
Younes Akhouayri <git@younes.io>
Re: [PATCH] rust: num: seal Integer
Posted by Gary Guo 2 weeks, 6 days ago 
On Sat Sep 5, 2026 at 3:17 AM BST, Younes Akhouayri via B4 Relay wrote:
> From: Younes Akhouayri <git@younes.io>
>
> Bounded relies on Integer implementations to describe primitive integer
> semantics correctly. In particular, it uses Integer::BITS and Signedness
> to justify unchecked operations.
>
> Integer is currently safe and externally implementable, so an
> implementation can violate those assumptions and make safe Bounded
> operations reach undefined behavior.
>
> Seal Integer so only the primitive implementations provided by the
> kernel crate can satisfy it.
>
> Fixes: 01e345e82ec3 ("rust: num: add Bounded integer wrapping type")
> Closes: https://lore.kernel.org/rust-for-linux/CANiq72mOfR33s4y+Ueivd5NrC5yre+Pcp57ZOBz0msw9A4AP1Q@mail.gmail.com/
> Cc: stable@vger.kernel.org
> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
> Signed-off-by: Younes Akhouayri <git@younes.io>
> ---
>  rust/kernel/num.rs | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/num.rs b/rust/kernel/num.rs
> index dbe848e30efe..de589792a77a 100644
> --- a/rust/kernel/num.rs
> +++ b/rust/kernel/num.rs
> @@ -15,9 +15,14 @@ pub enum Unsigned {}
>  /// Designates signed primitive types.
>  pub enum Signed {}
>  
> +mod private {
> +    pub trait Sealed {}
> +}

I feel that it's time to add an attribute macro for sealing.

Yes, more macros :)

Best,
Gary

> +
>  /// Describes core properties of integer types.
>  pub trait Integer:
> -    Sized
> +    private::Sealed
> +    + Sized
>      + Copy
>      + Clone
>      + PartialEq
> @@ -56,6 +61,8 @@ pub trait Integer:
>  macro_rules! impl_integer {
>      ($($type:ty: $signedness:ty), *) => {
>          $(
> +        impl private::Sealed for $type {}
> +
>          impl Integer for $type {
>              type Signedness = $signedness;
>  
>
> ---
> base-commit: e510334fbaeaa016ac76d80b4c5f47611c5f7860
> change-id: 20260903-feature-rust-num-seal-integer-a4262df429c6
>
> Best regards,
> --  
> Younes Akhouayri <git@younes.io>
Re: [PATCH] rust: num: seal Integer
Posted by Alexandre Courbot 2 weeks, 6 days ago 
On Sat Sep 5, 2026 at 11:22 PM JST, Gary Guo wrote:
> On Sat Sep 5, 2026 at 3:17 AM BST, Younes Akhouayri via B4 Relay wrote:
>> From: Younes Akhouayri <git@younes.io>
>>
>> Bounded relies on Integer implementations to describe primitive integer
>> semantics correctly. In particular, it uses Integer::BITS and Signedness
>> to justify unchecked operations.
>>
>> Integer is currently safe and externally implementable, so an
>> implementation can violate those assumptions and make safe Bounded
>> operations reach undefined behavior.
>>
>> Seal Integer so only the primitive implementations provided by the
>> kernel crate can satisfy it.
>>
>> Fixes: 01e345e82ec3 ("rust: num: add Bounded integer wrapping type")
>> Closes: https://lore.kernel.org/rust-for-linux/CANiq72mOfR33s4y+Ueivd5NrC5yre+Pcp57ZOBz0msw9A4AP1Q@mail.gmail.com/
>> Cc: stable@vger.kernel.org
>> Suggested-by: Miguel Ojeda <ojeda@kernel.org>
>> Signed-off-by: Younes Akhouayri <git@younes.io>
>> ---
>>  rust/kernel/num.rs | 9 ++++++++-
>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/rust/kernel/num.rs b/rust/kernel/num.rs
>> index dbe848e30efe..de589792a77a 100644
>> --- a/rust/kernel/num.rs
>> +++ b/rust/kernel/num.rs
>> @@ -15,9 +15,14 @@ pub enum Unsigned {}
>>  /// Designates signed primitive types.
>>  pub enum Signed {}
>>  
>> +mod private {
>> +    pub trait Sealed {}
>> +}
>
> I feel that it's time to add an attribute macro for sealing.

+1, this is going to be a really common pattern.
Re: [PATCH] rust: num: seal Integer
Posted by Miguel Ojeda 2 weeks, 6 days ago 
On Sat, Sep 5, 2026 at 4:17 AM Younes Akhouayri via B4 Relay
<devnull+git.younes.io@kernel.org> wrote:
>
> Integer is currently safe and externally implementable, so an
> implementation can violate those assumptions and make safe Bounded
> operations reach undefined behavior.

Ideally, we would give a brief indication of how that can happen (like
saying "e.g. by writing ...") or sometimes even with an example if it
is short enough :)

> Fixes: 01e345e82ec3 ("rust: num: add Bounded integer wrapping type")
> Closes: https://lore.kernel.org/rust-for-linux/CANiq72mOfR33s4y+Ueivd5NrC5yre+Pcp57ZOBz0msw9A4AP1Q@mail.gmail.com/

Reported-by: usually precedes the Closes tag, e.g.

  Reported-by: Miguel Ojeda <ojeda@kernel.org>
  Closes: https://lore.kernel.org/rust-for-linux/CANiq72mOfR33s4y+Ueivd5NrC5yre+Pcp57ZOBz0msw9A4AP1Q@mail.gmail.com/

(But it is fine, i.e. no need to send a new version just for that)

Thanks for doing this! If Alexandre is happy with it, I will take it.

Cheers,
Miguel

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.