perf test: Avoid call to missing cleanup function

[PATCH v1] perf test: Avoid call to missing cleanup function

Posted by Ian Rogers 3 weeks, 1 day ago

Cleanup function was removed by writing to /dev/null rather than
temporary files. The exit path still had a call.

Fixes: 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/tests/shell/test_event_open_fallback.sh b/tools/perf/tests/shell/test_event_open_fallback.sh
index 9420a7557c13..27d440a5355d 100755
--- a/tools/perf/tests/shell/test_event_open_fallback.sh
+++ b/tools/perf/tests/shell/test_event_open_fallback.sh
@@ -57,8 +57,6 @@ ret=0
 test_decrease_precise_ip		|| ret=$? ; count_result $ret ; ret=0
 test_decrease_precise_ip_complicated	|| ret=$? ; count_result $ret ; ret=0
 
-cleanup
-
 if [ ${err_cnt} -gt 0 ] ; then
 	exit 1
 fi
-- 
2.55.0.979.g7e5102b832-goog

Re: [PATCH v1] perf test: Avoid call to missing cleanup function

Posted by Mi, Dapeng 2 weeks, 5 days ago

LGTM. Thanks.

Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>

On 9/5/2026 3:49 AM, Ian Rogers wrote:
> Cleanup function was removed by writing to /dev/null rather than
> temporary files. The exit path still had a call.
>
> Fixes: 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
>  tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/tests/shell/test_event_open_fallback.sh b/tools/perf/tests/shell/test_event_open_fallback.sh
> index 9420a7557c13..27d440a5355d 100755
> --- a/tools/perf/tests/shell/test_event_open_fallback.sh
> +++ b/tools/perf/tests/shell/test_event_open_fallback.sh
> @@ -57,8 +57,6 @@ ret=0
>  test_decrease_precise_ip		|| ret=$? ; count_result $ret ; ret=0
>  test_decrease_precise_ip_complicated	|| ret=$? ; count_result $ret ; ret=0
>  
> -cleanup
> -
>  if [ ${err_cnt} -gt 0 ] ; then
>  	exit 1
>  fi

Re: [PATCH v1] perf test: Avoid call to missing cleanup function

Posted by Arnaldo Carvalho de Melo 2 weeks, 4 days ago

On Mon, Sep 07, 2026 at 02:47:17PM +0800, Mi, Dapeng wrote:
> LGTM. Thanks.
> 
> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>

Thanks, applied to perf-tools-next, for v7.4.

- Arnaldo
 
> On 9/5/2026 3:49 AM, Ian Rogers wrote:
> > Cleanup function was removed by writing to /dev/null rather than
> > temporary files. The exit path still had a call.
> >
> > Fixes: 44f6b4402791 ("perf test: Fix hybrid testing of event fallback test")
> > Signed-off-by: Ian Rogers <irogers@google.com>
> > ---
> >  tools/perf/tests/shell/test_event_open_fallback.sh | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/tools/perf/tests/shell/test_event_open_fallback.sh b/tools/perf/tests/shell/test_event_open_fallback.sh
> > index 9420a7557c13..27d440a5355d 100755
> > --- a/tools/perf/tests/shell/test_event_open_fallback.sh
> > +++ b/tools/perf/tests/shell/test_event_open_fallback.sh
> > @@ -57,8 +57,6 @@ ret=0
> >  test_decrease_precise_ip		|| ret=$? ; count_result $ret ; ret=0
> >  test_decrease_precise_ip_complicated	|| ret=$? ; count_result $ret ; ret=0
> >  
> > -cleanup
> > -
> >  if [ ${err_cnt} -gt 0 ] ; then
> >  	exit 1
> >  fi