[v1] dm vdo: Fix spelling mistake "postive" -> "positive"

[PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"

Posted by Colin Ian King 3 weeks, 1 day ago

There is another spelling mistake in a vdo_log_error message that
I somehow overlooked last time. Fix it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/md/dm-vdo/dm-vdo-target.c b/drivers/md/dm-vdo/dm-vdo-target.c
index 1d8375cc3c3e..043549b1fc2e 100644
--- a/drivers/md/dm-vdo/dm-vdo-target.c
+++ b/drivers/md/dm-vdo/dm-vdo-target.c
@@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char *slab_str, block_count_t *sla
 
 	result = kstrtoull(slab_str, 10, &value);
 	if (result) {
-		vdo_log_error("optional parameter error: invalid slab size, must be a postive integer");
+		vdo_log_error("optional parameter error: invalid slab size, must be a positive integer");
 		return -EINVAL;
 	}
 
-- 
2.55.0

Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"

Posted by Matthew Sakai 3 weeks, 1 day ago

I had to look at this for quite a while to figure out what was going on.
We made the same spelling error twice in the same function and somehow 
only noticed the first one previously? Anyway,

Reviewed-by: Matthew Sakai <msakai@redhat.com>

On 9/3/26 11:23 AM, Colin Ian King wrote:
> There is another spelling mistake in a vdo_log_error message that
> I somehow overlooked last time. Fix it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/dm-vdo/dm-vdo-target.c b/drivers/md/dm-vdo/dm-vdo-target.c
> index 1d8375cc3c3e..043549b1fc2e 100644
> --- a/drivers/md/dm-vdo/dm-vdo-target.c
> +++ b/drivers/md/dm-vdo/dm-vdo-target.c
> @@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char *slab_str, block_count_t *sla
>   
>   	result = kstrtoull(slab_str, 10, &value);
>   	if (result) {
> -		vdo_log_error("optional parameter error: invalid slab size, must be a postive integer");
> +		vdo_log_error("optional parameter error: invalid slab size, must be a positive integer");
>   		return -EINVAL;
>   	}
>

Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"

Posted by Robert P. J. Day 3 weeks, 1 day ago

On Thu, 3 Sep 2026, Matthew Sakai wrote:

> I had to look at this for quite a while to figure out what was going on.
> We made the same spelling error twice in the same function and somehow only
> noticed the first one previously? Anyway,
>
> Reviewed-by: Matthew Sakai <msakai@redhat.com>
>
> On 9/3/26 11:23 AM, Colin Ian King wrote:
> > There is another spelling mistake in a vdo_log_error message that
> > I somehow overlooked last time. Fix it.
> >
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> >   drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/dm-vdo/dm-vdo-target.c
> > b/drivers/md/dm-vdo/dm-vdo-target.c
> > index 1d8375cc3c3e..043549b1fc2e 100644
> > --- a/drivers/md/dm-vdo/dm-vdo-target.c
> > +++ b/drivers/md/dm-vdo/dm-vdo-target.c
> > @@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char
> > *slab_str, block_count_t *sla
> >     	result = kstrtoull(slab_str, 10, &value);
> >   	if (result) {
> > -		vdo_log_error("optional parameter error: invalid slab size,
> > must be a postive integer");
> > +		vdo_log_error("optional parameter error: invalid slab size,
> > must be a positive integer");
> >   		return -EINVAL;
> >   	}

  My rule from years back was ... you find one typo, you "grep -rw"
the entire kernel tree.

rday

Re: [PATCH][next] dm vdo: Fix spelling mistake "postive" -> "positive"

Posted by Colin King (gmail) 3 weeks, 1 day ago

On 03/09/2026 20:25, Robert P. J. Day wrote:
> On Thu, 3 Sep 2026, Matthew Sakai wrote:
> 
>> I had to look at this for quite a while to figure out what was going on.
>> We made the same spelling error twice in the same function and somehow only
>> noticed the first one previously? Anyway,
>>
>> Reviewed-by: Matthew Sakai <msakai@redhat.com>
>>
>> On 9/3/26 11:23 AM, Colin Ian King wrote:
>>> There is another spelling mistake in a vdo_log_error message that
>>> I somehow overlooked last time. Fix it.
>>>
>>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>>> ---
>>>    drivers/md/dm-vdo/dm-vdo-target.c | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/md/dm-vdo/dm-vdo-target.c
>>> b/drivers/md/dm-vdo/dm-vdo-target.c
>>> index 1d8375cc3c3e..043549b1fc2e 100644
>>> --- a/drivers/md/dm-vdo/dm-vdo-target.c
>>> +++ b/drivers/md/dm-vdo/dm-vdo-target.c
>>> @@ -443,7 +443,7 @@ static int __must_check parse_slab_size(const char
>>> *slab_str, block_count_t *sla
>>>      	result = kstrtoull(slab_str, 10, &value);
>>>    	if (result) {
>>> -		vdo_log_error("optional parameter error: invalid slab size,
>>> must be a postive integer");
>>> +		vdo_log_error("optional parameter error: invalid slab size,
>>> must be a positive integer");
>>>    		return -EINVAL;
>>>    	}
> 
>    My rule from years back was ... you find one typo, you "grep -rw"
> the entire kernel tree.

Yup, normally do, somehow this slipped through :-(

> 
> rday