[v1] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure"

[PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure"

Posted by Colin Ian King 3 weeks, 1 day ago

There is a spelling mistake in an assert message. Fix it.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 tools/testing/selftests/bpf/prog_tests/xsk.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/xsk.c b/tools/testing/selftests/bpf/prog_tests/xsk.c
index 6e2f63ee2a6c..772f3dd7ce64 100644
--- a/tools/testing/selftests/bpf/prog_tests/xsk.c
+++ b/tools/testing/selftests/bpf/prog_tests/xsk.c
@@ -75,7 +75,7 @@ static void test_xsk(const struct test_spec *test_to_run, enum test_mode mode)
 	if (!ASSERT_OK_PTR(ifobj_rx, "create ifobj_rx"))
 		goto delete_tx;
 
-	if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "conigure ifobj"))
+	if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "configure ifobj"))
 		goto delete_rx;
 
 	ret = get_hw_ring_size(ifobj_tx->ifname, &ifobj_tx->ring);
-- 
2.55.0

Re: [PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure"

Posted by Emil Tsalapatis 2 weeks, 3 days ago

On Thu, Sep 3, 2026 at 11:05 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> There is a spelling mistake in an assert message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/xsk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/xsk.c b/tools/testing/selftests/bpf/prog_tests/xsk.c
> index 6e2f63ee2a6c..772f3dd7ce64 100644
> --- a/tools/testing/selftests/bpf/prog_tests/xsk.c
> +++ b/tools/testing/selftests/bpf/prog_tests/xsk.c
> @@ -75,7 +75,7 @@ static void test_xsk(const struct test_spec *test_to_run, enum test_mode mode)
>         if (!ASSERT_OK_PTR(ifobj_rx, "create ifobj_rx"))
>                 goto delete_tx;
>
> -       if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "conigure ifobj"))
> +       if (!ASSERT_OK(configure_ifobj(ifobj_tx, ifobj_rx), "configure ifobj"))
>                 goto delete_rx;
>
>         ret = get_hw_ring_size(ifobj_tx->ifname, &ifobj_tx->ring);
> --
> 2.55.0
>

Re: [PATCH][next] selftests/bpf: test_xsk: Fix spelling mistake "conigure" -> "configure"

Posted by Bastien Curutchet 3 weeks ago

Hi,

I think your mail subject should have started with [PATCH bpf-next] (cf
https://elixir.bootlin.com/linux/v7.2.2/source/Documentation/bpf/bpf_devel_QA.rst#L157-L166)

Also other commits to this file start with selftests/xsk, but that's a 
nit pick.


On 9/3/26 5:03 PM, Colin Ian King wrote:
> There is a spelling mistake in an assert message. Fix it.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Bastien Curutchet <bastien.curutchet@bootlin.com>


Regards,
Bastien