tools/perf/builtin-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The output_name variable is only used within builtin-sched.c for the
stats subcommand, so declare it static. This fixes a sparse warning:
builtin-sched.c:4140:12: warning: symbol 'output_name' was not
declared. Should it be static?
Signed-off-by: nanshuaibo <nanshuaibo811@163.com>
---
tools/perf/builtin-sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index dd39a4fb..22486df2 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -4137,7 +4137,7 @@ static int disable_sched_schedstat(void)
}
/* perf.data or any other output file name used by stats subcommand (only). */
-const char *output_name;
+static const char *output_name;
static int perf_sched__schedstat_record(struct perf_sched *sched,
int argc, const char **argv)
--
2.43.0
On Thu, Sep 3, 2026 at 4:28 AM nanshuaibo <nanshuaibo811@163.com> wrote: > > The output_name variable is only used within builtin-sched.c for the > stats subcommand, so declare it static. This fixes a sparse warning: > > builtin-sched.c:4140:12: warning: symbol 'output_name' was not > declared. Should it be static? > > Signed-off-by: nanshuaibo <nanshuaibo811@163.com> Reviewed-by: Ian Rogers <irogers@google.com> Thanks! Ian > --- > tools/perf/builtin-sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c > index dd39a4fb..22486df2 100644 > --- a/tools/perf/builtin-sched.c > +++ b/tools/perf/builtin-sched.c > @@ -4137,7 +4137,7 @@ static int disable_sched_schedstat(void) > } > > /* perf.data or any other output file name used by stats subcommand (only). */ > -const char *output_name; > +static const char *output_name; > > static int perf_sched__schedstat_record(struct perf_sched *sched, > int argc, const char **argv) > -- > 2.43.0 >
On Tue, Sep 15, 2026 at 12:43:59PM -0700, Ian Rogers wrote: > On Thu, Sep 3, 2026 at 4:28 AM nanshuaibo <nanshuaibo811@163.com> wrote: > > > > The output_name variable is only used within builtin-sched.c for the > > stats subcommand, so declare it static. This fixes a sparse warning: > > > > builtin-sched.c:4140:12: warning: symbol 'output_name' was not > > declared. Should it be static? > > > > Signed-off-by: nanshuaibo <nanshuaibo811@163.com> > > Reviewed-by: Ian Rogers <irogers@google.com> Thanks, applied to perf-tools-next, for v7.4. - Arnaldo
© 2016 - 2026 Red Hat, Inc.