[PATCH v4 0/8] ASoC: mediatek: mt8186: Fix clock error handling

phucduc.bui@gmail.com posted 8 patches 3 weeks, 2 days ago
sound/soc/mediatek/mt8186/mt8186-afe-clk.c  | 95 ++++++++++++++-------
sound/soc/mediatek/mt8186/mt8186-afe-gpio.c |  6 +-
sound/soc/mediatek/mt8186/mt8186-afe-pcm.c  | 21 +++--
3 files changed, 78 insertions(+), 44 deletions(-)
[PATCH v4 0/8] ASoC: mediatek: mt8186: Fix clock error handling
Posted by phucduc.bui@gmail.com 3 weeks, 2 days ago
From: bui duc phuc <phucduc.bui@gmail.com>

Hi all,

This series fixes several error handling issues in the mt8186 ASoC driver.

The patches mainly address failures during APLL/mux, clock, MCK, GPIO,
and regcache operations. In particular, they make sure that partial
failures are handled correctly and that resources are left in a
consistent state.

The series also removes redundant probe error messages where the errors
are already reported by the called functions.

The changes were found by manual code inspection and compile-tested only.

Link v1 : 
https://lore.kernel.org/all/20260820111253.97866-1-phucduc.bui@gmail.com/

Link v2: 
https://lore.kernel.org/all/20260821123021.41390-1-phucduc.bui@gmail.com/

Link v3:
https://lore.kernel.org/all/20260828091532.600047-1-phucduc.bui@gmail.com/

Changes in v2:
 - Update the cover letter.
 - Drop patch 5 from v1.
 - Add Fixes tags.
Changes in v3:
 - Add a patch to fix clock handling in the mux disable path
 - Return directly from apllx_mux_setting() instead of using a goto label
 - Add GPIO rollback handling for partial failures in ADDA DL/UL.
 - Add Handle failures from regcache_sync().
 - Add a patch to remove redundant error messages from the probe path.
 - Update the cover letter.
Changes in v4:
 - In the mux disable path, remove the goto labels so that all teardown
   steps are attempted and any errors are only reported.

Best regards,
Phuc

bui duc phuc (8):
  ASoC: mediatek: mt8186: Fix APLL mux setting error handling
  ASoC: mediatek: mt8186: Fix clock handling in mux disable path
  ASoC: mediatek: mt8186: Fix AFE clock error handling
  ASoC: mediatek: mt8186: Fix APLL enable error handling
  ASoC: mediatek: mt8186: Fix MCK error handling
  ASoC: mediatek: mt8186: Fix gpio rollback on adda dl/ul partial
    failure
  ASoC: mediatek: mt8186: Handle regcache sync failure
  ASoC: mediatek: mt8186: Drop redundant probe error messages

 sound/soc/mediatek/mt8186/mt8186-afe-clk.c  | 95 ++++++++++++++-------
 sound/soc/mediatek/mt8186/mt8186-afe-gpio.c |  6 +-
 sound/soc/mediatek/mt8186/mt8186-afe-pcm.c  | 21 +++--
 3 files changed, 78 insertions(+), 44 deletions(-)

-- 
2.43.0
Re: [PATCH v4 0/8] ASoC: mediatek: mt8186: Fix clock error handling
Posted by Mark Brown 2 weeks, 3 days ago
On Thu, 03 Sep 2026 12:11:42 +0700, phucduc.bui@gmail.com wrote:
> ASoC: mediatek: mt8186: Fix clock error handling
> 
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Hi all,
> 
> This series fixes several error handling issues in the mt8186 ASoC driver.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.4

Thanks!

[1/8] ASoC: mediatek: mt8186: Fix APLL mux setting error handling
      https://git.kernel.org/broonie/sound/c/5ee5987fadf6
[2/8] ASoC: mediatek: mt8186: Fix clock handling in mux disable path
      https://git.kernel.org/broonie/sound/c/d70109f5510b
[3/8] ASoC: mediatek: mt8186: Fix AFE clock error handling
      https://git.kernel.org/broonie/sound/c/eb72060a1966
[4/8] ASoC: mediatek: mt8186: Fix APLL enable error handling
      https://git.kernel.org/broonie/sound/c/cb552c6b9abe
[5/8] ASoC: mediatek: mt8186: Fix MCK error handling
      https://git.kernel.org/broonie/sound/c/996469c1092e
[6/8] ASoC: mediatek: mt8186: Fix gpio rollback on adda dl/ul partial failure
      https://git.kernel.org/broonie/sound/c/d87989ec1c2a
[7/8] ASoC: mediatek: mt8186: Handle regcache sync failure
      https://git.kernel.org/broonie/sound/c/0830625cacf9
[8/8] ASoC: mediatek: mt8186: Drop redundant probe error messages
      https://git.kernel.org/broonie/sound/c/5ca0b1c5e32a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark