Documentation: ACPI: EINJ: Update stale driver source reference

[PATCH] Documentation: ACPI: EINJ: Update stale driver source reference

Posted by Prabhakar Pujeri 3 weeks, 2 days ago

The EINJ implementation was split when CXL protocol error injection
support landed: einj-core.c holds the core logic, einj-cxl.c the
CXL-specific part, and apei-internal.h the shared plumbing. The old
drivers/acpi/apei/einj.c does not exist anymore, so the documentation
points readers at a nonexistent file.

Point them at the actual files instead.

Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
---
 Documentation/firmware-guide/acpi/apei/einj.rst | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
index 7d8435d35..70fa59bd9 100644
--- a/Documentation/firmware-guide/acpi/apei/einj.rst
+++ b/Documentation/firmware-guide/acpi/apei/einj.rst
@@ -180,8 +180,10 @@ function are specified using param1::
 	| segment |   bus  | device | function | reserved |
 	+-------------------------------------------------+
 
-Anyway, you get the idea, if there's doubt just take a look at the code
-in drivers/acpi/apei/einj.c.
+Anyway, you get the idea, if there's doubt just take a look at the code:
+drivers/acpi/apei/einj-core.c holds the core logic, while CXL-specific
+handling lives in drivers/acpi/apei/einj-cxl.c and the shared plumbing
+in drivers/acpi/apei/apei-internal.h.
 
 An ACPI 5.0 BIOS may also allow vendor-specific errors to be injected.
 In this case a file named vendor will contain identifying information

base-commit: 89a312991dc6e638a36adc43ccb91dbc25504c04
-- 
2.55.0

Re: [PATCH] Documentation: ACPI: EINJ: Update stale driver source reference

Posted by Rafael J. Wysocki (Intel) 2 weeks, 2 days ago

On Wed, Sep 2, 2026 at 1:49 PM Prabhakar Pujeri
<prabhakar.pujeri@dell.com> wrote:
>
> The EINJ implementation was split when CXL protocol error injection
> support landed: einj-core.c holds the core logic, einj-cxl.c the
> CXL-specific part, and apei-internal.h the shared plumbing. The old
> drivers/acpi/apei/einj.c does not exist anymore, so the documentation
> points readers at a nonexistent file.
>
> Point them at the actual files instead.
>
> Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
> ---
>  Documentation/firmware-guide/acpi/apei/einj.rst | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/firmware-guide/acpi/apei/einj.rst b/Documentation/firmware-guide/acpi/apei/einj.rst
> index 7d8435d35..70fa59bd9 100644
> --- a/Documentation/firmware-guide/acpi/apei/einj.rst
> +++ b/Documentation/firmware-guide/acpi/apei/einj.rst
> @@ -180,8 +180,10 @@ function are specified using param1::
>         | segment |   bus  | device | function | reserved |
>         +-------------------------------------------------+
>
> -Anyway, you get the idea, if there's doubt just take a look at the code
> -in drivers/acpi/apei/einj.c.
> +Anyway, you get the idea, if there's doubt just take a look at the code:
> +drivers/acpi/apei/einj-core.c holds the core logic, while CXL-specific
> +handling lives in drivers/acpi/apei/einj-cxl.c and the shared plumbing
> +in drivers/acpi/apei/apei-internal.h.
>
>  An ACPI 5.0 BIOS may also allow vendor-specific errors to be injected.
>  In this case a file named vendor will contain identifying information
>
> base-commit: 89a312991dc6e638a36adc43ccb91dbc25504c04
> --

Applied as 7.4 material, thanks!