panic: remove the unneeded panic_print_get()

[PATCH] panic: remove the unneeded panic_print_get()

Posted by Feng Tang 3 weeks, 2 days ago

panic_print_get() was introduced in commit 2683df6539cb ("panic: add
note that 'panic_print' parameter is deprecated") to print out warning
message of the deprecation of 'panic_print' on read access.

Since commit 90f3c123247e ("panic: only warn about deprecated panic_print
on write access"), panic_print_get() wrapper is not needed anymore for
read access, so remove it and use param_get_ulong() instead.

Signed-off-by: Feng Tang <feng.tang@linux.alibaba.com>
---
 kernel/panic.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 7dda841c16f9..50715f14cf04 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -1216,14 +1216,9 @@ static int panic_print_set(const char *val, const struct kernel_param *kp)
 	return  param_set_ulong(val, kp);
 }
 
-static int panic_print_get(char *val, const struct kernel_param *kp)
-{
-	return  param_get_ulong(val, kp);
-}
-
 static const struct kernel_param_ops panic_print_ops = {
 	.set	= panic_print_set,
-	.get	= panic_print_get,
+	.get	= param_get_ulong,
 };
 __core_param_cb(panic_print, &panic_print_ops, &panic_print, 0644);
 
-- 
2.43.5

Re: [PATCH] panic: remove the unneeded panic_print_get()

Posted by Petr Mladek 3 weeks, 1 day ago

On Wed 2026-09-02 19:48:51, Feng Tang wrote:
> panic_print_get() was introduced in commit 2683df6539cb ("panic: add
> note that 'panic_print' parameter is deprecated") to print out warning
> message of the deprecation of 'panic_print' on read access.
> 
> Since commit 90f3c123247e ("panic: only warn about deprecated panic_print
> on write access"), panic_print_get() wrapper is not needed anymore for
> read access, so remove it and use param_get_ulong() instead.
> 
> Signed-off-by: Feng Tang <feng.tang@linux.alibaba.com>

Nice cleanup.

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

Re: [PATCH] panic: remove the unneeded panic_print_get()

Posted by Bradley Morgan 3 weeks, 2 days ago

On 2 September 2026 12:48:51 BST, Feng Tang <feng.tang@linux.alibaba.com>
wrote:

Feng!

>panic_print_get() was introduced in commit 2683df6539cb ("panic: add
>note that 'panic_print' parameter is deprecated") to print out warning
>message of the deprecation of 'panic_print' on read access.
>
>Since commit 90f3c123247e ("panic: only warn about deprecated panic_print
>on write access"), panic_print_get() wrapper is not needed anymore for
>read access, so remove it and use param_get_ulong() instead.
>

could you say that this is only a cleanup?

Reviewed-by: Bradley Morgan <brads@mainlining.org>


>Signed-off-by: Feng Tang <feng.tang@linux.alibaba.com>
>---
> kernel/panic.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/kernel/panic.c b/kernel/panic.c
>index 7dda841c16f9..50715f14cf04 100644
>--- a/kernel/panic.c
>+++ b/kernel/panic.c
>@@ -1216,14 +1216,9 @@ static int panic_print_set(const char *val, const struct kernel_param *kp)
> 	return  param_set_ulong(val, kp);
> }
> 
>-static int panic_print_get(char *val, const struct kernel_param *kp)
>-{
>-	return  param_get_ulong(val, kp);
>-}
>-
> static const struct kernel_param_ops panic_print_ops = {
> 	.set	= panic_print_set,
>-	.get	= panic_print_get,
>+	.get	= param_get_ulong,

Ack.


> };
> __core_param_cb(panic_print, &panic_print_ops, &panic_print, 0644);
> 
>

--- Thanks!
https://lore.kernel.org/all/EE579805-42F2-4C58-B752-F28779EEB717@grrlz.net/