mm/damon/core.c | 16 ++++++++++++++-- mm/damon/sysfs.c | 11 +++++------ mm/damon/tests/core-kunit.h | 16 ++++++++++------ 3 files changed, 29 insertions(+), 14 deletions(-)
DAMOS quota goals commit unit test is mistakenly not testing a test case that was designed to test. DAMOS quota goals and DAMON sysfs refresh_ms file have bugs that can produce non critical but still unexpected behaviors. Fix the bugs. Patch 1 fixes the DAMOS quota goals commit unit test to cover a mistakenly uncovered case. Patches 2 and 3 fix the bugs in DAMOS PSI goal initialization and eligible_mem_bp online commit, respectively. Patch 4 fixes the bug in DAMON sysfs refresh_ms file handling. Changes from RFC v1.3 - RFC v1.3: https://lore.kernel.org/20260828183649.71192-1-sj@kernel.org - Drop RFC tag. - Rebase to latest mm-new. Changes from RFC v1.2 - RFC v1.2: https://lore.kernel.org/20260828014659.121058-1-sj@kernel.org - Fix last_psi_total underflow. Changes from RFC v1.1 - RFC v1.1: https://lore.kernel.org/20260827134429.123023-1-sj@kernel.org - Fix quota goals commit unit test that was mistakenly missing a test case. - Initialize last_psi_total as uninitialized at the beginning. - Correct kunit test for changed last_psi_total initialization behavior. Changes from RFC - RFC: https://lore.kernel.org/20260827042920.93580-1-sj@kernel.org (Mistakenly missed RFC tag) - Fix build error. - Add eligible_mem_bp nid commit fix. SJ Park (4): mm/damon/tests/core-kunit: test committing psi goal to psi goal mm/damon/core: handle uninitialized damos_quota_goal->last_psi_total mm/damon/core: copy nid for eligible_mem_bp damos quota goal commit mm/damon/sysfs: set next refresh jiffies per sysfs context mm/damon/core.c | 16 ++++++++++++++-- mm/damon/sysfs.c | 11 +++++------ mm/damon/tests/core-kunit.h | 16 ++++++++++------ 3 files changed, 29 insertions(+), 14 deletions(-) base-commit: ee125db0b1f24a2f6b04e3143ffe1a14324176fe -- 2.47.3
Hi SJ, > Patch 1 fixes the DAMOS quota goals commit unit test to cover a > mistakenly uncovered case. Patches 2 and 3 fix the bugs in DAMOS PSI > goal initialization and eligible_mem_bp online commit, respectively. > Patch 4 fixes the bug in DAMON sysfs refresh_ms file handling. I reviewed and tested the integrated four-patch series in mm-new: a20e38846efb..72dc8fdaae62 The integrated commits had stable patch-ids matching the posted patches. DAMON KUnit passed 42/42 tests. I also ran test-only eligible_mem_bp nid and two-kdamond refresh-isolation regression cases; they passed 42/42 and 43/43 tests, respectively. Both test-only changes were then removed and the worktree returned clean at the unchanged series tip. These were functional UML KUnit tests. The fixes look good to me. For the series: Reviewed-by: Lian Wang <lianux.mm@gmail.com> Tested-by: Lian Wang <lianux.mm@gmail.com> Thanks, Lian
On Thu, 3 Sep 2026 11:13:28 +0800 Lian Wang <lianux.mm@gmail.com> wrote: > Hi SJ, > > > Patch 1 fixes the DAMOS quota goals commit unit test to cover a > > mistakenly uncovered case. Patches 2 and 3 fix the bugs in DAMOS PSI > > goal initialization and eligible_mem_bp online commit, respectively. > > Patch 4 fixes the bug in DAMON sysfs refresh_ms file handling. > > I reviewed and tested the integrated four-patch series in mm-new: > > a20e38846efb..72dc8fdaae62 > > The integrated commits had stable patch-ids matching the posted patches. > DAMON KUnit passed 42/42 tests. I also ran test-only eligible_mem_bp nid and > two-kdamond refresh-isolation regression cases; they passed 42/42 and 43/43 > tests, respectively. Both test-only changes were then removed and the > worktree returned clean at the unchanged series tip. > > These were functional UML KUnit tests. The fixes look good to me. > > For the series: > > Reviewed-by: Lian Wang <lianux.mm@gmail.com> > Tested-by: Lian Wang <lianux.mm@gmail.com> Thank you for your review and test, Lian! Thanks, SJ [...]
On Tue, 1 Sep 2026 17:27:19 -0700 SJ Park <sj@kernel.org> wrote: > DAMOS quota goals commit unit test is mistakenly not testing a test case > that was designed to test. DAMOS quota goals and DAMON sysfs refresh_ms > file have bugs that can produce non critical but still unexpected > behaviors. Fix the bugs. Sashiko found no blocker for this series. Sashiko sent findings to damon@ mailing list [1], and I replied to all the comments. Please read those for details. Sashiko found a typo in the commit message of patch 3, though. It should 's/QUITA/QUOTA/'. I asked Andrew if he could fix it from his side. [1] https://lore.kernel.org/damon/ Thanks, SJ
© 2016 - 2026 Red Hat, Inc.