tools/power/x86/intel-speed-select: Clean up more build artifacts in 'clean' target

[PATCH] tools/power/x86/intel-speed-select: Clean up more build artifacts in 'clean' target

Posted by zhangjiao2 3 weeks, 4 days ago

From: zhang jiao <zhangjiao2@cmss.chinamobile.com>

The 'clean' target currently leaves behind .* .o.cmd and .* .o.d files,
as well as the generated 'include' directory. Extend the target to
remove these so 'make clean' fully resets the build tree.

Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
 tools/power/x86/intel-speed-select/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/power/x86/intel-speed-select/Makefile b/tools/power/x86/intel-speed-select/Makefile
index 6b299aae2ded..46874e4cee51 100644
--- a/tools/power/x86/intel-speed-select/Makefile
+++ b/tools/power/x86/intel-speed-select/Makefile
@@ -54,6 +54,8 @@ clean:
 	rm -f $(ALL_PROGRAMS)
 	rm -rf $(OUTPUT)include/linux/isst_if.h
 	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
+	find $(or $(OUTPUT),.) -name '.*.o.cmd' -delete -o -name '.*.o.d' -delete
+	find $(or $(OUTPUT),.) -type d -name 'include' -exec rm -rf {} +
 
 install: $(ALL_PROGRAMS)
 	install -d -m 755 $(DESTDIR)$(bindir);		\
-- 
2.33.0

Re: [PATCH] tools/power/x86/intel-speed-select: Clean up more build artifacts in 'clean' target

Posted by Jiri Slaby 2 weeks, 4 days ago

On 01. 09. 26, 11:36, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> The 'clean' target currently leaves behind .* .o.cmd and .* .o.d files,
> as well as the generated 'include' directory. Extend the target to
> remove these so 'make clean' fully resets the build tree.
> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
>   tools/power/x86/intel-speed-select/Makefile | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tools/power/x86/intel-speed-select/Makefile b/tools/power/x86/intel-speed-select/Makefile
> index 6b299aae2ded..46874e4cee51 100644
> --- a/tools/power/x86/intel-speed-select/Makefile
> +++ b/tools/power/x86/intel-speed-select/Makefile
> @@ -54,6 +54,8 @@ clean:
>   	rm -f $(ALL_PROGRAMS)
>   	rm -rf $(OUTPUT)include/linux/isst_if.h
>   	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
> +	find $(or $(OUTPUT),.) -name '.*.o.cmd' -delete -o -name '.*.o.d' -delete

There are no *.d at this point (removed by the previous find). You can 
do it on one line (as many of the other tools/):
find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '.*.o.d' -delete -o 
-name '.*.o.cmd' -delete

> +	find $(or $(OUTPUT),.) -type d -name 'include' -exec rm -rf {} +

So you can remove "rm -rf $(OUTPUT)include/linux/isst_if.h" above, right?

thanks,
-- 
js
suse labs

Re: [PATCH] tools/power/x86/intel-speed-select: Clean up more build artifacts in 'clean' target

Posted by srinivas pandruvada 2 days, 13 hours ago

Hi Jiao,

Friendly ping, I have to send pull request on Monday.

Thanks,
Srinivas

On Tue, 2026-09-08 at 09:39 +0200, Jiri Slaby wrote:
> On 01. 09. 26, 11:36, zhangjiao2 wrote:
> > From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> > 
> > The 'clean' target currently leaves behind .* .o.cmd and .* .o.d
> > files,
> > as well as the generated 'include' directory. Extend the target to
> > remove these so 'make clean' fully resets the build tree.
> > 
> > Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> > ---
> >   tools/power/x86/intel-speed-select/Makefile | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/power/x86/intel-speed-select/Makefile
> > b/tools/power/x86/intel-speed-select/Makefile
> > index 6b299aae2ded..46874e4cee51 100644
> > --- a/tools/power/x86/intel-speed-select/Makefile
> > +++ b/tools/power/x86/intel-speed-select/Makefile
> > @@ -54,6 +54,8 @@ clean:
> >   	rm -f $(ALL_PROGRAMS)
> >   	rm -rf $(OUTPUT)include/linux/isst_if.h
> >   	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name
> > '\.*.d' -delete
> > +	find $(or $(OUTPUT),.) -name '.*.o.cmd' -delete -o -name
> > '.*.o.d' -delete
> 
> There are no *.d at this point (removed by the previous find). You
> can 
> do it on one line (as many of the other tools/):
> find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '.*.o.d' -delete
> -o 
> -name '.*.o.cmd' -delete
> 
> > +	find $(or $(OUTPUT),.) -type d -name 'include' -exec rm -
> > rf {} +
> 
> So you can remove "rm -rf $(OUTPUT)include/linux/isst_if.h" above,
> right?
> 
> thanks,

Re: [PATCH] tools/power/x86/intel-speed-select: Clean up more build artifacts in 'clean' target

Posted by srinivas pandruvada 2 weeks, 2 days ago

On Tue, 2026-09-08 at 09:39 +0200, Jiri Slaby wrote:
> On 01. 09. 26, 11:36, zhangjiao2 wrote:
> > From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> > 
> > The 'clean' target currently leaves behind .* .o.cmd and .* .o.d
> > files,
> > as well as the generated 'include' directory. Extend the target to
> > remove these so 'make clean' fully resets the build tree.
> > 
> > Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> > ---
> >   tools/power/x86/intel-speed-select/Makefile | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/power/x86/intel-speed-select/Makefile
> > b/tools/power/x86/intel-speed-select/Makefile
> > index 6b299aae2ded..46874e4cee51 100644
> > --- a/tools/power/x86/intel-speed-select/Makefile
> > +++ b/tools/power/x86/intel-speed-select/Makefile
> > @@ -54,6 +54,8 @@ clean:
> >   	rm -f $(ALL_PROGRAMS)
> >   	rm -rf $(OUTPUT)include/linux/isst_if.h
> >   	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name
> > '\.*.d' -delete
> > +	find $(or $(OUTPUT),.) -name '.*.o.cmd' -delete -o -name
> > '.*.o.d' -delete
> 
> There are no *.d at this point (removed by the previous find). You
> can 
> do it on one line (as many of the other tools/):
> find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '.*.o.d' -delete
> -o 
> -name '.*.o.cmd' -delete
> 
> > +	find $(or $(OUTPUT),.) -type d -name 'include' -exec rm -
> > rf {} +
> 
> So you can remove "rm -rf $(OUTPUT)include/linux/isst_if.h" above,
> right?

Hi Zhang,

This makes sense.
Please resubmit.

Thanks,
Srinivas

> 
> thanks,