drm/panfrost: Rename "panthor" prefixes in debugfs identifiers

[PATCH] drm/panfrost: Rename "panthor" prefixes in debugfs identifiers

Posted by Nicolas Frattaroli 3 weeks, 3 days ago

When gems debugfs support was copied over from panthor to panfrost, the
function and struct names were not adjusted to carry the panfrost
prefix instead of the panthor prefix.

Rectify this by renaming them. No functional change.

Fixes: e48ade5e23ba ("drm/panfrost: show device-wide list of DRM GEM objects over DebugFS")
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
 drivers/gpu/drm/panfrost/panfrost_drv.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
index 96a66d673ba6..f5f11ad5f9b3 100644
--- a/drivers/gpu/drm/panfrost/panfrost_drv.c
+++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
@@ -794,7 +794,7 @@ static const struct file_operations panfrost_drm_driver_fops = {
 };
 
 #ifdef CONFIG_DEBUG_FS
-static int panthor_gems_show(struct seq_file *m, void *data)
+static int panfrost_gems_show(struct seq_file *m, void *data)
 {
 	struct drm_info_node *node = m->private;
 	struct panfrost_device *pfdev = to_panfrost_device(node->minor->dev);
@@ -845,15 +845,15 @@ static int show_file_jm_ctxs(struct panfrost_file_priv *pfile,
 	return 0;
 }
 
-static struct drm_info_list panthor_debugfs_list[] = {
+static struct drm_info_list panfrost_debugfs_list[] = {
 	{"gems",
-	 panthor_gems_show, 0, NULL},
+	 panfrost_gems_show, 0, NULL},
 };
 
-static int panthor_gems_debugfs_init(struct drm_minor *minor)
+static int panfrost_gems_debugfs_init(struct drm_minor *minor)
 {
-	drm_debugfs_create_files(panthor_debugfs_list,
-				 ARRAY_SIZE(panthor_debugfs_list),
+	drm_debugfs_create_files(panfrost_debugfs_list,
+				 ARRAY_SIZE(panfrost_debugfs_list),
 				 minor->debugfs_root, minor);
 
 	return 0;
@@ -915,7 +915,7 @@ static void panfrost_sched_debugfs_init(struct drm_minor *minor)
 
 static void panfrost_debugfs_init(struct drm_minor *minor)
 {
-	panthor_gems_debugfs_init(minor);
+	panfrost_gems_debugfs_init(minor);
 	panfrost_sched_debugfs_init(minor);
 }
 #endif

---
base-commit: 0116f19db5931348c937eafa1f76a9a19bf82c81
change-id: 20260901-panfrost-prefix-whoopsie-26300bf2dce9

Best regards,
--  
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Re: [PATCH] drm/panfrost: Rename "panthor" prefixes in debugfs identifiers

Posted by Adrián Larumbe 2 weeks ago

Hi Nicolas, thanks for the patch.

I was wondering whether it makes sense to apply it in light of changes
in a patch series I've been working on for quite some time. One of the
patches moves all debugfs plumbing away from panfrost_drv.c and into
their relevant subsystems, and as part of that change I've renamed all
erroneous panthor_* prefixes into panfrost.

However, if the right policy in this case is to have them both committed
separately, then I'll be applying this one first.

Check https://lore.kernel.org/r/20260912-claude-fixes-v9-0-e588feaa61ef@collabora.com
patch 3/16 for further context. 

Reviewed-by: Adrián Larumbe <adrian.larumbe@collabora.com>

On 01.09.2026 15:39, Nicolas Frattaroli wrote:
> When gems debugfs support was copied over from panthor to panfrost, the
> function and struct names were not adjusted to carry the panfrost
> prefix instead of the panthor prefix.
> 
> Rectify this by renaming them. No functional change.
> 
> Fixes: e48ade5e23ba ("drm/panfrost: show device-wide list of DRM GEM objects over DebugFS")
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_drv.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 96a66d673ba6..f5f11ad5f9b3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -794,7 +794,7 @@ static const struct file_operations panfrost_drm_driver_fops = {
>  };
>  
>  #ifdef CONFIG_DEBUG_FS
> -static int panthor_gems_show(struct seq_file *m, void *data)
> +static int panfrost_gems_show(struct seq_file *m, void *data)
>  {
>  	struct drm_info_node *node = m->private;
>  	struct panfrost_device *pfdev = to_panfrost_device(node->minor->dev);
> @@ -845,15 +845,15 @@ static int show_file_jm_ctxs(struct panfrost_file_priv *pfile,
>  	return 0;
>  }
>  
> -static struct drm_info_list panthor_debugfs_list[] = {
> +static struct drm_info_list panfrost_debugfs_list[] = {
>  	{"gems",
> -	 panthor_gems_show, 0, NULL},
> +	 panfrost_gems_show, 0, NULL},
>  };
>  
> -static int panthor_gems_debugfs_init(struct drm_minor *minor)
> +static int panfrost_gems_debugfs_init(struct drm_minor *minor)
>  {
> -	drm_debugfs_create_files(panthor_debugfs_list,
> -				 ARRAY_SIZE(panthor_debugfs_list),
> +	drm_debugfs_create_files(panfrost_debugfs_list,
> +				 ARRAY_SIZE(panfrost_debugfs_list),
>  				 minor->debugfs_root, minor);
>  
>  	return 0;
> @@ -915,7 +915,7 @@ static void panfrost_sched_debugfs_init(struct drm_minor *minor)
>  
>  static void panfrost_debugfs_init(struct drm_minor *minor)
>  {
> -	panthor_gems_debugfs_init(minor);
> +	panfrost_gems_debugfs_init(minor);
>  	panfrost_sched_debugfs_init(minor);
>  }
>  #endif
> 
> ---
> base-commit: 0116f19db5931348c937eafa1f76a9a19bf82c81
> change-id: 20260901-panfrost-prefix-whoopsie-26300bf2dce9
> 
> Best regards,
> --  
> Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Adrian Larumbe

Re: [PATCH] drm/panfrost: Rename "panthor" prefixes in debugfs identifiers

Posted by Thomas Zimmermann 3 weeks, 3 days ago


Am 01.09.26 um 15:39 schrieb Nicolas Frattaroli:
> When gems debugfs support was copied over from panthor to panfrost, the
> function and struct names were not adjusted to carry the panfrost
> prefix instead of the panthor prefix.
>
> Rectify this by renaming them. No functional change.
>
> Fixes: e48ade5e23ba ("drm/panfrost: show device-wide list of DRM GEM objects over DebugFS")
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/panfrost/panfrost_drv.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index 96a66d673ba6..f5f11ad5f9b3 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -794,7 +794,7 @@ static const struct file_operations panfrost_drm_driver_fops = {
>   };
>   
>   #ifdef CONFIG_DEBUG_FS
> -static int panthor_gems_show(struct seq_file *m, void *data)
> +static int panfrost_gems_show(struct seq_file *m, void *data)
>   {
>   	struct drm_info_node *node = m->private;
>   	struct panfrost_device *pfdev = to_panfrost_device(node->minor->dev);
> @@ -845,15 +845,15 @@ static int show_file_jm_ctxs(struct panfrost_file_priv *pfile,
>   	return 0;
>   }
>   
> -static struct drm_info_list panthor_debugfs_list[] = {
> +static struct drm_info_list panfrost_debugfs_list[] = {
>   	{"gems",
> -	 panthor_gems_show, 0, NULL},
> +	 panfrost_gems_show, 0, NULL},
>   };
>   
> -static int panthor_gems_debugfs_init(struct drm_minor *minor)
> +static int panfrost_gems_debugfs_init(struct drm_minor *minor)
>   {
> -	drm_debugfs_create_files(panthor_debugfs_list,
> -				 ARRAY_SIZE(panthor_debugfs_list),
> +	drm_debugfs_create_files(panfrost_debugfs_list,
> +				 ARRAY_SIZE(panfrost_debugfs_list),
>   				 minor->debugfs_root, minor);
>   
>   	return 0;
> @@ -915,7 +915,7 @@ static void panfrost_sched_debugfs_init(struct drm_minor *minor)
>   
>   static void panfrost_debugfs_init(struct drm_minor *minor)
>   {
> -	panthor_gems_debugfs_init(minor);
> +	panfrost_gems_debugfs_init(minor);
>   	panfrost_sched_debugfs_init(minor);
>   }
>   #endif
>
> ---
> base-commit: 0116f19db5931348c937eafa1f76a9a19bf82c81
> change-id: 20260901-panfrost-prefix-whoopsie-26300bf2dce9
>
> Best regards,
> --
> Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
>

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, (HRB 36809, AG Nürnberg)