platform/x86/amd/pmf: fix build on !CONFIG_AMD_PMF_DEBUG

[PATCH] platform/x86/amd/pmf: fix build on !CONFIG_AMD_PMF_DEBUG

Posted by Pedro Falcato 3 weeks, 5 days ago

amd_pmf_get_ta_custom_bios_inputs() is used by non-debug features.

Fix the build on !CONFIG_AMD_PMF_DEBUG by moving
amd_pmf_get_ta_custom_bios_inputs() outside the ifdef CONFIG_AMD_PMF_DEBUG.

Fixes: 5bda82c797c9 ("platform/x86/amd/pmf: Implement util layer ioctl handler")
Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Link: https://lore.kernel.org/all/fS7s9V_xTaedaqEAaxwKnQ@natalenko.name/
Signed-off-by: Pedro Falcato <pfalcato@suse.de>
---
 drivers/platform/x86/amd/pmf/spc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/amd/pmf/spc.c b/drivers/platform/x86/amd/pmf/spc.c
index 94355b435a66..592ba4de4c7f 100644
--- a/drivers/platform/x86/amd/pmf/spc.c
+++ b/drivers/platform/x86/amd/pmf/spc.c
@@ -17,7 +17,6 @@
 #include <linux/units.h>
 #include "pmf.h"
 
-#ifdef CONFIG_AMD_PMF_DEBUG
 u32 amd_pmf_get_ta_custom_bios_inputs(struct ta_pmf_enact_table *in, int index)
 {
 	switch (index) {
@@ -31,6 +30,7 @@ u32 amd_pmf_get_ta_custom_bios_inputs(struct ta_pmf_enact_table *in, int index)
 }
 EXPORT_SYMBOL(amd_pmf_get_ta_custom_bios_inputs);
 
+#ifdef CONFIG_AMD_PMF_DEBUG
 void amd_pmf_dump_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in)
 {
 	int i;
-- 
2.55.0

Re: [PATCH] platform/x86/amd/pmf: fix build on !CONFIG_AMD_PMF_DEBUG

Posted by Ilpo Järvinen 3 weeks, 5 days ago

On Mon, 31 Aug 2026 12:43:46 +0100, Pedro Falcato wrote:

> amd_pmf_get_ta_custom_bios_inputs() is used by non-debug features.
> 
> Fix the build on !CONFIG_AMD_PMF_DEBUG by moving
> amd_pmf_get_ta_custom_bios_inputs() outside the ifdef CONFIG_AMD_PMF_DEBUG.

Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86/amd/pmf: fix build on !CONFIG_AMD_PMF_DEBUG
      commit: 9048155855ce84065645c8db7823ab7e218e49cc

--
 i.

Re: [PATCH] platform/x86/amd/pmf: fix build on !CONFIG_AMD_PMF_DEBUG

Posted by Mario Limonciello 3 weeks, 5 days ago


On 8/31/26 06:43, Pedro Falcato wrote:
> amd_pmf_get_ta_custom_bios_inputs() is used by non-debug features.
> 
> Fix the build on !CONFIG_AMD_PMF_DEBUG by moving
> amd_pmf_get_ta_custom_bios_inputs() outside the ifdef CONFIG_AMD_PMF_DEBUG.
> 
> Fixes: 5bda82c797c9 ("platform/x86/amd/pmf: Implement util layer ioctl handler")
> Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> Link: https://lore.kernel.org/all/fS7s9V_xTaedaqEAaxwKnQ@natalenko.name/
> Signed-off-by: Pedro Falcato <pfalcato@suse.de>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>> ---
>   drivers/platform/x86/amd/pmf/spc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/spc.c b/drivers/platform/x86/amd/pmf/spc.c
> index 94355b435a66..592ba4de4c7f 100644
> --- a/drivers/platform/x86/amd/pmf/spc.c
> +++ b/drivers/platform/x86/amd/pmf/spc.c
> @@ -17,7 +17,6 @@
>   #include <linux/units.h>
>   #include "pmf.h"
>   
> -#ifdef CONFIG_AMD_PMF_DEBUG
>   u32 amd_pmf_get_ta_custom_bios_inputs(struct ta_pmf_enact_table *in, int index)
>   {
>   	switch (index) {
> @@ -31,6 +30,7 @@ u32 amd_pmf_get_ta_custom_bios_inputs(struct ta_pmf_enact_table *in, int index)
>   }
>   EXPORT_SYMBOL(amd_pmf_get_ta_custom_bios_inputs);
>   
> +#ifdef CONFIG_AMD_PMF_DEBUG
>   void amd_pmf_dump_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in)
>   {
>   	int i;

Re: [PATCH] platform/x86/amd/pmf: fix build on !CONFIG_AMD_PMF_DEBUG

Posted by Oleksandr Natalenko 3 weeks, 5 days ago

Hello.

On pondělí 31. srpna 2026 13:43:46, středoevropský letní čas Pedro Falcato wrote:
> amd_pmf_get_ta_custom_bios_inputs() is used by non-debug features.
> 
> Fix the build on !CONFIG_AMD_PMF_DEBUG by moving
> amd_pmf_get_ta_custom_bios_inputs() outside the ifdef CONFIG_AMD_PMF_DEBUG.
> 
> Fixes: 5bda82c797c9 ("platform/x86/amd/pmf: Implement util layer ioctl handler")
> Reported-by: Oleksandr Natalenko <oleksandr@natalenko.name>
> Link: https://lore.kernel.org/all/fS7s9V_xTaedaqEAaxwKnQ@natalenko.name/
> Signed-off-by: Pedro Falcato <pfalcato@suse.de>
> ---
>  drivers/platform/x86/amd/pmf/spc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/amd/pmf/spc.c b/drivers/platform/x86/amd/pmf/spc.c
> index 94355b435a66..592ba4de4c7f 100644
> --- a/drivers/platform/x86/amd/pmf/spc.c
> +++ b/drivers/platform/x86/amd/pmf/spc.c
> @@ -17,7 +17,6 @@
>  #include <linux/units.h>
>  #include "pmf.h"
>  
> -#ifdef CONFIG_AMD_PMF_DEBUG
>  u32 amd_pmf_get_ta_custom_bios_inputs(struct ta_pmf_enact_table *in, int index)
>  {
>  	switch (index) {
> @@ -31,6 +30,7 @@ u32 amd_pmf_get_ta_custom_bios_inputs(struct ta_pmf_enact_table *in, int index)
>  }
>  EXPORT_SYMBOL(amd_pmf_get_ta_custom_bios_inputs);
>  
> +#ifdef CONFIG_AMD_PMF_DEBUG
>  void amd_pmf_dump_ta_inputs(struct amd_pmf_dev *dev, struct ta_pmf_enact_table *in)
>  {
>  	int i;
> 

This fixes it for me, thank you.

Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>

-- 
Oleksandr Natalenko, MSE