RDMA/mana_ib: Remove redundant NULL check before netdev_put()

[PATCH rdma-next] RDMA/mana_ib: Remove redundant NULL check before netdev_put()

Posted by Sang-Heon Jeon 3 weeks, 5 days ago

netdev_put() does nothing if dev is NULL, so the check before the call
is redundant.

So remove it. No functional change.

This is the result of running the Coccinelle script from
scripts/coccinelle/free/ifnulldev_put.cocci after commit f83b8a58695c
("coccinelle: ifnulldev_put: update outdated helper names").

Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
---
 drivers/infiniband/hw/mana/device.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/mana/device.c b/drivers/infiniband/hw/mana/device.c
index a8d19586a78a..62c7803ca6c6 100644
--- a/drivers/infiniband/hw/mana/device.c
+++ b/drivers/infiniband/hw/mana/device.c
@@ -103,8 +103,7 @@ static int mana_ib_netdev_event(struct notifier_block *this,
 				ib_device_set_netdev(&dev->ib_dev, ndev, i + 1);
 
 				/* mana_get_primary_netdev() returns ndev with refcount held */
-				if (ndev)
-					netdev_put(ndev, &dev->dev_tracker);
+				netdev_put(ndev, &dev->dev_tracker);
 
 				return NOTIFY_OK;
 			default:
-- 
2.43.0

Re: [PATCH rdma-next] RDMA/mana_ib: Remove redundant NULL check before netdev_put()

Posted by Leon Romanovsky 3 weeks, 4 days ago

On Mon, 31 Aug 2026 14:21:07 +0900, Sang-Heon Jeon wrote:
> netdev_put() does nothing if dev is NULL, so the check before the call
> is redundant.
> 
> So remove it. No functional change.
> 
> This is the result of running the Coccinelle script from
> scripts/coccinelle/free/ifnulldev_put.cocci after commit f83b8a58695c
> ("coccinelle: ifnulldev_put: update outdated helper names").
> 
> [...]

Applied, thanks!

[1/1] RDMA/mana_ib: Remove redundant NULL check before netdev_put()
      https://git.kernel.org/rdma/rdma/c/2f02eee8d632f7

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>