tools/testing/selftests/mm/.gitignore | 2 ++ 1 file changed, 2 insertions(+)
Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
switched to a pattern-matching mechanism to reduce churn in .gitignore.
It however accidentally excluded the page_frag test's-generated module
intermediate C file with .mod.c extension, and also the local_config.h
header generated if liburing is available locally.
Explicitly fix both the issues, fixing the module-generated C file as a
general pattern as these are always intermediate files that should be
ignored.
Since this is a trivial .gitignore change it doesn't seem necessary to
treat it as a hotfix.
Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
---
tools/testing/selftests/mm/.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
index fcd892ed21e3..a306d7754786 100644
--- a/tools/testing/selftests/mm/.gitignore
+++ b/tools/testing/selftests/mm/.gitignore
@@ -2,7 +2,9 @@
*
!/**/
!*.c
+*.mod.c
!*.h
+local_config.h
!*.sh
!.gitignore
!Makefile
---
base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
Cheers,
--
Lorenzo Stoakes (ARM) <ljs@kernel.org>
On 8/31/26 16:18, Lorenzo Stoakes (ARM) wrote:
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
Acked-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
Thanks for the fix and apologies for missing it.
Regards,
Pratyush
On Mon, Aug 31, 2026 at 7:18 AM Lorenzo Stoakes (ARM) <ljs@kernel.org> wrote:
>
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> tools/testing/selftests/mm/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index fcd892ed21e3..a306d7754786 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -2,7 +2,9 @@
> *
> !/**/
> !*.c
> +*.mod.c
> !*.h
> +local_config.h
> !*.sh
> !.gitignore
> !Makefile
>
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
>
> Cheers,
> --
> Lorenzo Stoakes (ARM) <ljs@kernel.org>
>
On Mon, Aug 31, 2026 at 09:31:06PM -0700, Pratyush Mallick wrote:
> Thanks for the fix and apologies for missing it.
No worries, very easy to miss stuff with these :) thanks for cleaning this up,
it's MUCH better now...
>
> Regards,
> Pratyush
>
>
> On Mon, Aug 31, 2026 at 7:18 AM Lorenzo Stoakes (ARM) <ljs@kernel.org> wrote:
> >
> > Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> > switched to a pattern-matching mechanism to reduce churn in .gitignore.
> >
> > It however accidentally excluded the page_frag test's-generated module
> > intermediate C file with .mod.c extension, and also the local_config.h
> > header generated if liburing is available locally.
> >
> > Explicitly fix both the issues, fixing the module-generated C file as a
> > general pattern as these are always intermediate files that should be
> > ignored.
> >
> > Since this is a trivial .gitignore change it doesn't seem necessary to
> > treat it as a hotfix.
> >
> > Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> > ---
> > tools/testing/selftests/mm/.gitignore | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> > index fcd892ed21e3..a306d7754786 100644
> > --- a/tools/testing/selftests/mm/.gitignore
> > +++ b/tools/testing/selftests/mm/.gitignore
> > @@ -2,7 +2,9 @@
> > *
> > !/**/
> > !*.c
> > +*.mod.c
> > !*.h
> > +local_config.h
> > !*.sh
> > !.gitignore
> > !Makefile
> >
> > ---
> > base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> > change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
> >
> > Cheers,
> > --
> > Lorenzo Stoakes (ARM) <ljs@kernel.org>
> >
--
Cheers, Lorenzo
On 8/31/26 7:48 PM, Lorenzo Stoakes (ARM) wrote:
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Looks good to me.
Reviewed-by: Sarthak Sharma <sarthak.sharma@arm.com>
> ---
> tools/testing/selftests/mm/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index fcd892ed21e3..a306d7754786 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -2,7 +2,9 @@
> *
> !/**/
> !*.c
> +*.mod.c
> !*.h
> +local_config.h
> !*.sh
> !.gitignore
> !Makefile
>
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
>
> Cheers,
On Mon, Aug 31, 2026 at 03:18:23PM +0100, Lorenzo Stoakes (ARM) wrote:
> Commit 2bee308f3adb ("selftests/mm: use pattern matching in .gitignore")
> switched to a pattern-matching mechanism to reduce churn in .gitignore.
>
> It however accidentally excluded the page_frag test's-generated module
> intermediate C file with .mod.c extension, and also the local_config.h
> header generated if liburing is available locally.
>
> Explicitly fix both the issues, fixing the module-generated C file as a
> general pattern as these are always intermediate files that should be
> ignored.
>
> Since this is a trivial .gitignore change it doesn't seem necessary to
> treat it as a hotfix.
>
> Signed-off-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Reviewed-by: Gregory Price (Meta) <gourry@gourry.net>
> ---
> tools/testing/selftests/mm/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore
> index fcd892ed21e3..a306d7754786 100644
> --- a/tools/testing/selftests/mm/.gitignore
> +++ b/tools/testing/selftests/mm/.gitignore
> @@ -2,7 +2,9 @@
> *
> !/**/
> !*.c
> +*.mod.c
> !*.h
> +local_config.h
> !*.sh
> !.gitignore
> !Makefile
>
> ---
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> change-id: 20260831-fix-mm-selftests-gitignore-dd389da72760
>
> Cheers,
> --
> Lorenzo Stoakes (ARM) <ljs@kernel.org>
>
© 2016 - 2026 Red Hat, Inc.