[PATCH] spi: virtio: drop duplicate completion init

Francesco Valla posted 1 patch 3 weeks, 6 days ago
drivers/spi/spi-virtio.c | 2 --
1 file changed, 2 deletions(-)
[PATCH] spi: virtio: drop duplicate completion init
Posted by Francesco Valla 3 weeks, 6 days ago
The completion iused for SPI transfers is initialized twice in the
same function, without it being used in between. Drop the redundant
initialization.

Signed-off-by: Francesco Valla <francesco@valla.it>
---
 drivers/spi/spi-virtio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/spi/spi-virtio.c b/drivers/spi/spi-virtio.c
index 2256dfec5407..87ce32b6d133 100644
--- a/drivers/spi/spi-virtio.c
+++ b/drivers/spi/spi-virtio.c
@@ -162,8 +162,6 @@ static int virtio_spi_transfer_one(struct spi_controller *ctrl,
 	if (!spi_req)
 		return -ENOMEM;
 
-	init_completion(&spi_req->completion);
-
 	th = &spi_req->transfer_head;
 
 	/* Fill struct spi_transfer_head */

---
base-commit: 08dbfad3f5040f5bdb6c529da20d6d4e81fefd72
change-id: 20260830-virtio-spi-fix-ca33b12bab2b

Best regards,
--  
Francesco Valla <francesco@valla.it>
Re: [PATCH] spi: virtio: drop duplicate completion init
Posted by Mark Brown 3 weeks, 5 days ago
On Sun, 30 Aug 2026 15:48:35 +0200, Francesco Valla wrote:
> spi: virtio: drop duplicate completion init

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.4

Thanks!

[1/1] spi: virtio: drop duplicate completion init
      https://git.kernel.org/broonie/spi/c/b34c325539ca

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark