[RESEND PATCH 0/5] kthread: remove worker->task self-assignment

Bradley Morgan posted 5 patches 4 weeks ago
Only 4 patches received!
There is a newer version of this series
drivers/media/pci/ivtv/ivtv-driver.c    | 11 ++++-------
drivers/media/pci/ivtv/ivtv-driver.h    |  3 +--
drivers/net/ethernet/microchip/encx24j600.c | 12 ++++--------
drivers/tty/serial/sc16is7xx.c        | 17 +++++++----------
kernel/sched/cpufreq_schedutil.c       | 14 +++++--------
kernel/kthread.c                      |  7 -------
6 files changed, 21 insertions(+), 63 deletions(-)
[RESEND PATCH 0/5] kthread: remove worker->task self-assignment
Posted by Bradley Morgan 4 weeks ago
From: Bradley Morgan <brads@mainlining.org>

Resent as a proper series with cover letter. The first send went out as
five separate threads instead of one.

kthread_worker_fn() has carried a FIXME for a decade: it assigns
worker->task = current because the old kthread_run(kthread_worker_fn)
callers never told the worker what task it was. The new
kthread_create_worker*() API sets worker->task before the worker even
starts, so the self-assignment is dead code.

Four drivers were still on the old API. Convert them, then remove the
FIXME.

No functional change intended.

Bradley Morgan (5):
  media: ivtv: convert to kthread_run_worker
  net: encx24j600: convert to kthread_run_worker
  tty: sc16is7xx: convert to kthread_run_worker
  cpufreq: schedutil: convert to kthread_create_worker
  kthread: remove worker->task self-assignment

 drivers/media/pci/ivtv/ivtv-driver.c    | 11 ++++-------
 drivers/media/pci/ivtv/ivtv-driver.h    |  3 +--
 drivers/net/ethernet/microchip/encx24j600.c | 12 ++++--------
 drivers/tty/serial/sc16is7xx.c        | 17 +++++++----------
 kernel/sched/cpufreq_schedutil.c       | 14 +++++--------
 kernel/kthread.c                      |  7 -------
 6 files changed, 21 insertions(+), 63 deletions(-)