#syz test: upstream 818bebeb63dd
diff --git a/sound/core/control_led.c b/sound/core/control_led.c
index 8cbacee57ce7..f6a46ed97d37 100644
--- a/sound/core/control_led.c
+++ b/sound/core/control_led.c
@@ -114,13 +114,11 @@ static int snd_ctl_led_get(struct snd_ctl_led_ctl *lctl)
info.id = kctl->id;
info.id.index += lctl->index_offset;
info.id.numid += lctl->index_offset;
- result = kctl->info(kctl, &info);
- if (result < 0)
+ if (!kctl->info || kctl->info(kctl, &info)
return -1;
memset(&value, 0, sizeof(value));
value.id = info.id;
- result = kctl->get(kctl, &value);
- if (result < 0)
+ if (!kctl->get || kctl->get(kctl, &value))
return -1;
if (info.type == SNDRV_CTL_ELEM_TYPE_BOOLEAN ||
info.type == SNDRV_CTL_ELEM_TYPE_INTEGER) {
Hello, syzbot tried to test the proposed patch but the build/boot failed: sound/core/control_led.c:117:50: error: expected ')' before 'return' sound/core/control_led.c:134:1: error: expected expression before '}' token sound/core/control_led.c:134:1: error: no return statement in function returning non-void [-Werror=return-type] Tested on: commit: 818bebeb drm/xe: Don't hand out the flat CCS storage a.. git tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git kernel config: https://syzkaller.appspot.com/x/.config?x=ccca94d2c01b9e78 dashboard link: https://syzkaller.appspot.com/bug?extid=b7fe2760ea6f1ee44b4d compiler: gcc (Debian 14.2.0-19) 14.2.0, GNU ld (GNU Binutils for Debian) 2.44 patch: https://syzkaller.appspot.com/x/patch.diff?x=11abd579580000
© 2016 - 2026 Red Hat, Inc.