mm: remove unused anon_vma_trylock_write()

[PATCH] mm: remove unused anon_vma_trylock_write()

Posted by Hao Li 1 month ago

The last user of anon_vma_trylock_write() was removed by cc22b9978509,
leaving the helper unused. Remove it.

Signed-off-by: Hao Li <hao.li@linux.dev>
---
 mm/internal.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/mm/internal.h b/mm/internal.h
index 68db5abd0a4c..9069013d191f 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -298,11 +298,6 @@ static inline void anon_vma_lock_write(struct anon_vma *anon_vma)
 	down_write(&anon_vma->root->rwsem);
 }
 
-static inline int anon_vma_trylock_write(struct anon_vma *anon_vma)
-{
-	return down_write_trylock(&anon_vma->root->rwsem);
-}
-
 static inline void anon_vma_unlock_write(struct anon_vma *anon_vma)
 {
 	up_write(&anon_vma->root->rwsem);
-- 
2.54.0

Re: [PATCH] mm: remove unused anon_vma_trylock_write()

Posted by SJ Park 4 weeks, 1 day ago

On Thu, 27 Aug 2026 15:18:06 +0800 Hao Li <hao.li@linux.dev> wrote:

> The last user of anon_vma_trylock_write() was removed by cc22b9978509,
> leaving the helper unused. Remove it.

Nice catch.

> 
> Signed-off-by: Hao Li <hao.li@linux.dev>

Reviewed-by: SJ Park <sj@kernel.org>


Thanks,
SJ

[...]

Re: [PATCH] mm: remove unused anon_vma_trylock_write()

Posted by David Hildenbrand (Arm) 1 month ago

On 8/27/26 09:18, Hao Li wrote:
> The last user of anon_vma_trylock_write() was removed by cc22b9978509,
> leaving the helper unused. Remove it.
> 
> Signed-off-by: Hao Li <hao.li@linux.dev>
> ---

Acked-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David

Re: [PATCH] mm: remove unused anon_vma_trylock_write()

Posted by Lorenzo Stoakes (ARM) 1 month ago

On Thu, Aug 27, 2026 at 03:18:06PM +0800, Hao Li wrote:
> The last user of anon_vma_trylock_write() was removed by cc22b9978509,
> leaving the helper unused. Remove it.
>
> Signed-off-by: Hao Li <hao.li@linux.dev>

LGTM so:

Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>

> ---
>  mm/internal.h | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/mm/internal.h b/mm/internal.h
> index 68db5abd0a4c..9069013d191f 100644
> --- a/mm/internal.h
> +++ b/mm/internal.h
> @@ -298,11 +298,6 @@ static inline void anon_vma_lock_write(struct anon_vma *anon_vma)
>  	down_write(&anon_vma->root->rwsem);
>  }
>
> -static inline int anon_vma_trylock_write(struct anon_vma *anon_vma)
> -{
> -	return down_write_trylock(&anon_vma->root->rwsem);
> -}
> -
>  static inline void anon_vma_unlock_write(struct anon_vma *anon_vma)
>  {
>  	up_write(&anon_vma->root->rwsem);
> --
> 2.54.0
>

--
Cheers, Lorenzo