[PATCH v3 0/2] selftests/cgroup: fixes for test_zswap on single core VM

Wilson Felipe Pereira posted 2 patches 1 month ago
There is a newer version of this series
tools/testing/selftests/cgroup/test_zswap.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
[PATCH v3 0/2] selftests/cgroup: fixes for test_zswap on single core VM
Posted by Wilson Felipe Pereira 1 month ago
This series fixes two test failures in test_zswap observed when running on
a single-core VM (-smp 1) with 4GB of RAM.

Patch 1 addresses a race condition in test_zswap_writeback() where
waitpid() returns before the exiting child process is switched away by the
kernel, causing an immediate write of "+memory" to cgroup.subtree_control
to fail with -EBUSY. We fix this by waiting for cgroup.events to report
"populated 0".

Patch 2 fixes an implicit unsigned conversion bug in test_no_kmem_bypass()
where small negative timing differences between debugfs stored_pages and
cgroup zswapped bytes caused the comparison to falsely fail due to
unsigned promotion.

v2 -> v3:
- Patch 1: Collect Acked-by from Michal Koutný.
- Patch 2: Explicitly cast stored_pages to (long) in delta calculation and
  inline the return comparison (Michal Koutný).

v1 -> v2:
- Patch 1: Replace EBUSY retry loop with cg_read_strcmp_wait() waiting for
  cgroup.events "populated 0" (Michal Koutný).
- Patch 1: Clarify task lifecycle in commit description (Yosry Ahmed).
- Patch 2: Remove abs() and declare delta/zswapped as signed longs with a
  signed threshold comparison (Michal Koutný).
- Patch 2: Add Fixes tag (Michal Koutný).

v2: https://lore.kernel.org/all/20260824033533.2147900-1-wfelipe@google.com/
v1: https://lore.kernel.org/all/20260804042053.56940-1-wfelipe@google.com/

Wilson Felipe Pereira (2):
  selftests/cgroup: test_zswap: wait for cgroup to unpopulate in
    test_zswap_writeback
  selftests/cgroup: test_zswap: fix implicit unsigned promotion bug in
    test_no_kmem_bypass

 tools/testing/selftests/cgroup/test_zswap.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

-- 
2.55.0.887.g758fc8c411-goog
Re: [PATCH v3 0/2] selftests/cgroup: fixes for test_zswap on single core VM
Posted by Andrew Morton 1 month ago
On Thu, 27 Aug 2026 03:47:40 +0000 Wilson Felipe Pereira <wfelipe@google.com> wrote:

> This series fixes two test failures in test_zswap observed when running on
> a single-core VM (-smp 1) with 4GB of RAM.
> 
> Patch 1 addresses a race condition in test_zswap_writeback() where
> waitpid() returns before the exiting child process is switched away by the
> kernel, causing an immediate write of "+memory" to cgroup.subtree_control
> to fail with -EBUSY. We fix this by waiting for cgroup.events to report
> "populated 0".
> 
> Patch 2 fixes an implicit unsigned conversion bug in test_no_kmem_bypass()
> where small negative timing differences between debugfs stored_pages and
> cgroup zswapped bytes caused the comparison to falsely fail due to
> unsigned promotion.

Thanks.  Sashiko thinks there remain some
signedness/truncation/overflow issues in there:

	https://sashiko.dev/#/patchset/20260827034807.2822234-1-wfelipe@google.com