[PATCH] ASoC: amd: acp-config: add quirk for more ASUS FA401EA variants

Shengyu Qu posted 1 patch 1 month ago
sound/soc/amd/acp-config.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
[PATCH] ASoC: amd: acp-config: add quirk for more ASUS FA401EA variants
Posted by Shengyu Qu 1 month ago
Existing quirks doesn't cover all known exising FA401EA devices, so add
more quirk items to cover them.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=221310#c49
Fixes: 27d090f3ccd4 ("ASoC: amd: acp: add ACP70 DMI override for new ASUS TUF platforms")
Signed-off-by: Shengyu Qu <wiagn@4d2.org>
---
 sound/soc/amd/acp-config.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
index 3021dc498c855..509f24a26ffe7 100644
--- a/sound/soc/amd/acp-config.c
+++ b/sound/soc/amd/acp-config.c
@@ -51,12 +51,24 @@ static const struct dmi_system_id acp70_acpi_flag_override_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "83V9"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "FA401EA"),
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
 			DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A14 FA401EA"),
 		},
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401EA"),
+		},
+	},
 	{
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
-- 
2.55.0
Re: [PATCH] ASoC: amd: acp-config: add quirk for more ASUS FA401EA variants
Posted by Mark Brown 1 month ago
On Wed, Aug 26, 2026 at 05:42:09PM +0800, Shengyu Qu wrote:
> Existing quirks doesn't cover all known exising FA401EA devices, so add
> more quirk items to cover them.

> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "FA401EA"),
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC"),
>  			DMI_MATCH(DMI_PRODUCT_NAME, "TUF Gaming A14 FA401EA"),
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "TX Air FA401EA"),
> +		},
> +	},

Do we need all these entries, DMI matches use substr() so I'd expect the
first entry to match on all the machines that the other two matches,
unless I'm misunderstanding somehow?