[PATCH v2 0/4] s390/vfio-ap: Fix pre-existing bugs in vfio_ap device driver

Anthony Krowiak posted 4 patches 1 month ago
There is a newer version of this series
drivers/s390/crypto/vfio_ap_ops.c | 55 +++++++++++++++++++++++++++----
1 file changed, 48 insertions(+), 7 deletions(-)
[PATCH v2 0/4] s390/vfio-ap: Fix pre-existing bugs in vfio_ap device driver
Posted by Anthony Krowiak 1 month ago
The sashiko AI reported several pre-existing bugs in the vfio_ap device
driver code while reviewing unrelated patches. This series fixes four
such bugs.

This series is based on the 'next' branch in the 
https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/linux.git
source tree.

Change log v1 => v2:
~~~~~~~~~~~~~~~~~~~
Patch 1/4: Fix leak of pinned NIB and registered NISC in 
           vfio_ap_irq_enable() 
* Removed call to pr_warn() in vfio_ap_irq_enable() for the default case
  in the switch statement to avoid flooding of the dmesg log. This was
  a pre-existing condition detected by sashiko and fixed here since it is
  in the code block changed by this patch. The VFIO_AP_DBF_WARN that occurs
  after the switch statement will display the error to the dbf log. 

Patch 3/4: Fix unbounded loop in apq_reset_check()
* Removed call to vfio_ap_free_aqic_resources() and provided a doc block
  explaining the rationale for allowing the leak of resources.

Patch 4/4: Use AP_DOMAINS for adm_add bitmap size in vfio_ap_mdev_cfg_add()
* Changed subject prefix to Use AP_DOMAINS for aqm/adm bitmap size
* Fixed two other locations where AP_DEVICES was used for the aqm/adm
  bitmap size.

Anthony Krowiak (4):
  s390/vfio-ap: Fix leak of pinned NIB and registered NISC in
    vfio_ap_irq_enable()
  s390/vfio-ap: Fix failure to release IRQ notification eventfd contexts
  s390/vfio-ap: Fix unbounded loop in apq_reset_check()
  s390/vfio-ap: Use AP_DOMAINS for adm_add bitmap size in
    vfio_ap_mdev_cfg_add()

 drivers/s390/crypto/vfio_ap_ops.c | 55 +++++++++++++++++++++++++++----
 1 file changed, 48 insertions(+), 7 deletions(-)

-- 
2.53.0