[PATCH] ALSA: aoa: i2sbus: Check IRQ before requesting it

phucduc.bui@gmail.com posted 1 patch 1 month ago
sound/aoa/soundbus/i2sbus/core.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] ALSA: aoa: i2sbus: Check IRQ before requesting it
Posted by phucduc.bui@gmail.com 1 month ago
From: bui duc phuc <phucduc.bui@gmail.com>

irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
The return value was passed to request_irq() without checking for
failure.

Check the return value before passing it to request_irq().

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/aoa/soundbus/i2sbus/core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c
index 833c44c0a950..adf123dd79a2 100644
--- a/sound/aoa/soundbus/i2sbus/core.c
+++ b/sound/aoa/soundbus/i2sbus/core.c
@@ -240,6 +240,8 @@ static int i2sbus_add_dev(struct macio_dev *macio,
 	}
 	for (i = aoa_resource_i2smmio; i <= aoa_resource_rxdbdma; i++) {
 		int irq = irq_of_parse_and_map(np, i);
+		if (!irq)
+			goto err;
 		if (request_irq(irq, ints[i], 0, dev->rnames[i], dev))
 			goto err;
 		dev->interrupts[i] = irq;
-- 
2.43.0
Re: [PATCH] ALSA: aoa: i2sbus: Check IRQ before requesting it
Posted by Takashi Iwai 1 month ago
On Mon, 24 Aug 2026 12:07:30 +0200,
phucduc.bui@gmail.com wrote:
> 
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
> The return value was passed to request_irq() without checking for
> failure.
> 
> Check the return value before passing it to request_irq().
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

Applied now.  Thanks.


Takashi