.../bindings/iio/adc/rockchip-saradc.yaml | 18 +++++++++--------- drivers/iio/adc/rockchip_saradc.c | 16 ++++++++++++++++ 2 files changed, 25 insertions(+), 9 deletions(-)
This series fixes the support for the RV1106 SAR-ADC in the
rockchip_saradc driver and its device tree bindings.
Changes in v2:
- Combined the driver patch and the dt-binding fix into a series, as
requested by Jonathan.
- Introduced a new patch (2/3) to group single-entries into an enum list,
as suggested by Krzysztof.
- Added missing Suggested-by tag to the patch 3/3
- rockchip,rv1106-saradc compatible moved from the
single-entry to enum list in the patch 3/3
Vladislav Leonov (3):
iio: adc: rockchip_saradc: Add support for RV1106
dt-bindings: iio: adc: rockchip-saradc: Group single-entries into an
enum list
dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible
.../bindings/iio/adc/rockchip-saradc.yaml | 18 +++++++++---------
drivers/iio/adc/rockchip_saradc.c | 16 ++++++++++++++++
2 files changed, 25 insertions(+), 9 deletions(-)
--
2.47.3
On Sun, 23 Aug 2026 15:20:31 +0300 Vladislav Leonov <vlad@zlab.su> wrote: > This series fixes the support for the RV1106 SAR-ADC in the > rockchip_saradc driver and its device tree bindings. I debated how to apply this. Technically patch 3 is a fix, 2 is an enabler and 1 is also a fix, but one for something that we just effectively patched out from running in patch 3. So in the end I'm thinking take this the slow path for next cycle. Shout if anyone thinks this should go in during the -RCs and whether all 3 should do so or just patches 2 and 3 (leaving us without driver support for now). Applied to the testing branch of iio.git Thanks, Jonathan > > Changes in v2: > - Combined the driver patch and the dt-binding fix into a series, as > requested by Jonathan. > - Introduced a new patch (2/3) to group single-entries into an enum list, > as suggested by Krzysztof. > - Added missing Suggested-by tag to the patch 3/3 > - rockchip,rv1106-saradc compatible moved from the > single-entry to enum list in the patch 3/3 > > Vladislav Leonov (3): > iio: adc: rockchip_saradc: Add support for RV1106 > dt-bindings: iio: adc: rockchip-saradc: Group single-entries into an > enum list > dt-bindings: iio: adc: rockchip-saradc: Fix RV1106 compatible > > .../bindings/iio/adc/rockchip-saradc.yaml | 18 +++++++++--------- > drivers/iio/adc/rockchip_saradc.c | 16 ++++++++++++++++ > 2 files changed, 25 insertions(+), 9 deletions(-) >
Hi Jonathan,
Am Montag, 31. August 2026, 03:55:57 Mitteleuropäische Sommerzeit schrieb Jonathan Cameron:
> On Sun, 23 Aug 2026 15:20:31 +0300
> Vladislav Leonov <vlad@zlab.su> wrote:
>
> > This series fixes the support for the RV1106 SAR-ADC in the
> > rockchip_saradc driver and its device tree bindings.
>
> I debated how to apply this. Technically patch 3 is a fix, 2 is an enabler
> and 1 is also a fix, but one for something that we just effectively patched
> out from running in patch 3.
>
> So in the end I'm thinking take this the slow path for next cycle. Shout
> if anyone thinks this should go in during the -RCs and whether all 3
> should do so or just patches 2 and 3 (leaving us without driver support for
> now).
>
> Applied to the testing branch of iio.git
I guess I should shout then ;-) .
DT-Binding patches are sort of independent of the driver change and
are considered API which should not change after the fact.
Our DTs (but also ones possibly contained in firmware somewhere) are
validated against the binding and it seems the correct compartible goes
from
"rockchip,rv1106-saradc", " rockchip,rk3588-saradc"
to
"rockchip,rv1106-saradc"
As the fixed commit is part of 7.3-rc1, I guess it would be nice to
have patches 2+3 in 7.3 and patch 1 can wait for 7.4 .
We don't need the driver support (dt-nodes just doesn't bind to
anything), but it would be nice to not proliferate the wrong binding in
an actual release.
my 2ct :-)
Heiko
On Mon, 31 Aug 2026 10:17:17 +0200 Heiko Stübner <heiko@sntech.de> wrote: > Hi Jonathan, > > Am Montag, 31. August 2026, 03:55:57 Mitteleuropäische Sommerzeit schrieb Jonathan Cameron: > > On Sun, 23 Aug 2026 15:20:31 +0300 > > Vladislav Leonov <vlad@zlab.su> wrote: > > > > > This series fixes the support for the RV1106 SAR-ADC in the > > > rockchip_saradc driver and its device tree bindings. > > > > I debated how to apply this. Technically patch 3 is a fix, 2 is an enabler > > and 1 is also a fix, but one for something that we just effectively patched > > out from running in patch 3. > > > > So in the end I'm thinking take this the slow path for next cycle. Shout > > if anyone thinks this should go in during the -RCs and whether all 3 > > should do so or just patches 2 and 3 (leaving us without driver support for > > now). > > > > Applied to the testing branch of iio.git > > I guess I should shout then ;-) . > > DT-Binding patches are sort of independent of the driver change and > are considered API which should not change after the fact. > > Our DTs (but also ones possibly contained in firmware somewhere) are > validated against the binding and it seems the correct compartible goes > from > "rockchip,rv1106-saradc", " rockchip,rk3588-saradc" > to > "rockchip,rv1106-saradc" > > As the fixed commit is part of 7.3-rc1, I guess it would be nice to > have patches 2+3 in 7.3 and patch 1 can wait for 7.4 . > > We don't need the driver support (dt-nodes just doesn't bind to > anything), but it would be nice to not proliferate the wrong binding in > an actual release. Ah. I should have checked when the original bug went in. As it's this current cycle, what you say is indeed an easy fix. Applied 2-3 to the fixes-togreg branch and left 1 in the testing branch for 7.4. Thanks Jonathan > > > my 2ct :-) > Heiko > > >
© 2016 - 2026 Red Hat, Inc.