[PATCH] staging: rtl8723bs: use usleep_range() instead of msleep()

Luka Miletic posted 1 patch 1 month ago
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] staging: rtl8723bs: use usleep_range() instead of msleep()
Posted by Luka Miletic 1 month ago
Use usleep_range() instead of msleep() to fix checkpatch warnings.
Verified both loops exit on their own condition, independent of
sleep duration, so this only changes timing precision, not behavior.

Signed-off-by: Luka Miletic <mileticluka2001@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index c15056ee2..8b793680f 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -986,7 +986,7 @@ void rtw_dev_unload(struct adapter *padapter)
 			if (cnt > 5)
 				break;
 			cnt++;
-			msleep(10);
+			usleep_range(10000, 20000);
 		}
 
 		/* check the status of IPS */
@@ -1086,7 +1086,7 @@ void rtw_suspend_common(struct adapter *padapter)
 	pwrpriv->bInSuspend = true;
 
 	while (pwrpriv->bips_processing)
-		msleep(1);
+		usleep_range(1000, 2000);
 
 	if ((!padapter->bup) || (padapter->driver_stopped) || (padapter->bSurpriseRemoved))
 		return;
-- 
2.34.1
Re: [PATCH] staging: rtl8723bs: use usleep_range() instead of msleep()
Posted by Greg Kroah-Hartman 3 weeks, 6 days ago
On Sat, Aug 22, 2026 at 11:54:26PM +0300, Luka Miletic wrote:
> Use usleep_range() instead of msleep() to fix checkpatch warnings.
> Verified both loops exit on their own condition, independent of
> sleep duration, so this only changes timing precision, not behavior.
> 
> Signed-off-by: Luka Miletic <mileticluka2001@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> index c15056ee2..8b793680f 100644
> --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
> @@ -986,7 +986,7 @@ void rtw_dev_unload(struct adapter *padapter)
>  			if (cnt > 5)
>  				break;
>  			cnt++;
> -			msleep(10);
> +			usleep_range(10000, 20000);

Please see the mailing list archives for why we can't take this change.

sorry,

greg k-h