1. Patchew
  2. linux
  3. View series

[PATCH] docs: iio: Correct ADXL380 filter descriptions

Karl Mehltretter posted 1 patch 1 month, 1 week ago 
Documentation/iio/adxl380.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH] docs: iio: Correct ADXL380 filter descriptions
Posted by Karl Mehltretter 1 month, 1 week ago 
The high-pass attributes were described as low-pass filters and vice
versa. Correct all four descriptions.

Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
Assisted-by: Codex:gpt-5.6-sol
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
 Documentation/iio/adxl380.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
index 654d4c0e84a19..a1c249dc2e51c 100644
--- a/Documentation/iio/adxl380.rst
+++ b/Documentation/iio/adxl380.rst
@@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
 +---------------------------------------------------+----------------------------------------------------------+
 | in_accel_scale                                    | Scale for the accelerometer channels.                    |
 +---------------------------------------------------+----------------------------------------------------------+
-| in_accel_filter_high_pass_3db_frequency           | Low pass filter bandwidth.                               |
+| in_accel_filter_high_pass_3db_frequency           | High pass filter bandwidth.                              |
 +---------------------------------------------------+----------------------------------------------------------+
-| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations.      |
+| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations.     |
 +---------------------------------------------------+----------------------------------------------------------+
-| in_accel_filter_low_pass_3db_frequency            | High pass filter bandwidth.                              |
+| in_accel_filter_low_pass_3db_frequency            | Low pass filter bandwidth.                               |
 +---------------------------------------------------+----------------------------------------------------------+
-| in_accel_filter_low_pass_3db_frequency_available  | Available high pass filter bandwidth configurations.     |
+| in_accel_filter_low_pass_3db_frequency_available  | Available low pass filter bandwidth configurations.      |
 +---------------------------------------------------+----------------------------------------------------------+
 | in_accel_x_calibbias                              | Calibration offset for the X-axis accelerometer channel. |
 +---------------------------------------------------+----------------------------------------------------------+
-- 
2.53.0
Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
Posted by Randy Dunlap 1 month ago 
Hi,

On 8/22/26 12:36 AM, Karl Mehltretter wrote:
> The high-pass attributes were described as low-pass filters and vice
> versa. Correct all four descriptions.
> 
> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
> Assisted-by: Codex:gpt-5.6-sol
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  Documentation/iio/adxl380.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
> index 654d4c0e84a19..a1c249dc2e51c 100644
> --- a/Documentation/iio/adxl380.rst
> +++ b/Documentation/iio/adxl380.rst
> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
>  +---------------------------------------------------+----------------------------------------------------------+
>  | in_accel_scale                                    | Scale for the accelerometer channels.                    |
>  +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_high_pass_3db_frequency           | Low pass filter bandwidth.                               |
> +| in_accel_filter_high_pass_3db_frequency           | High pass filter bandwidth.                              |
>  +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations.      |
> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations.     |
>  +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_low_pass_3db_frequency            | High pass filter bandwidth.                              |
> +| in_accel_filter_low_pass_3db_frequency            | Low pass filter bandwidth.                               |
>  +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_low_pass_3db_frequency_available  | Available high pass filter bandwidth configurations.     |
> +| in_accel_filter_low_pass_3db_frequency_available  | Available low pass filter bandwidth configurations.      |
>  +---------------------------------------------------+----------------------------------------------------------+
>  | in_accel_x_calibbias                              | Calibration offset for the X-axis accelerometer channel. |
>  +---------------------------------------------------+----------------------------------------------------------+

These changes LGTM. Thanks.

Although I am a bit confused. When I look at the adxl380 driver,
I don't see any of these device attributes.
The attributes with these names are in other drivers/iio/accel/
drivers: bma180.c, mma8452.c, and sca3000.c
Can someone try to explain this, please?
thanks.

-- 
~Randy
Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
Posted by David Lechner 1 month ago 
On 8/22/26 12:00 PM, Randy Dunlap wrote:
> Hi,
> 
> On 8/22/26 12:36 AM, Karl Mehltretter wrote:
>> The high-pass attributes were described as low-pass filters and vice
>> versa. Correct all four descriptions.
>>
>> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
>> Assisted-by: Codex:gpt-5.6-sol
>> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
>> ---
>>  Documentation/iio/adxl380.rst | 8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
>> index 654d4c0e84a19..a1c249dc2e51c 100644
>> --- a/Documentation/iio/adxl380.rst
>> +++ b/Documentation/iio/adxl380.rst
>> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
>>  +---------------------------------------------------+----------------------------------------------------------+
>>  | in_accel_scale                                    | Scale for the accelerometer channels.                    |
>>  +---------------------------------------------------+----------------------------------------------------------+
>> -| in_accel_filter_high_pass_3db_frequency           | Low pass filter bandwidth.                               |
>> +| in_accel_filter_high_pass_3db_frequency           | High pass filter bandwidth.                              |
>>  +---------------------------------------------------+----------------------------------------------------------+
>> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations.      |
>> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations.     |
>>  +---------------------------------------------------+----------------------------------------------------------+
>> -| in_accel_filter_low_pass_3db_frequency            | High pass filter bandwidth.                              |
>> +| in_accel_filter_low_pass_3db_frequency            | Low pass filter bandwidth.                               |
>>  +---------------------------------------------------+----------------------------------------------------------+
>> -| in_accel_filter_low_pass_3db_frequency_available  | Available high pass filter bandwidth configurations.     |
>> +| in_accel_filter_low_pass_3db_frequency_available  | Available low pass filter bandwidth configurations.      |
>>  +---------------------------------------------------+----------------------------------------------------------+
>>  | in_accel_x_calibbias                              | Calibration offset for the X-axis accelerometer channel. |
>>  +---------------------------------------------------+----------------------------------------------------------+
> 
> These changes LGTM. Thanks.
> 
> Although I am a bit confused. When I look at the adxl380 driver,
> I don't see any of these device attributes.
> The attributes with these names are in other drivers/iio/accel/
> drivers: bma180.c, mma8452.c, and sca3000.c
> Can someone try to explain this, please?
> thanks.
> 

The attributes come from:

	.info_mask_shared_by_type =					\
		BIT(IIO_CHAN_INFO_SCALE) |				\
		BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) |	\
		BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY),	\
	.info_mask_shared_by_type_available =				\
		BIT(IIO_CHAN_INFO_SCALE) |				\
		BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) |	\
		BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY),	\

in adxl380.c
Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
Posted by Randy Dunlap 1 month ago 

On 8/22/26 11:07 AM, David Lechner wrote:
> On 8/22/26 12:00 PM, Randy Dunlap wrote:
>> Hi,
>>
>> On 8/22/26 12:36 AM, Karl Mehltretter wrote:
>>> The high-pass attributes were described as low-pass filters and vice
>>> versa. Correct all four descriptions.
>>>
>>> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
>>> Assisted-by: Codex:gpt-5.6-sol
>>> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
>>> ---
>>>  Documentation/iio/adxl380.rst | 8 ++++----
>>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
>>> index 654d4c0e84a19..a1c249dc2e51c 100644
>>> --- a/Documentation/iio/adxl380.rst
>>> +++ b/Documentation/iio/adxl380.rst
>>> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
>>>  +---------------------------------------------------+----------------------------------------------------------+
>>>  | in_accel_scale                                    | Scale for the accelerometer channels.                    |
>>>  +---------------------------------------------------+----------------------------------------------------------+
>>> -| in_accel_filter_high_pass_3db_frequency           | Low pass filter bandwidth.                               |
>>> +| in_accel_filter_high_pass_3db_frequency           | High pass filter bandwidth.                              |
>>>  +---------------------------------------------------+----------------------------------------------------------+
>>> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations.      |
>>> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations.     |
>>>  +---------------------------------------------------+----------------------------------------------------------+
>>> -| in_accel_filter_low_pass_3db_frequency            | High pass filter bandwidth.                              |
>>> +| in_accel_filter_low_pass_3db_frequency            | Low pass filter bandwidth.                               |
>>>  +---------------------------------------------------+----------------------------------------------------------+
>>> -| in_accel_filter_low_pass_3db_frequency_available  | Available high pass filter bandwidth configurations.     |
>>> +| in_accel_filter_low_pass_3db_frequency_available  | Available low pass filter bandwidth configurations.      |
>>>  +---------------------------------------------------+----------------------------------------------------------+
>>>  | in_accel_x_calibbias                              | Calibration offset for the X-axis accelerometer channel. |
>>>  +---------------------------------------------------+----------------------------------------------------------+
>>
>> These changes LGTM. Thanks.
>>
>> Although I am a bit confused. When I look at the adxl380 driver,
>> I don't see any of these device attributes.
>> The attributes with these names are in other drivers/iio/accel/
>> drivers: bma180.c, mma8452.c, and sca3000.c
>> Can someone try to explain this, please?
>> thanks.
>>
> 
> The attributes come from:
> 
> 	.info_mask_shared_by_type =					\
> 		BIT(IIO_CHAN_INFO_SCALE) |				\
> 		BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) |	\
> 		BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY),	\
> 	.info_mask_shared_by_type_available =				\
> 		BIT(IIO_CHAN_INFO_SCALE) |				\
> 		BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) |	\
> 		BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY),	\
> 
> in adxl380.c

Thanks, David.

for the patch:
Acked-by: Randy Dunlap <rdunlap@infradead.org>

-- 
~Randy
Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
Posted by Jonathan Cameron 1 month ago 
On Sat, 22 Aug 2026 11:19:09 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:

> On 8/22/26 11:07 AM, David Lechner wrote:
> > On 8/22/26 12:00 PM, Randy Dunlap wrote:  
> >> Hi,
> >>
> >> On 8/22/26 12:36 AM, Karl Mehltretter wrote:  
> >>> The high-pass attributes were described as low-pass filters and vice
> >>> versa. Correct all four descriptions.
> >>>
> >>> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
> >>> Assisted-by: Codex:gpt-5.6-sol
> >>> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> >>> ---
> >>>  Documentation/iio/adxl380.rst | 8 ++++----
> >>>  1 file changed, 4 insertions(+), 4 deletions(-)
> >>>
> >>> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
> >>> index 654d4c0e84a19..a1c249dc2e51c 100644
> >>> --- a/Documentation/iio/adxl380.rst
> >>> +++ b/Documentation/iio/adxl380.rst
> >>> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
> >>>  +---------------------------------------------------+----------------------------------------------------------+
> >>>  | in_accel_scale                                    | Scale for the accelerometer channels.                    |
> >>>  +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_high_pass_3db_frequency           | Low pass filter bandwidth.                               |
> >>> +| in_accel_filter_high_pass_3db_frequency           | High pass filter bandwidth.                              |
> >>>  +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations.      |
> >>> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations.     |
> >>>  +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_low_pass_3db_frequency            | High pass filter bandwidth.                              |
> >>> +| in_accel_filter_low_pass_3db_frequency            | Low pass filter bandwidth.                               |
> >>>  +---------------------------------------------------+----------------------------------------------------------+
> >>> -| in_accel_filter_low_pass_3db_frequency_available  | Available high pass filter bandwidth configurations.     |
> >>> +| in_accel_filter_low_pass_3db_frequency_available  | Available low pass filter bandwidth configurations.      |
> >>>  +---------------------------------------------------+----------------------------------------------------------+
> >>>  | in_accel_x_calibbias                              | Calibration offset for the X-axis accelerometer channel. |
> >>>  +---------------------------------------------------+----------------------------------------------------------+  
> >>
> >> These changes LGTM. Thanks.
> >>
> >> Although I am a bit confused. When I look at the adxl380 driver,
> >> I don't see any of these device attributes.
> >> The attributes with these names are in other drivers/iio/accel/
> >> drivers: bma180.c, mma8452.c, and sca3000.c
> >> Can someone try to explain this, please?
> >> thanks.
> >>  
> > 
> > The attributes come from:
> > 
> > 	.info_mask_shared_by_type =					\
> > 		BIT(IIO_CHAN_INFO_SCALE) |				\
> > 		BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) |	\
> > 		BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY),	\
> > 	.info_mask_shared_by_type_available =				\
> > 		BIT(IIO_CHAN_INFO_SCALE) |				\
> > 		BIT(IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY) |	\
> > 		BIT(IIO_CHAN_INFO_HIGH_PASS_FILTER_3DB_FREQUENCY),	\
> > 
> > in adxl380.c  
> 
> Thanks, David.
> 
> for the patch:
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
Applied to the testing branch of iio.git.

That will get rebased on rc1 once available.

Thanks,

Jonathan
Re: [PATCH] docs: iio: Correct ADXL380 filter descriptions
Posted by Joshua Crofts 1 month, 1 week ago 
On Sat, 22 Aug 2026 09:36:53 +0200
Karl Mehltretter <kmehltretter@gmail.com> wrote:

> The high-pass attributes were described as low-pass filters and vice
> versa. Correct all four descriptions.
> 
> Fixes: b6a097a9af00 ("docs: iio: add documentation for adxl380 driver")
> Assisted-by: Codex:gpt-5.6-sol
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  Documentation/iio/adxl380.rst | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/iio/adxl380.rst b/Documentation/iio/adxl380.rst
> index 654d4c0e84a19..a1c249dc2e51c 100644
> --- a/Documentation/iio/adxl380.rst
> +++ b/Documentation/iio/adxl380.rst
> @@ -39,13 +39,13 @@ specific device folder path ``/sys/bus/iio/devices/iio:deviceX``.
>  +---------------------------------------------------+----------------------------------------------------------+
>  | in_accel_scale                                    | Scale for the accelerometer channels.                    |
>  +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_high_pass_3db_frequency           | Low pass filter bandwidth.                               |
> +| in_accel_filter_high_pass_3db_frequency           | High pass filter bandwidth.                              |
>  +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_high_pass_3db_frequency_available | Available low pass filter bandwidth configurations.      |
> +| in_accel_filter_high_pass_3db_frequency_available | Available high pass filter bandwidth configurations.     |
>  +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_low_pass_3db_frequency            | High pass filter bandwidth.                              |
> +| in_accel_filter_low_pass_3db_frequency            | Low pass filter bandwidth.                               |
>  +---------------------------------------------------+----------------------------------------------------------+
> -| in_accel_filter_low_pass_3db_frequency_available  | Available high pass filter bandwidth configurations.     |
> +| in_accel_filter_low_pass_3db_frequency_available  | Available low pass filter bandwidth configurations.      |
>  +---------------------------------------------------+----------------------------------------------------------+
>  | in_accel_x_calibbias                              | Calibration offset for the X-axis accelerometer channel. |
>  +---------------------------------------------------+----------------------------------------------------------+

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>

-- 
Kind regards,
Joshua Crofts

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.