[PATCH] staging: rtl8723bs: modify misleading comment

Omer El Idrissi posted 1 patch 1 month, 1 week ago
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] staging: rtl8723bs: modify misleading comment
Posted by Omer El Idrissi 1 month, 1 week ago
The comment suggests that rtw_unregister_cmd_alive is called
by the ISR, while it's called by function rtw_cmd_thread which runs in
the kernel thread context.

Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index b9f8cf1014ed..a4831dc145eb 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -891,7 +891,7 @@ void rtw_unregister_tx_alive(struct adapter *padapter)
 }
 
 /*
- * Caller: ISR
+ * Caller: not ISR
  *
  * If all commands have been done,
  * and no more command to do,
-- 
2.53.0
Re: [PATCH] staging: rtl8723bs: modify misleading comment
Posted by Dan Carpenter 1 month, 1 week ago
On Fri, Aug 21, 2026 at 09:58:23PM +0200, Omer El Idrissi wrote:
> The comment suggests that rtw_unregister_cmd_alive is called
> by the ISR, while it's called by function rtw_cmd_thread which runs in
> the kernel thread context.
> 
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index b9f8cf1014ed..a4831dc145eb 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -891,7 +891,7 @@ void rtw_unregister_tx_alive(struct adapter *padapter)
>  }
>  
>  /*
> - * Caller: ISR
> + * Caller: not ISR

The original comment is obviously wrong, and that's bad.  But is "not ISR"
useful?  Probably we might as well just delete the comment.  It's not
like people don't have ctags.

regards,
dan carpenter