ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__

[PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__

Posted by Thomas Huth 1 month, 1 week ago

While the GCC and Clang compilers already define __ASSEMBLER__ auto-
matically when compiling assembly code, __ASSEMBLY__ is a macro that
only gets defined by the Makefiles in the kernel. This can be very
confusing when switching between userspace and kernelspace coding, or
when dealing with uapi headers that rather should use __ASSEMBLER__
instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
this confusion.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 Note: This has been split from an earlier bigger patch of mine into
       a separate patch to ease reviewing

 arch/arm/mach-at91/pm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
index 50c3a425d1400..2193e1ab98476 100644
--- a/arch/arm/mach-at91/pm.h
+++ b/arch/arm/mach-at91/pm.h
@@ -25,7 +25,7 @@
 #define AT91_PM_ULP1		0x03
 #define	AT91_PM_BACKUP		0x04
 
-#ifndef __ASSEMBLY__
+#ifndef __ASSEMBLER__
 struct at91_pm_data {
 	void __iomem *pmc;
 	void __iomem *ramc[2];
-- 
2.55.0

Re: [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__

Posted by Claudiu Beznea 5 hours ago

On Fri, Aug 21, 2026 at 10:36:45AM +0200, Thomas Huth wrote:
> While the GCC and Clang compilers already define __ASSEMBLER__ auto-
> matically when compiling assembly code, __ASSEMBLY__ is a macro that
> only gets defined by the Makefiles in the kernel. This can be very
> confusing when switching between userspace and kernelspace coding, or
> when dealing with uapi headers that rather should use __ASSEMBLER__
> instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
> this confusion.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Applied to at91-soc, thanks!

Re: [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__

Posted by claudiu beznea 1 week, 1 day ago


On 8/21/26 11:36, Thomas Huth wrote:
> While the GCC and Clang compilers already define __ASSEMBLER__ auto-
> matically when compiling assembly code, __ASSEMBLY__ is a macro that
> only gets defined by the Makefiles in the kernel. This can be very
> confusing when switching between userspace and kernelspace coding, or
> when dealing with uapi headers that rather should use __ASSEMBLER__
> instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
> this confusion.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>

Re: [PATCH] ARM: at91: Replace __ASSEMBLY__ with __ASSEMBLER__

Posted by Alexandre Belloni 1 week, 3 days ago

On 21/08/2026 10:36:45+0200, Thomas Huth wrote:
> While the GCC and Clang compilers already define __ASSEMBLER__ auto-
> matically when compiling assembly code, __ASSEMBLY__ is a macro that
> only gets defined by the Makefiles in the kernel. This can be very
> confusing when switching between userspace and kernelspace coding, or
> when dealing with uapi headers that rather should use __ASSEMBLER__
> instead. Let's standardize now on the __ASSEMBLER__ macro to avoid
> this confusion.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> ---
>  Note: This has been split from an earlier bigger patch of mine into
>        a separate patch to ease reviewing
> 
>  arch/arm/mach-at91/pm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 50c3a425d1400..2193e1ab98476 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -25,7 +25,7 @@
>  #define AT91_PM_ULP1		0x03
>  #define	AT91_PM_BACKUP		0x04
>  
> -#ifndef __ASSEMBLY__
> +#ifndef __ASSEMBLER__
>  struct at91_pm_data {
>  	void __iomem *pmc;
>  	void __iomem *ramc[2];
> -- 
> 2.55.0
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com