tools/testing/selftests/net/fin_ack_lat.c | 5 +++- tools/testing/selftests/net/fin_ack_lat.sh | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-)
From: Qingshuang Fu <fuqingshuang@kylinos.cn> This series fixes two bugs in the fin_ack_lat self-test. Patch 1 fixes the swapped kill() arguments in sig_handler(), so the server actually forwards SIGTERM to the client. It also makes the wrapper script's cleanup tolerant of ESRCH, since the client may now exit before the kill command reaches its PID. Patch 2 adds a missing fork() error check: on failure the code falls into server()'s infinite accept loop, producing empty output that the wrapper script treats as a passing test. Qingshuang Fu (2): selftests/net: fix kill() argument order and wrapper cleanup in fin_ack_lat selftests/net: check fork() return value in fin_ack_lat tools/testing/selftests/net/fin_ack_lat.c | 5 +++- tools/testing/selftests/net/fin_ack_lat.sh | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) --- v1: https://lore.kernel.org/all/20260817091017.281104-1-fffsqian@163.com/ v2: - Split into two patches - Add shell cleanup tolerance for ESRCH per Sashiko-AI review - Add missing fork() error check per Sashiko-AI review -- 2.25.1
On Fri, Aug 21, 2026 at 11:09:20AM +0800, Qingshuang Fu wrote: > From: Qingshuang Fu <fuqingshuang@kylinos.cn> > > This series fixes two bugs in the fin_ack_lat self-test. > > Patch 1 fixes the swapped kill() arguments in sig_handler(), so the > server actually forwards SIGTERM to the client. It also makes the > wrapper script's cleanup tolerant of ESRCH, since the client may now > exit before the kill command reaches its PID. > > Patch 2 adds a missing fork() error check: on failure the code falls > into server()'s infinite accept loop, producing empty output that the > wrapper script treats as a passing test. > > Qingshuang Fu (2): > selftests/net: fix kill() argument order and wrapper cleanup in fin_ack_lat > selftests/net: check fork() return value in fin_ack_lat > > tools/testing/selftests/net/fin_ack_lat.c | 5 +++- > tools/testing/selftests/net/fin_ack_lat.sh | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > --- > v1: https://lore.kernel.org/all/20260817091017.281104-1-fffsqian@163.com/ > > v2: > - Split into two patches > - Add shell cleanup tolerance for ESRCH per Sashiko-AI review > - Add missing fork() error check per Sashiko-AI review Thanks for the updates. For the series: Reviewed-by: Simon Horman <horms@kernel.org>
On Fri, Aug 21, 2026 at 11:09:20AM +0800, Qingshuang Fu wrote: > From: Qingshuang Fu <fuqingshuang@kylinos.cn> > > This series fixes two bugs in the fin_ack_lat self-test. > > Patch 1 fixes the swapped kill() arguments in sig_handler(), so the > server actually forwards SIGTERM to the client. It also makes the > wrapper script's cleanup tolerant of ESRCH, since the client may now > exit before the kill command reaches its PID. > > Patch 2 adds a missing fork() error check: on failure the code falls > into server()'s infinite accept loop, producing empty output that the > wrapper script treats as a passing test. > > Qingshuang Fu (2): > selftests/net: fix kill() argument order and wrapper cleanup in fin_ack_lat > selftests/net: check fork() return value in fin_ack_lat > > tools/testing/selftests/net/fin_ack_lat.c | 5 +++- > tools/testing/selftests/net/fin_ack_lat.sh | 2 +- > 2 files changed, 5 insertions(+), 2 deletions(-) > --- > v1: https://lore.kernel.org/all/20260817091017.281104-1-fffsqian@163.com/ > > v2: > - Split into two patches > - Add shell cleanup tolerance for ESRCH per Sashiko-AI review > - Add missing fork() error check per Sashiko-AI review > -- > 2.25.1 > LGTM, for the series Reviewed-by: Hangbin Liu <liuhangbin@kylinos.cn>
© 2016 - 2026 Red Hat, Inc.