[v2] usb: xhci-pci: Add AMD 600 series to xhci-pci-prom21

[PATCH v2] usb: xhci-pci: Add AMD 600 series to xhci-pci-prom21

Posted by Stephen Horvath 1 month, 1 week ago

It seems the xhci-pci-prom21 module only has IDs for the 800 series
chipsets. However, the 600 series chipsets also have Promontory 21
chips, so we should add their IDs to the list as well.

I have tested this on my X670 board featuring DID `0x43f7`.

`1022:43f7` also appears on the PCI ID database
(https://pci-ids.ucw.cz/read/PC/1022/43f7).
Device IDs `0x43f9` (B665) & `0x43fa` (A620) were suggested by Shyam.

Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Jihong Min <hurryman2212@gmail.com>
Signed-off-by: Stephen Horvath <linux@stevetech.au>
---
Changes in v2:
- Added Device IDs `0x43f9` & `0x43fa`
- Link to v1: https://patch.msgid.link/20260818-xhci-pci-prom21-v1-1-6584857e654d@outlook.com.au
---
 drivers/usb/host/xhci-pci-prom21.c | 3 +++
 drivers/usb/host/xhci-pci.c        | 3 +++
 drivers/usb/host/xhci-pci.h        | 3 +++
 3 files changed, 9 insertions(+)

diff --git a/drivers/usb/host/xhci-pci-prom21.c b/drivers/usb/host/xhci-pci-prom21.c
index 6486f4a09345..5f088a47d79f 100644
--- a/drivers/usb/host/xhci-pci-prom21.c
+++ b/drivers/usb/host/xhci-pci-prom21.c
@@ -111,6 +111,9 @@ static void prom21_xhci_remove(struct pci_dev *dev)
 }
 
 static const struct pci_device_id pci_ids[] = {
+	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD) },
 	{ /* end: all zeroes */ }
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index a8889081ae82..b407676808fc 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -701,6 +701,9 @@ static const struct pci_device_id pci_ids_renesas[] = {
 
 /* handled by xhci-pci-prom21 if enabled */
 static const struct pci_device_id pci_ids_prom21[] = {
+	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD) },
 	{ /* end: all zeroes */ }
diff --git a/drivers/usb/host/xhci-pci.h b/drivers/usb/host/xhci-pci.h
index 11f435f94322..533efc7db801 100644
--- a/drivers/usb/host/xhci-pci.h
+++ b/drivers/usb/host/xhci-pci.h
@@ -4,6 +4,9 @@
 #ifndef XHCI_PCI_H
 #define XHCI_PCI_H
 
+#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7	0x43f7
+#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9	0x43f9
+#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA	0x43fa
 #define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC	0x43fc
 #define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD	0x43fd
 

---
base-commit: e1e6e541c5c9cf548e9fdc35fc26808c82074440
change-id: 20260818-xhci-pci-prom21-ceb025d484a8

Best regards,
--  
Stephen Horvath <linux@stevetech.au>

Re: [PATCH v2] usb: xhci-pci: Add AMD 600 series to xhci-pci-prom21

Posted by Jihong Min 1 month ago

Hi,

On 8/20/26 21:59, Stephen Horvath wrote:
> It seems the xhci-pci-prom21 module only has IDs for the 800 series
> chipsets. However, the 600 series chipsets also have Promontory 21
> chips, so we should add their IDs to the list as well.
> 
> I have tested this on my X670 board featuring DID `0x43f7`.
> 
> `1022:43f7` also appears on the PCI ID database
> (https://pci-ids.ucw.cz/read/PC/1022/43f7).
> Device IDs `0x43f9` (B665) & `0x43fa` (A620) were suggested by Shyam.

It would be nice to update all the newly added device IDs to the kernel
documentation as well.

> 
> Cc: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Cc: Jihong Min <hurryman2212@gmail.com>
> Signed-off-by: Stephen Horvath <linux@stevetech.au>
> ---
> Changes in v2:
> - Added Device IDs `0x43f9` & `0x43fa`
> - Link to v1: https://patch.msgid.link/20260818-xhci-pci-prom21-v1-1-6584857e654d@outlook.com.au
> ---
>  drivers/usb/host/xhci-pci-prom21.c | 3 +++
>  drivers/usb/host/xhci-pci.c        | 3 +++
>  drivers/usb/host/xhci-pci.h        | 3 +++
>  3 files changed, 9 insertions(+)
> 
> diff --git a/drivers/usb/host/xhci-pci-prom21.c b/drivers/usb/host/xhci-pci-prom21.c
> index 6486f4a09345..5f088a47d79f 100644
> --- a/drivers/usb/host/xhci-pci-prom21.c
> +++ b/drivers/usb/host/xhci-pci-prom21.c
> @@ -111,6 +111,9 @@ static void prom21_xhci_remove(struct pci_dev *dev)
>  }
>  
>  static const struct pci_device_id pci_ids[] = {
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD) },
>  	{ /* end: all zeroes */ }
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index a8889081ae82..b407676808fc 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -701,6 +701,9 @@ static const struct pci_device_id pci_ids_renesas[] = {
>  
>  /* handled by xhci-pci-prom21 if enabled */
>  static const struct pci_device_id pci_ids_prom21[] = {
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9) },
> +	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD) },
>  	{ /* end: all zeroes */ }
> diff --git a/drivers/usb/host/xhci-pci.h b/drivers/usb/host/xhci-pci.h
> index 11f435f94322..533efc7db801 100644
> --- a/drivers/usb/host/xhci-pci.h
> +++ b/drivers/usb/host/xhci-pci.h
> @@ -4,6 +4,9 @@
>  #ifndef XHCI_PCI_H
>  #define XHCI_PCI_H
>  
> +#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43F7	0x43f7
> +#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43F9	0x43f9
> +#define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FA	0x43fa
>  #define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FC	0x43fc
>  #define PCI_DEVICE_ID_AMD_PROM21_XHCI_43FD	0x43fd
>  
> 
> ---
> base-commit: e1e6e541c5c9cf548e9fdc35fc26808c82074440
> change-id: 20260818-xhci-pci-prom21-ceb025d484a8
> 
> Best regards,
> --  
> Stephen Horvath <linux@stevetech.au>
> 


Sincerely,
Jihong Min

Re: [PATCH v2] usb: xhci-pci: Add AMD 600 series to xhci-pci-prom21

Posted by Greg Kroah-Hartman 1 month ago

On Sun, Aug 23, 2026 at 09:23:42PM +0900, Jihong Min wrote:
> Hi,
> 
> On 8/20/26 21:59, Stephen Horvath wrote:
> > It seems the xhci-pci-prom21 module only has IDs for the 800 series
> > chipsets. However, the 600 series chipsets also have Promontory 21
> > chips, so we should add their IDs to the list as well.
> > 
> > I have tested this on my X670 board featuring DID `0x43f7`.
> > 
> > `1022:43f7` also appears on the PCI ID database
> > (https://pci-ids.ucw.cz/read/PC/1022/43f7).
> > Device IDs `0x43f9` (B665) & `0x43fa` (A620) were suggested by Shyam.
> 
> It would be nice to update all the newly added device IDs to the kernel
> documentation as well.

Documentation where exactly?

thanks,

greg k-h

Re: [PATCH v2] usb: xhci-pci: Add AMD 600 series to xhci-pci-prom21

Posted by Jihong Min 1 month ago

Hi,

On 8/23/26 21:25, Greg Kroah-Hartman wrote:
> On Sun, Aug 23, 2026 at 09:23:42PM +0900, Jihong Min wrote:
>> Hi,
>>
>> On 8/20/26 21:59, Stephen Horvath wrote:
>>> It seems the xhci-pci-prom21 module only has IDs for the 800 series
>>> chipsets. However, the 600 series chipsets also have Promontory 21
>>> chips, so we should add their IDs to the list as well.
>>>
>>> I have tested this on my X670 board featuring DID `0x43f7`.
>>>
>>> `1022:43f7` also appears on the PCI ID database
>>> (https://pci-ids.ucw.cz/read/PC/1022/43f7).
>>> Device IDs `0x43f9` (B665) & `0x43fa` (A620) were suggested by Shyam.
>>
>> It would be nice to update all the newly added device IDs to the kernel
>> documentation as well.
> 
> Documentation where exactly?

Initially, `Documentation/hwmon/prom21-xhci.rst` has added the following
line:

PCI IDs: 1022:43fc, 1022:43fd

It would be more appropriate to add these new IDs into the same line, or
just drop the deprecated document line.

> 
> thanks,
> 
> greg k-h

Sincerely,
Jihong Min