[v1] arm64: dts: qcom: shikra: Enable dTPM on EVK boards

[PATCH] arm64: dts: qcom: shikra: Enable dTPM on EVK boards

Posted by Khalid Faisal Ansari 1 month, 1 week ago

The Shikra EVK boards (CQM, CQS, IQS) carry an ST33 discrete TPM
connected via SPI5. Enable the SPI controller and add the TPM node
with the ST33HTPM compatible and a 20 MHz max clock.

Depends-on: https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
---
The Shikra EVK boards (CQM, CQS, IQS) have an ST33 discrete TPM (dTPM)
connected over SPI5. Enable the SPI controller and add the TPM node for
all three board variants.

This series depends on the SPI5 node addition in shikra-evk.dtsi:
  https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
---
 arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 10 ++++++++++
 arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 10 ++++++++++
 arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 10 ++++++++++
 3 files changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
index b112b21b1d79..32916e9df9d3 100644
--- a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
+++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts
@@ -57,3 +57,13 @@ &sdhc_1 {
 
 	status = "okay";
 };
+
+&spi5 {
+	status = "okay";
+
+	tpm@0 {
+		compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+		reg = <0>;
+		spi-max-frequency = <20000000>;
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
index e62ba5aef71f..bacdc7c77c2f 100644
--- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
+++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts
@@ -57,3 +57,13 @@ &sdhc_1 {
 
 	status = "okay";
 };
+
+&spi5 {
+	status = "okay";
+
+	tpm@0 {
+		compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+		reg = <0>;
+		spi-max-frequency = <20000000>;
+	};
+};
diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
index 727809430fd1..b42f94708bfd 100644
--- a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
+++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
@@ -57,3 +57,13 @@ &sdhc_1 {
 
 	status = "okay";
 };
+
+&spi5 {
+	status = "okay";
+
+	tpm@0 {
+		compatible = "st,st33htpm-spi", "tcg,tpm_tis-spi";
+		reg = <0>;
+		spi-max-frequency = <20000000>;
+	};
+};

---
base-commit: a4ff2be345d0abc943da8dd8da98151843b750dc
change-id: 20260820-shikra_dtpm-2bc494dd6756

Best regards,
-- 
Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: shikra: Enable dTPM on EVK boards

Posted by Abel Vesa 1 month, 1 week ago

On 26-08-20 14:46:07, Khalid Faisal Ansari wrote:
> The Shikra EVK boards (CQM, CQS, IQS) carry an ST33 discrete TPM
> connected via SPI5. Enable the SPI controller and add the TPM node
> with the ST33HTPM compatible and a 20 MHz max clock.
> 
> Depends-on: https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

Re: [PATCH] arm64: dts: qcom: shikra: Enable dTPM on EVK boards

Posted by Konrad Dybcio 1 month, 1 week ago

On 8/20/26 11:16 AM, Khalid Faisal Ansari wrote:
> The Shikra EVK boards (CQM, CQS, IQS) carry an ST33 discrete TPM
> connected via SPI5. Enable the SPI controller and add the TPM node
> with the ST33HTPM compatible and a 20 MHz max clock.
> 
> Depends-on: https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/

This is not a valid tag to put in the commit message

Why haven't you sent the two clearly interdependent patches together?

> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> ---
> The Shikra EVK boards (CQM, CQS, IQS) have an ST33 discrete TPM (dTPM)
> connected over SPI5. Enable the SPI controller and add the TPM node for
> all three board variants.
> 
> This series depends on the SPI5 node addition in shikra-evk.dtsi:
>   https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
> ---
>  arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 10 ++++++++++
>  arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 10 ++++++++++
>  arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 10 ++++++++++

Turn this into a single addition to shikra-evk.dtsi

Konrad

Re: [PATCH] arm64: dts: qcom: shikra: Enable dTPM on EVK boards

Posted by Khalid Faisal Ansari 1 month ago


On 8/20/2026 2:52 PM, Konrad Dybcio wrote:
> On 8/20/26 11:16 AM, Khalid Faisal Ansari wrote:
>> The Shikra EVK boards (CQM, CQS, IQS) carry an ST33 discrete TPM
>> connected via SPI5. Enable the SPI controller and add the TPM node
>> with the ST33HTPM compatible and a 20 MHz max clock.
>>
>> Depends-on: https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
> This is not a valid tag to put in the commit message
>
> Why haven't you sent the two clearly interdependent patches together?
I referenced the SPI5 enabling patch because the TPM node addition 
depends on that change
being present. I had followed a similar approach used in an  earlier 
submission
(https://lore.kernel.org/all/0afa55d5-20bf-487b-abe0-4e2126ccf453@oss.qualcomm.com/), 

where the dependency was mentioned in the commit message.

Since the two changes originate from different internal ownership areas 
but are functionally
interdependent, we have been handling them as separate submissions while 
documenting the
dependency between them.
>> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
>> ---
>> The Shikra EVK boards (CQM, CQS, IQS) have an ST33 discrete TPM (dTPM)
>> connected over SPI5. Enable the SPI controller and add the TPM node for
>> all three board variants.
>>
>> This series depends on the SPI5 node addition in shikra-evk.dtsi:
>>    https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
>> ---
>>   arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 10 ++++++++++
>>   arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 10 ++++++++++
>>   arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 10 ++++++++++
> Turn this into a single addition to shikra-evk.dtsi
I intentionally kept the changes in the individual board DTS files 
rather than placing
them in shikra-evk.dtsi.

While the current EVK variants (CQM, CQS, and IQS) all carry the ST33 
dTPM, a future
board could potentially reuse shikra-evk.dtsi without supporting the TPM 
hardware.
Keeping the node in the board-specific DTS files makes the hardware 
dependency
explicit and avoids enabling TPM on boards where it may not be present.
>
> Konrad

Re: [PATCH] arm64: dts: qcom: shikra: Enable dTPM on EVK boards

Posted by Khalid Faisal Ansari 1 month ago

On 8/20/2026 2:52 PM, Konrad Dybcio wrote:
> On 8/20/26 11:16 AM, Khalid Faisal Ansari wrote:
>> The Shikra EVK boards (CQM, CQS, IQS) carry an ST33 discrete TPM
>> connected via SPI5. Enable the SPI controller and add the TPM node
>> with the ST33HTPM compatible and a 20 MHz max clock.
>>
>> Depends-on: https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
> This is not a valid tag to put in the commit message
>
> Why haven't you sent the two clearly interdependent patches together?

I referenced the SPI5 enabling patch because the TPM node addition depends on that change being present. I had followed a similar approach used in an earlier submission (https://lore.kernel.org/all/0afa55d5-20bf-487b-abe0-4e2126ccf453@oss.qualcomm.com/), where the dependency was mentioned in the commit message.
Since the two changes originate from different internal ownership areas but are functionally interdependent, we have been handling them as separate submissions while documenting the dependency between them.

>> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
>> ---
>> The Shikra EVK boards (CQM, CQS, IQS) have an ST33 discrete TPM (dTPM)
>> connected over SPI5. Enable the SPI controller and add the TPM node for
>> all three board variants.
>>
>> This series depends on the SPI5 node addition in shikra-evk.dtsi:
>>    https://lore.kernel.org/all/20260820085347.822-1-xueyao.an@oss.qualcomm.com/
>> ---
>>   arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 10 ++++++++++
>>   arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 10 ++++++++++
>>   arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts | 10 ++++++++++
> Turn this into a single addition to shikra-evk.dtsi

I intentionally kept the changes in the individual board DTS files rather than placing them in shikra-evk.dtsi.
While the current EVK variants (CQM, CQS, and IQS) all carry the ST33 dTPM, a future board could potentially reuse shikra-evk.dtsi without supporting the TPM hardware. Keeping the node in the board-specific DTS files makes the hardware dependency explicit and avoids enabling TPM on boards where it may not be present.

>
> Konrad