Fix control flow in sas_ex_add_parent_port()

[PATCH v4 0/3] Fix control flow in sas_ex_add_parent_port()

Posted by Eshaan Deshmukh 1 month, 1 week ago

Fix label control flow for the function sas_ex_add_parent_port(). Remove
labels and move the code back to their original places.

Eshaan Deshmukh (3):
  scsi: libsas: Handle errors in sas_ex_add_parent_port()
  scsi: libsas: Handle errors in sas_set_ex_phy()
  scsi: libsas: Handle errors in  sas_ex_discover_expander()

 drivers/scsi/libsas/sas_expander.c | 75 ++++++++++++++++++++----------
 1 file changed, 50 insertions(+), 25 deletions(-)

-- 
2.55.0

Re: [PATCH v4 0/3] Fix control flow in sas_ex_add_parent_port()

Posted by John Garry 1 month, 1 week ago

On 19/08/2026 04:23, Eshaan Deshmukh wrote:
> 
> Fix label control flow for the function sas_ex_add_parent_port(). Remove
> labels and move the code back to their original places.
> 
> Eshaan Deshmukh (3):
>     scsi: libsas: Handle errors in sas_ex_add_parent_port()
>     scsi: libsas: Handle errors in sas_set_ex_phy()
>     scsi: libsas: Handle errors in  sas_ex_discover_expander()
> 
>    drivers/scsi/libsas/sas_expander.c | 75 ++++++++++++++++++++----------
>    1 file changed, 50 insertions(+), 25 deletions(-)

These changes look ok to me.

However they don't apply to the maintainers 7.3 staging branch - see 
mkp-scsi git. Regardless, we are in the merge window now, so I suggest 
that you rebase and post again when v7.3-rc1 is released.