096cd6b7adf2 ("scsi: ufs: ufs-pci: Add support for Intel Nova Lake")
added the PCI ID for Intel's UFS 4.0 controller (8086:D335), reusing
the existing Meteor Lake variant operations table. That table is
missing two things this controller needs to work correctly at UFS 4.0
capability: a PA_INITIAL_ADAPT sequence for reliable HS-Gear5 link
training, and the MCQ resource/runtime-config hooks required for
ufshcd_alloc_mcq() to succeed. Without either, the controller still
works, but silently falls back to Gear5 link instability or legacy
single-doorbell mode respectively.

Patch 1 adds a pwr_change_notify hook that configures
PA_INITIAL_ADAPT (resetting to the default PA_NO_ADAPT otherwise)
before Gear5 power mode changes.

Patch 2 adds the mcq_config_resource and op_runtime_config hooks,
with the OPR register offsets and stride this controller uses.

Both were validated on real NVL silicon: a 10-cycle reboot trial (5
minutes monitored each) with this exact configuration showed zero
UIC-layer errors throughout, and MCQ hardware queues were confirmed
carrying real doorbell traffic at the documented addresses.

sangram kumar yerra (2):
  scsi: ufs: ufs-pci: Add support for Intel UFS 4.0 HS-Gear5
  scsi: ufs: ufs-pci: Add MCQ support for Intel UFS 4.0 controllers

 drivers/ufs/host/ufshcd-pci.c | 59 +++++++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)

-- 
2.34.1

On Tue, 18 Aug 2026 16:58:28 +0530, sangram kumar yerra wrote:

> 096cd6b7adf2 ("scsi: ufs: ufs-pci: Add support for Intel Nova Lake")
> added the PCI ID for Intel's UFS 4.0 controller (8086:D335), reusing
> the existing Meteor Lake variant operations table. That table is
> missing two things this controller needs to work correctly at UFS 4.0
> capability: a PA_INITIAL_ADAPT sequence for reliable HS-Gear5 link
> training, and the MCQ resource/runtime-config hooks required for
> ufshcd_alloc_mcq() to succeed. Without either, the controller still
> works, but silently falls back to Gear5 link instability or legacy
> single-doorbell mode respectively.
> 
> [...]

Applied to 7.3/scsi-fixes, thanks!

[1/2] scsi: ufs: ufs-pci: Add support for Intel UFS 4.0 HS-Gear5
      https://git.kernel.org/mkp/scsi/c/ef675ea16845
[2/2] scsi: ufs: ufs-pci: Add MCQ support for Intel UFS 4.0 controllers
      https://git.kernel.org/mkp/scsi/c/c46cc9cee39b

-- 
Martin K. Petersen

sangram,

> 096cd6b7adf2 ("scsi: ufs: ufs-pci: Add support for Intel Nova Lake")
> added the PCI ID for Intel's UFS 4.0 controller (8086:D335), reusing
> the existing Meteor Lake variant operations table. That table is
> missing two things this controller needs to work correctly at UFS 4.0
> capability: a PA_INITIAL_ADAPT sequence for reliable HS-Gear5 link
> training, and the MCQ resource/runtime-config hooks required for
> ufshcd_alloc_mcq() to succeed. Without either, the controller still
> works, but silently falls back to Gear5 link instability or legacy
> single-doorbell mode respectively.

Applied to 7.3/scsi-staging, thanks!

-- 
Martin K. Petersen

On 8/18/26 4:28 AM, sangram kumar yerra wrote:
> [ ... ]

Reviewed-by: Bart Van Assche <bvanassche@acm.org>