[PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store()

Raushan Kumar posted 1 patch 1 month, 2 weeks ago
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store()
Posted by Raushan Kumar 1 month, 2 weeks ago
Remove the return statement at the end of the void function
gdc_reg_store(), as it's not needed since the function returns
implicitly, as flagged by checkpatch.pl.

Signed-off-by: Raushan Kumar <mitramaurya80@gmail.com>
---
 drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
index b31e3809c0e4..c60f53514553 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/gdc.c
@@ -96,5 +96,4 @@ static inline void gdc_reg_store(
     const hrt_data		value)
 {
 	ia_css_device_store_uint32(GDC_BASE[ID] + reg * sizeof(hrt_data), value);
-	return;
 }
-- 
2.55.0
Re: [PATCH] staging: media: atomisp: remove unnecessary return in gdc_reg_store()
Posted by Andy Shevchenko 1 month, 1 week ago
On Sat, Aug 15, 2026 at 12:31:05PM +0530, Raushan Kumar wrote:
> Remove the return statement at the end of the void function
> gdc_reg_store(), as it's not needed since the function returns
> implicitly, as flagged by checkpatch.pl.

Is it the only a single leftover in the entire driver?

...

Please, read lore.kernel.org linux-media@ archives against this driver to
understand what to do with this patch.

Also, if you are in a group that is mentored, tell to the mentors to stop
looking into this driver by a newbie. This driver has much more urgent tasks
to do and it's not trivial, it also requires a real HW to be at hand to test.

-- 
With Best Regards,
Andy Shevchenko