This driver cannot be built as a loadable module so testing for
"#ifdef MODULE" is not appropriate here.
Also, MODULE_LICENSE() is always available.

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>

 drivers/video/fbdev/maxinefb.c |    2 --
 1 file changed, 2 deletions(-)

--- linux-next-20260814.orig/drivers/video/fbdev/maxinefb.c
+++ linux-next-20260814/drivers/video/fbdev/maxinefb.c
@@ -169,9 +169,7 @@ static void __exit maxinefb_exit(void)
 	unregister_framebuffer(&fb_info);
 }
 
-#ifdef MODULE
 MODULE_LICENSE("GPL");
-#endif
 module_init(maxinefb_init);
 module_exit(maxinefb_exit);

On Fri, 14 Aug 2026, Randy Dunlap wrote:

> This driver cannot be built as a loadable module so testing for
> "#ifdef MODULE" is not appropriate here.
> Also, MODULE_LICENSE() is always available.

 It might best be reordered to the end of file, cf. pmagb-b-fb.c, though 
I'm not sure if we want to be pedantic enough to do it with a separate 
change.  Anyway:

Acked-by: Maciej W. Rozycki <macro@orcam.me.uk>

 NB making the driver modular ought to be trivial once this has become a 
platform device; I have converted all the TURBOchannel drivers already.  
I have hesitated poking at this one without a live specimen though.

  Maciej

On 8/17/26 19:09, Maciej W. Rozycki wrote:
> On Fri, 14 Aug 2026, Randy Dunlap wrote:
> 
>> This driver cannot be built as a loadable module so testing for
>> "#ifdef MODULE" is not appropriate here.
>> Also, MODULE_LICENSE() is always available.
> 
>   It might best be reordered to the end of file, cf. pmagb-b-fb.c, though
> I'm not sure if we want to be pedantic enough to do it with a separate
> change.

No need to send a seperate patch.
I've fixed it up accordingly and pushed the updated patch to the fbdev for-next
git tree while I added your Acked-by tags.

Helge

>  Anyway:
> 
> Acked-by: Maciej W. Rozycki <macro@orcam.me.uk>

>   NB making the driver modular ought to be trivial once this has become a
> platform device; I have converted all the TURBOchannel drivers already.
> I have hesitated poking at this one without a live specimen though.
> 
>    Maciej

On 8/14/26 20:42, Randy Dunlap wrote:
> This driver cannot be built as a loadable module so testing for
> "#ifdef MODULE" is not appropriate here.
> Also, MODULE_LICENSE() is always available.
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Cc: Helge Deller <deller@gmx.de>
> Cc: linux-fbdev@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>
> 
>   drivers/video/fbdev/maxinefb.c |    2 --
>   1 file changed, 2 deletions(-)
applied.
Thanks!
Helge