When the patch that became 0481a041e956 ("serial: 8250: split Moxa PCIe
serial board support out of 8250_pci") was created, commit 44e55f1f3088
("serial: 8250_pci: Consistently define pci_device_ids using named
initializers") wasn't applied yet and thus added an assignment to
.driver_data without using a named initializer. Adapt the assignment to
make the array consistent again and re-prepare the driver for the planned
change to struct pci_device_id.

Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
---
Hello,

if you prefer it, feel free to squash this change into 0481a041e956.
Otherwise I don't think this change justifies a Fixes: trailer, but
still it would be nice to get this in during the upcoming merge window.

Best regards
Uwe

 drivers/tty/serial/8250/8250_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
index c24a59896982..6e53d6d72a8e 100644
--- a/drivers/tty/serial/8250/8250_pci.c
+++ b/drivers/tty/serial/8250/8250_pci.c
@@ -3894,7 +3894,7 @@ static const struct pci_device_id blacklist[] = {
 	{ PCI_VDEVICE(ACCESSIO, PCI_ANY_ID), .driver_data = REPORT_8250_CONFIG(PERICOM), },
 
 	/* Moxa devices */
-	{ PCI_VDEVICE(MOXA, PCI_ANY_ID), REPORT_8250_CONFIG(MOXA), },
+	{ PCI_VDEVICE(MOXA, PCI_ANY_ID), .driver_data = REPORT_8250_CONFIG(MOXA), },
 
 	/* End of the black list */
 	{ }

base-commit: 0481a041e9569dfc2448ba4c6cb30335fcb8430f
-- 
2.55.0.11.g153666a7d9bb

Helo Greg,

On Fri, Aug 14, 2026 at 11:59:31AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> When the patch that became 0481a041e956 ("serial: 8250: split Moxa PCIe
> serial board support out of 8250_pci") was created, commit 44e55f1f3088
> ("serial: 8250_pci: Consistently define pci_device_ids using named
> initializers") wasn't applied yet and thus added an assignment to
> .driver_data without using a named initializer. Adapt the assignment to
> make the array consistent again and re-prepare the driver for the planned
> change to struct pci_device_id.
> 
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> if you prefer it, feel free to squash this change into 0481a041e956.
> Otherwise I don't think this change justifies a Fixes: trailer, but
> still it would be nice to get this in during the upcoming merge window.

Is this patch still on your radar?

Best regards
Uwe

On Wed, Sep 16, 2026 at 07:56:08AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Helo Greg,
> 
> On Fri, Aug 14, 2026 at 11:59:31AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > When the patch that became 0481a041e956 ("serial: 8250: split Moxa PCIe
> > serial board support out of 8250_pci") was created, commit 44e55f1f3088
> > ("serial: 8250_pci: Consistently define pci_device_ids using named
> > initializers") wasn't applied yet and thus added an assignment to
> > .driver_data without using a named initializer. Adapt the assignment to
> > make the array consistent again and re-prepare the driver for the planned
> > change to struct pci_device_id.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> > ---
> > Hello,
> > 
> > if you prefer it, feel free to squash this change into 0481a041e956.
> > Otherwise I don't think this change justifies a Fixes: trailer, but
> > still it would be nice to get this in during the upcoming merge window.
> 
> Is this patch still on your radar?

Yes, along with a few thousand more, sorry, way behind in reviews...