ALSA: hda/realtek: Drop duplicate quirk for Lenovo 0x17aa:0x38df

[PATCH] ALSA: hda/realtek: Drop duplicate quirk for Lenovo 0x17aa:0x38df

Posted by Zhang Heng 1 month, 2 weeks ago

The PCI SSID 17aa:38df is listed twice in alc269_fixup_tbl[], both mapping
to the same fixup ALC287_FIXUP_TAS2781_I2C:

  SND_PCI_QUIRK(0x17aa, 0x38df, "Yoga Y990 Intel YC Dual", ALC287_FIXUP_TAS2781_I2C),
  ...
  SND_PCI_QUIRK(0x17aa, 0x38df, "Y990 YG DUAL", ALC287_FIXUP_TAS2781_I2C),

The HDA quirk lookup (hda_quirk_lookup_id()) returns the first matching
entry, so the second occurrence never takes effect; it is dead code.

Drop the second entry.  The retained "Yoga Y990 Intel YC Dual" label also
follows the naming of the neighbouring 0x38e0 entry ("Yoga Y990 Intel VECO
Dual").

Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 sound/hda/codecs/realtek/alc269.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index be7287ea24ec..3f0e276fc606 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -8101,7 +8101,6 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x38df, "Yoga Y990 Intel YC Dual", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x38e0, "Yoga Y990 Intel VECO Dual", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x38f8, "Yoga Book 9i", ALC287_FIXUP_TAS2781_I2C),
-	SND_PCI_QUIRK(0x17aa, 0x38df, "Y990 YG DUAL", ALC287_FIXUP_TAS2781_I2C),
 	/* Legion 7 15ASH11 shares PCI SSID 17aa:38f9 with Thinkbook 16P Gen5;
 	 * use codec SSID to distinguish them
 	 */
-- 
2.25.1

Re: [PATCH] ALSA: hda/realtek: Drop duplicate quirk for Lenovo 0x17aa:0x38df

Posted by Takashi Iwai 1 month, 2 weeks ago

On Fri, 14 Aug 2026 10:41:01 +0200,
Zhang Heng wrote:
> 
> The PCI SSID 17aa:38df is listed twice in alc269_fixup_tbl[], both mapping
> to the same fixup ALC287_FIXUP_TAS2781_I2C:
> 
>   SND_PCI_QUIRK(0x17aa, 0x38df, "Yoga Y990 Intel YC Dual", ALC287_FIXUP_TAS2781_I2C),
>   ...
>   SND_PCI_QUIRK(0x17aa, 0x38df, "Y990 YG DUAL", ALC287_FIXUP_TAS2781_I2C),
> 
> The HDA quirk lookup (hda_quirk_lookup_id()) returns the first matching
> entry, so the second occurrence never takes effect; it is dead code.
> 
> Drop the second entry.  The retained "Yoga Y990 Intel YC Dual" label also
> follows the naming of the neighbouring 0x38e0 entry ("Yoga Y990 Intel VECO
> Dual").
> 
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>

Applied to for-next branch.  Thanks.


Takashi