sh: defconfig: enable the current M66592 UDC symbol

[PATCH v2] sh: defconfig: enable the current M66592 UDC symbol

Posted by Pengpeng Hou 1 month, 2 weeks ago

The M66592 UDC provider is built under CONFIG_USB_M66592. Several
SuperH defconfigs still enable the removed CONFIG_USB_GADGET_M66592
symbol.

Replace the stale entries with the current provider symbol.

Assisted-by: Codex:gpt-5
Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
---
Changes since v1: https://lore.kernel.org/all/20260624081843.7864-1-pengpeng@iscas.ac.cn/
- no source-code changes
- rebase all three affected SuperH defconfigs
- add the USB maintainers and list omitted from the first submission
- add the coding-assistant disclosure

The Kconfig/provider mapping was reviewed statically; no SuperH kernel
build was performed.

 arch/sh/configs/migor_defconfig   | 2 +-
 arch/sh/configs/sdk7786_defconfig | 2 +-
 arch/sh/configs/shx3_defconfig    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/sh/configs/migor_defconfig b/arch/sh/configs/migor_defconfig
index 1d9d543eef4c..bde70f3bf857 100644
--- a/arch/sh/configs/migor_defconfig
+++ b/arch/sh/configs/migor_defconfig
@@ -72,7 +72,7 @@ CONFIG_LOGO=y
 # CONFIG_LOGO_LINUX_VGA16 is not set
 # CONFIG_LOGO_LINUX_CLUT224 is not set
 CONFIG_USB_GADGET=y
-CONFIG_USB_GADGET_M66592=y
+CONFIG_USB_M66592=y
 CONFIG_USB_G_SERIAL=m
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_RS5C372=y
diff --git a/arch/sh/configs/sdk7786_defconfig b/arch/sh/configs/sdk7786_defconfig
index d6fa3a422e24..d40be415dcb9 100644
--- a/arch/sh/configs/sdk7786_defconfig
+++ b/arch/sh/configs/sdk7786_defconfig
@@ -147,7 +147,7 @@ CONFIG_USB_MON=y
 CONFIG_USB_OHCI_HCD=y
 CONFIG_USB_STORAGE=y
 CONFIG_USB_GADGET=y
-CONFIG_USB_GADGET_M66592=y
+CONFIG_USB_M66592=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_MAX6900=y
 CONFIG_RTC_DRV_SH=y
diff --git a/arch/sh/configs/shx3_defconfig b/arch/sh/configs/shx3_defconfig
index 0cb69a0b92cb..d7496ea9a9fc 100644
--- a/arch/sh/configs/shx3_defconfig
+++ b/arch/sh/configs/shx3_defconfig
@@ -79,7 +79,7 @@ CONFIG_USB=y
 CONFIG_USB_MON=y
 CONFIG_USB_R8A66597_HCD=m
 CONFIG_USB_GADGET=y
-CONFIG_USB_GADGET_M66592=y
+CONFIG_USB_M66592=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_SH=y
 CONFIG_UIO=m
-- 
2.50.1 (Apple Git-155)

Re: [PATCH v2] sh: defconfig: enable the current M66592 UDC symbol

Posted by John Paul Adrian Glaubitz 1 month, 2 weeks ago

Hi Pengpeng,

On Fri, 2026-08-14 at 15:55 +0800, Pengpeng Hou wrote:
> The M66592 UDC provider is built under CONFIG_USB_M66592. Several
> SuperH defconfigs still enable the removed CONFIG_USB_GADGET_M66592
> symbol.
> 
> Replace the stale entries with the current provider symbol.
> 
> Assisted-by: Codex:gpt-5
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> ---
> Changes since v1: https://lore.kernel.org/all/20260624081843.7864-1-pengpeng@iscas.ac.cn/
> - no source-code changes
> - rebase all three affected SuperH defconfigs
> - add the USB maintainers and list omitted from the first submission
> - add the coding-assistant disclosure
> 
> The Kconfig/provider mapping was reviewed statically; no SuperH kernel
> build was performed.
> 
>  arch/sh/configs/migor_defconfig   | 2 +-
>  arch/sh/configs/sdk7786_defconfig | 2 +-
>  arch/sh/configs/shx3_defconfig    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/sh/configs/migor_defconfig b/arch/sh/configs/migor_defconfig
> index 1d9d543eef4c..bde70f3bf857 100644
> --- a/arch/sh/configs/migor_defconfig
> +++ b/arch/sh/configs/migor_defconfig
> @@ -72,7 +72,7 @@ CONFIG_LOGO=y
>  # CONFIG_LOGO_LINUX_VGA16 is not set
>  # CONFIG_LOGO_LINUX_CLUT224 is not set
>  CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_M66592=y
> +CONFIG_USB_M66592=y
>  CONFIG_USB_G_SERIAL=m
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_RS5C372=y
> diff --git a/arch/sh/configs/sdk7786_defconfig b/arch/sh/configs/sdk7786_defconfig
> index d6fa3a422e24..d40be415dcb9 100644
> --- a/arch/sh/configs/sdk7786_defconfig
> +++ b/arch/sh/configs/sdk7786_defconfig
> @@ -147,7 +147,7 @@ CONFIG_USB_MON=y
>  CONFIG_USB_OHCI_HCD=y
>  CONFIG_USB_STORAGE=y
>  CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_M66592=y
> +CONFIG_USB_M66592=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_MAX6900=y
>  CONFIG_RTC_DRV_SH=y
> diff --git a/arch/sh/configs/shx3_defconfig b/arch/sh/configs/shx3_defconfig
> index 0cb69a0b92cb..d7496ea9a9fc 100644
> --- a/arch/sh/configs/shx3_defconfig
> +++ b/arch/sh/configs/shx3_defconfig
> @@ -79,7 +79,7 @@ CONFIG_USB=y
>  CONFIG_USB_MON=y
>  CONFIG_USB_R8A66597_HCD=m
>  CONFIG_USB_GADGET=y
> -CONFIG_USB_GADGET_M66592=y
> +CONFIG_USB_M66592=y
>  CONFIG_RTC_CLASS=y
>  CONFIG_RTC_DRV_SH=y
>  CONFIG_UIO=m

Thanks for catching this!

Would it be possible to add a Fixes tag? I assume it should reference the
commit that dropped CONFIG_USB_GADGET_M66592 and forgot to update the configs.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Re: [PATCH v2] sh: defconfig: enable the current M66592 UDC symbol

Posted by Geert Uytterhoeven 1 month, 2 weeks ago

On Fri, 14 Aug 2026 at 10:01, Pengpeng Hou <pengpeng@iscas.ac.cn> wrote:
> The M66592 UDC provider is built under CONFIG_USB_M66592. Several
> SuperH defconfigs still enable the removed CONFIG_USB_GADGET_M66592
> symbol.
>
> Replace the stale entries with the current provider symbol.
>
> Assisted-by: Codex:gpt-5
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>

Fixes: 193ab2a6070039e7 ("usb: gadget: allow multiple gadgets to be built")

> The Kconfig/provider mapping was reviewed statically; no SuperH kernel
> build was performed.

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> # build-tested

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2] sh: defconfig: enable the current M66592 UDC symbol

Posted by John Paul Adrian Glaubitz 1 week, 5 days ago

Hi Geert,

On Fri, 2026-08-14 at 10:32 +0200, Geert Uytterhoeven wrote:
> On Fri, 14 Aug 2026 at 10:01, Pengpeng Hou <pengpeng@iscas.ac.cn> wrote:
> > The M66592 UDC provider is built under CONFIG_USB_M66592. Several
> > SuperH defconfigs still enable the removed CONFIG_USB_GADGET_M66592
> > symbol.
> > 
> > Replace the stale entries with the current provider symbol.
> > 
> > Assisted-by: Codex:gpt-5
> > Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
> 
> Fixes: 193ab2a6070039e7 ("usb: gadget: allow multiple gadgets to be built")
> 
> > The Kconfig/provider mapping was reviewed statically; no SuperH kernel
> > build was performed.
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> # build-tested

Thanks, I'll pick up this patch and add the Fixes tag manually if b4 doesn't
do it automatically when downloading the series.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913