drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 --- 1 file changed, 3 deletions(-)
Remove the comment referencing an unresolved 'XXX' placeholder
and the commented-out memset() call it describes, rather than
fixing the placeholder in place.
Suggested-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Changes in v2:
- Removed the stale comment and dead commented-out memset() call, per Dan Carpenter review suggestion.
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index f31196f54b3e..e3f0b9c8123a 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -664,9 +664,6 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
/* add for CONFIG_IEEE80211W, none 11w also can use */
spin_lock_init(&padapter->security_key_mutex);
- /* We don't need to memset padapter->XXX to zero, because adapter is allocated by vzalloc(). */
- /* memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv)); */
-
if (_rtw_init_sta_priv(&padapter->stapriv) == _FAIL)
goto free_recv_priv;
---
base-commit: db2ddb87143519e20a95aa36c60b36107b736a58
change-id: 20260814-v2-attempt-final-45442f63b7e0
Best regards,
--
Tomasz Unger <tomasz.unger@yahoo.pl>
On Fri, Aug 14, 2026 at 09:26:06AM +0200, Tomasz Unger wrote: > Remove the comment referencing an unresolved 'XXX' placeholder > and the commented-out memset() call it describes, rather than > fixing the placeholder in place. > > Suggested-by: Dan Carpenter <error27@gmail.com> Normally, we wouldn't give a Suggested-by tag for review comments, but I won't turn down credit just because it's undeserved. > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > --- > Changes in v2: > - Removed the stale comment and dead commented-out memset() call, per Dan Carpenter review suggestion. Thanks! Reviewed-by: Dan Carpenter <error27@gmail.com> regards, dan carpenter
© 2016 - 2026 Red Hat, Inc.