rust_binder: use `LocalModule` for `THIS_MODULE`

[PATCH -next] rust_binder: use `LocalModule` for `THIS_MODULE`

Posted by Gary Guo 1 month, 2 weeks ago

From: Gary Guo <gary@garyguo.net>

Replace the `THIS_MODULE` static reference in the binder netlink code with
`this_module::<LocalModule>()`, consistent with the move of `THIS_MODULE`
into the `ModuleMetadata` trait.

Cc: Alvin Sun <alvin.sun@linux.dev>
Signed-off-by: Gary Guo <gary@garyguo.net>
---
This is to resolve the semantic conflict between rust-next and
char-misc-next.
---
 drivers/android/binder/netlink.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder/netlink.rs b/drivers/android/binder/netlink.rs
index beb7ea2edaff..f34e1009432c 100644
--- a/drivers/android/binder/netlink.rs
+++ b/drivers/android/binder/netlink.rs
@@ -13,7 +13,7 @@
 };
 
 pub static BINDER_NL_FAMILY: Family = Family::const_new(
-    &crate::THIS_MODULE,
+    kernel::module::this_module::<crate::LocalModule>(),
     kernel::uapi::BINDER_FAMILY_NAME,
     kernel::uapi::BINDER_FAMILY_VERSION,
     &BINDER_NL_FAMILY_MCGRPS,

base-commit: 2697ef8943c9985c14708a6429e21812693857b2
-- 
2.54.0

Re: [PATCH -next] rust_binder: use `LocalModule` for `THIS_MODULE`

Posted by Alvin Sun 1 month, 2 weeks ago

On 8/14/26 00:39, Gary Guo wrote:
> From: Gary Guo <gary@garyguo.net>
>
> Replace the `THIS_MODULE` static reference in the binder netlink code with
> `this_module::<LocalModule>()`, consistent with the move of `THIS_MODULE`
> into the `ModuleMetadata` trait.
>
> Cc: Alvin Sun <alvin.sun@linux.dev>
> Signed-off-by: Gary Guo <gary@garyguo.net>

Reviewed-by: Alvin Sun <alvin.sun@linux.dev>

> ---
> This is to resolve the semantic conflict between rust-next and
> char-misc-next.
> ---
>   drivers/android/binder/netlink.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder/netlink.rs b/drivers/android/binder/netlink.rs
> index beb7ea2edaff..f34e1009432c 100644
> --- a/drivers/android/binder/netlink.rs
> +++ b/drivers/android/binder/netlink.rs
> @@ -13,7 +13,7 @@
>   };
>   
>   pub static BINDER_NL_FAMILY: Family = Family::const_new(
> -    &crate::THIS_MODULE,
> +    kernel::module::this_module::<crate::LocalModule>(),
>       kernel::uapi::BINDER_FAMILY_NAME,
>       kernel::uapi::BINDER_FAMILY_VERSION,
>       &BINDER_NL_FAMILY_MCGRPS,
>
> base-commit: 2697ef8943c9985c14708a6429e21812693857b2

Re: [PATCH -next] rust_binder: use `LocalModule` for `THIS_MODULE`

Posted by Miguel Ojeda 1 month, 2 weeks ago

On Thu, Aug 13, 2026 at 6:40 PM Gary Guo <gary@kernel.org> wrote:
>
> From: Gary Guo <gary@garyguo.net>
>
> Replace the `THIS_MODULE` static reference in the binder netlink code with
> `this_module::<LocalModule>()`, consistent with the move of `THIS_MODULE`
> into the `ModuleMetadata` trait.
>
> Cc: Alvin Sun <alvin.sun@linux.dev>
> Signed-off-by: Gary Guo <gary@garyguo.net>
> ---
> This is to resolve the semantic conflict between rust-next and
> char-misc-next.

Thanks Gary!

Cheers,
Miguel